Trouble with adding unit to group

Shadow

TH.net Regular
Reaction score
23
Trying to add a unit to a unit group then when a unit enters circle of power give them all units in the unit group i but the unit isnt getting added for some reason

JASS:
scope Victory initializer onInit
    // Edit the values belows /////////////////////////////////////////////////////////
    globals
        public constant player TEAM_1_PLAYER = Player(0)
        public constant player TEAM_2_PLAYER = Player(6)
        public constant integer Wu_Commander_ID = 'H006'
        public constant integer Wei_Commander_ID = 'Hmkg'
         
    endglobals
    ///////////////////////////////////////////////////////////////////////////////////
    private function Filter_Func1 takes nothing returns boolean
        if IsPlayerAlly(GetFilterPlayer(),TEAM_1_PLAYER) then
            call CustomVictoryBJ(GetFilterPlayer(),true,true)
            return false
        endif
        call CustomDefeatBJ(GetFilterPlayer(),"Defeat!")
        return false
    endfunction

    public function VictoryTeam1 takes nothing returns nothing
        local force f = CreateForce()
        call ForceEnumPlayers(f,Filter(function Filter_Func1))
        call DestroyForce(f)
        set f = null
    endfunction

    private function Filter_Func2 takes nothing returns boolean
        if IsPlayerAlly(GetFilterPlayer(),TEAM_2_PLAYER) then
            call CustomVictoryBJ(GetFilterPlayer(),true,true)
            return false
        endif
        call CustomDefeatBJ(GetFilterPlayer(),"Defeat!")
        return false
    endfunction
    
    public function VictoryTeam2 takes nothing returns nothing
        local force f = CreateForce()
        call ForceEnumPlayers(f,Filter(function Filter_Func2))
        call DestroyForce(f)
        set f = null
    endfunction
    
    public function Conditions takes nothing returns boolean
        if IsUnitAlly(GetTriggerUnit(),Victory_TEAM_1_PLAYER) then
            call VictoryTeam2()
        else
            call VictoryTeam1()
        endif
        return false
    endfunction
         

    
    private function onInit takes nothing returns nothing
        local trigger t = CreateTrigger()
        local unit u = CreateUnit(Player(13),Wu_Commander_ID,-250,-9081,90)
        set armies_Army[1] = CreateGroup()
        call GroupAddUnit(armies_Army[1], u)
        call TriggerRegisterUnitEvent(t,u,EVENT_UNIT_DEATH)
        set u = null
        call TriggerRegisterUnitEvent(t,CreateUnit(Player(1),Wei_Commander_ID,2681,9006,270),EVENT_UNIT_DEATH)
        call TriggerAddCondition(t,Condition(function Conditions))
    endfunction
endscope


JASS:
scope SunQuan initializer onInit
 
public function ChangeOwner takes nothing returns nothing
    call KillUnit(GetTriggerUnit())
    call SetUnitOwner(GetEnumUnit(), GetOwningPlayer(GetTriggerUnit()), true)
endfunction

private function Conditions takes nothing returns boolean
    call ForGroup(armies_Army[1], function ChangeOwner)
    return false
endfunction

private function onInit takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterUnitInRange(t, CreateUnit(Player(13),'ncop',-5800,4370,90),100,null)
    call TriggerAddCondition(t,Condition(function Conditions))
    endfunction
endscope
 

emjlr3

Change can be a good thing
Reaction score
395
so what have you done to debug?
 

Shadow

TH.net Regular
Reaction score
23
I think I found my issue, in another trigger that happens after .05 secs

JASS:
        call CreateUnits(-200,-7843,3,2,'h003',90,Player(13))
call GroupEnumUnitsInRange(Army[1],-200,-7843,1000,Filter(function OwningPlayer))


I think its overwritten my previous data in group one is there something like GroupAddUnitEnumUnitsInRange?
or do I have to do something like

call GroupAddUnit(Army[1], GroupEnumUnitsInRange(...)) , if so having difficulty filling in the blanks.
 

Shadow

TH.net Regular
Reaction score
23
is there no native? cause when I inline I Get GroupAddUnit. Sorry im sorta new to jass all I want to is create units then add them to a group
 

emjlr3

Change can be a good thing
Reaction score
395
there is no groupaddgroup native
 

Shadow

TH.net Regular
Reaction score
23
so if you personally created units how would you add them to a group after they were created I guess is what im asking
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top