Why is this compiled but prevents map from running?

[Tyrande_ma3x]

I have this function in my trigger:

private function SpawnCreeps takes nothing returns nothing
    local integer a = 0
    loop
        exitwhen a > 3
        set temp = CreateUnit(Player(11), SPAWN_TYPE[GetRandomInt(0, 2)], GetRandomReal(GetRectMinX(SPAWN_RECTS[a]), GetRectMaxX(SPAWN_RECTS[a])), GetRandomReal(GetRectMinY(SPAWN_RECTS[a]), GetRectMaxY(SPAWN_RECTS[a])), GetRandomReal(1., 359.))
        call IssuePointOrder(temp, "attack", 0., 0.)
        set temp = CreateUnit(Player(11), SPAWN_TYPE[GetRandomInt(0, 2)], GetRandomReal(GetRectMinX(SPAWN_RECTS[a]), GetRectMaxX(SPAWN_RECTS[a])), GetRandomReal(GetRectMinY(SPAWN_RECTS[a]), GetRectMaxY(SPAWN_RECTS[a])), GetRandomReal(1., 359.))
        call IssuePointOrder(temp, "attack", 0., 0.)
        set a = a + 1
    endloop
endfunction

As long as it is there, I cannot start the map in any way - as if it was treated as a return bug or false positive of some sort. I was thinking if it's something Blizzard screwed up because I can't see what could be wrong with it.

The full code (it's heavily commented because I was testing which parts aren't working - you know, disable, save, test - and in the end that function seemed to be the problem):

library SpawningLib initializer Init uses EnumUtils

globals
    private constant real WAIT_BEFORE_SPAWN = 30.
    private constant real SPAWN_PERIOD = 15.
    private constant string MSG_BEFORE_SPAWN = "Creeps will spawn in |cffffcc0030|r seconds."
endglobals
    
globals
    timer SPAWNING_TIMER = null
    rect array SPAWN_RECTS
    integer array SPAWN_TYPE
endglobals
/*
private function SpawnCreeps takes nothing returns nothing
    local integer a = 0
    loop
        exitwhen a > 3
        set temp = CreateUnit(Player(11), SPAWN_TYPE[GetRandomInt(0, 2)], GetRandomReal(GetRectMinX(SPAWN_RECTS[a]), GetRectMaxX(SPAWN_RECTS[a])), GetRandomReal(GetRectMinY(SPAWN_RECTS[a]), GetRectMaxY(SPAWN_RECTS[a])), GetRandomReal(1., 359.))
        call IssuePointOrder(temp, "attack", 0., 0.)
        set temp = CreateUnit(Player(11), SPAWN_TYPE[GetRandomInt(0, 2)], GetRandomReal(GetRectMinX(SPAWN_RECTS[a]), GetRectMaxX(SPAWN_RECTS[a])), GetRandomReal(GetRectMinY(SPAWN_RECTS[a]), GetRectMaxY(SPAWN_RECTS[a])), GetRandomReal(1., 359.))
        call IssuePointOrder(temp, "attack", 0., 0.)
        set a = a + 1
    endloop
endfunction
*/
private function WaitBeforeSpawn takes nothing returns nothing
    //call SpawnCreeps()
    //call TimerStart(SPAWNING_TIMER, SPAWN_PERIOD, true, function SpawnCreeps)
endfunction

private function Init takes nothing returns nothing
    //set SPAWNING_TIMER = CreateTimer()
    //if IsPlayerInForce(GetLocalPlayer(), bj_FORCE_ALL_PLAYERS) then
       // call DisplayTextToPlayer(GetLocalPlayer(), 0., 0., MSG_BEFORE_SPAWN)
    //endif
    call TimerStart(SPAWNING_TIMER, WAIT_BEFORE_SPAWN, false, function WaitBeforeSpawn)
    /*
    set SPAWN_RECTS[0] = gg_rct_SPAWN_RECT1
    set SPAWN_RECTS[1] = gg_rct_SPAWN_RECT2
    set SPAWN_RECTS[2] = gg_rct_SPAWN_RECT3
    set SPAWN_RECTS[3] = gg_rct_SPAWN_RECT4
    
    set SPAWN_TYPE[0] = 'h009'
    set SPAWN_TYPE[1] = 'h00A'
    set SPAWN_TYPE[2] = 'o004'
    */
endfunction

endlibrary

EDIT: Ok, I found the error. It is in this line:

set temp = CreateUnit(Player(11), SPAWN_TYPE[GetRandomInt(0, 2)], GetRandomReal(GetRectMinX(SPAWN_RECTS[a]), GetRectMaxX(SPAWN_RECTS[a])), GetRandomReal(GetRectMinY(SPAWN_RECTS[a]), GetRectMaxY(SPAWN_RECTS[a])), GetRandomReal(1., 359.))

Using only "call CreateUnit()" WORKS and makes the map playable again. But when it comes to "set temp = CreateUnit()" it is treated as some sort of error... Why?

 

[saw792]

I don't see a temp variable declared anywhere...

 

[Tyrande_ma3x]

library SpawningLib initializer Init uses EnumUtils

Here:

library EnumUtils 

globals
    unit fir = null
    unit pass = null
    unit dum = null
    unit temp = null
endglobals

globals
    private real life = 0.
    private real current = 0.
    private unit last = null
endglobals

function GetUnitLowestLife takes real x, real y, real aoe, boolexpr condition returns unit
    set life = 9999999.
    set last = null
    call GroupEnumUnitsInRange(ENUM_GROUP, x, y, aoe, condition)
    loop
        set fir = FirstOfGroup(ENUM_GROUP)
        exitwhen fir == null
        set current = GetWidgetLife(fir)
        if current <= life then
            set last = fir
            set life = current
        endif
        call GroupRemoveUnit(ENUM_GROUP, fir)
    endloop
    return last
endfunction

endlibrary

 

[Sevion]

Maybe try inlining the CreateUnit with the IssueOrder and get rid of the temp var all together?

 

[Tyrande_ma3x]

call IssuePointOrder(CreateUnit(Player(0), SPAWN_TYPE[GetRandomInt(0, 2)], GetRandomReal(GetRectMinX(SPAWN_RECTS[a]), GetRectMaxX(SPAWN_RECTS[a])), GetRandomReal(GetRectMinY(SPAWN_RECTS[a]), GetRectMaxY(SPAWN_RECTS[a])), GetRandomReal(1., 359.)), "attack", 0., 0.)

Enormous line is enormous. It works but it isn't really a good option since I might need 4-5 calls for that unit in the near future. I hope it gets fixed in 1.24b...

 

[Sevion]

What do you mean you need 4-5 calls for it in the near future?

I don't see anything storing it for use outside of the function right now

 

[Tyrande_ma3x]

> set temp = CreateUnit(...
That's why I was setting it to a variable, so I can easily use it if I need the unit to do more stuff (or to store some data for it). Currently it isn't achievable but I'll get over it...