Spell flaws, looking for sharp eyes to pin-point error =/

LearningCode

LearningCode

New Member
Reaction score
24
The spell is supposed to create One of Two possible dummy units:
h004 (Fire)
h005 (Ice)

Depending on which element the hero has activated:
A01P (Fire)
A01S (Ice)

Problem is, it creates the dummy, but deals no damage, even when an enemy unit is in range.

It displays only one Debug Message out of 3 I have placed
Works Without If (Displays)
First If (Does Not Display)
Second If (Does Not Display)

Here is the trigger :confused:
Function FamiliarGroup is the one that's malfunctioning =/

JASS:
struct FamiliarVar
   unit u
   real x
   real y
   real rad
   real xC
   real yC
   timer t
   group g
   real r=400.00
   integer i = 0
   unit h
endstruct

function FamiliarCond takes nothing returns boolean
   return GetSpellAbilityId() == 'A01Y' and GetUnitAbilityLevel(GetTriggerUnit(), 'A01S') > 0
   return GetSpellAbilityId() == 'A01Y' and GetUnitAbilityLevel(GetTriggerUnit(), 'A01P') > 0
endfunction

function FamiliarGroup takes nothing returns nothing
   local integer Agility = GetHeroAgi(GetTriggerUnit(), true)
   local integer NapalmLevel
   local real NapalmDmg
   local real x = GetUnitX(GetEnumUnit())
   local real y = GetUnitY(GetEnumUnit())
   local location l = GetUnitLoc(GetEnumUnit())
   local unit u
   BJDebugMsg("Works Without If")
    
    if GetUnitAbilityLevel(GetTriggerUnit(), 'A01S') > 0 then
        BJDebugMsg("First If")
        set NapalmLevel = GetUnitAbilityLevel(GetTriggerUnit(), 'A01S')
        if ModuloInteger(NapalmLevel, 2) == 0 then
            set NapalmDmg = I2R(R2I((((NapalmLevel * 0.5) * Agility))))
        else
            set NapalmDmg = I2R(R2I(((((NapalmLevel+1) * 0.5) * Agility))))
        endif
    elseif GetUnitAbilityLevel(GetTriggerUnit(), 'A01P') > 0
        BJDebugMsg("First If")
        set NapalmLevel = GetUnitAbilityLevel(GetTriggerUnit(), 'A01P')
        set NapalmDmg = I2R(R2I(((((NapalmLevel * 0.11)+0.11) * Agility)))) + (NapalmLevel * 5)
    endif   
    
    
    if IsPlayerAlly(GetOwningPlayer(GetEnumUnit()), GetOwningPlayer(GetTriggerUnit())) == false then
        call UnitDamageTarget(GetTriggerUnit(), GetEnumUnit(), NapalmDmg, false, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, WEAPON_TYPE_WHOKNOWS)
        if GetUnitAbilityLevel(GetTriggerUnit(), 'A01P') > 0 then
            BJDebugMsg("Second If")
            call DestroyEffect(AddSpecialEffectTarget("Environment\\UndeadBuildingFire\\UndeadLargeBuildingFire2.mdl", GetEnumUnit(), "chest"))
            call UnitAddAbility(GetEnumUnit(), 'Aroa')
            call IssueImmediateOrder(GetEnumUnit(), "roar")
            call UnitRemoveAbility(GetEnumUnit(), 'Aroa')
            call CreateTextTagLocBJ( I2S(R2I(NapalmDmg))+"!", l, 0, 10, 100, 0,0, 0 )
        else
            BJDebugMsg("Second If")
            call DestroyEffect(AddSpecialEffectTarget("Abilities\\Spells\\Undead\\FrostArmor\\FrostArmorDamage.mdl", GetEnumUnit(), "chest"))
            set u = CreateUnit(GetOwningPlayer(GetTriggerUnit()), 'h01O', x, y, bj_UNIT_FACING)
            call UnitAddAbility(u, 'ANab')
            call SetUnitAbilityLevel(u, 'ANab', NapalmLevel)
            call IssueTargetOrder(u, "acidbomb", GetEnumUnit())
            call UnitApplyTimedLife(u, 'BTLF', 1.00)
            set u = null
            call CreateTextTagLocBJ( I2S(R2I(NapalmDmg))+"!", l, 0, 10, 0, 0, 100, 0 )
        endif
        call SetTextTagLifespanBJ( bj_lastCreatedTextTag, 1.00 )
        call SetTextTagPermanentBJ( bj_lastCreatedTextTag, false )
    endif
    
    call RemoveLocation(l)
    set l = null

endfunction

function FamiliarMove takes nothing returns nothing
   local FamiliarVar fv = GetTimerData(GetExpiredTimer())
   set fv.g = CreateGroup()
   call GroupEnumUnitsInRange(fv.g,fv.x, fv.y, 200.00, null) 
   call ForGroup(fv.g, function FamiliarGroup)
   set fv.rad = fv.rad+0.175
   set fv.xC = GetUnitX(fv.h)
   set fv.yC = GetUnitY(fv.h)
   set fv.x = fv.xC + fv.r * Cos(fv.rad)
   set fv.y = fv.yC + fv.r * Sin(fv.rad)
   call IssuePointOrder(fv.u, "move", fv.x, fv.y)
   set fv.i = fv.i + 1
   if fv.i == 100
      call fv.destroy()
      call PauseTimer(fv.t)
      call DestroyTimer(fv.t)
      call KillUnit(fv.u)
      call RemoveUnit(fv.u)
      set fv.u = null
   endif
   call GroupClear(fv.g)
   call DestroyGroup(fv.g)
   set fv.g = null
endfunction

function FamiliarAct takes nothing returns nothing
   local FamiliarVar fv = FamiliarVar.create()
   set fv.t = NewTimer()
   set fv.h = GetTriggerUnit()
   call SetTimerData(fv.t,fv)
   set fv.xC = GetUnitX(fv.h)
   set fv.yC = GetUnitY(fv.h)
   set fv.rad = (GetUnitFacing(fv.h) * bj_DEGTORAD)
   set fv.x = fv.xC + fv.r * Cos(fv.rad)
   set fv.y = fv.yC + fv.r * Sin(fv.rad)
   if GetUnitAbilityLevel(fv.h, 'A01P') > 0 then
      set fv.u = CreateUnit(GetOwningPlayer(fv.h), 'h004', fv.x, fv.y, (GetUnitFacing(fv.h)+90.00))
   else
      set fv.u = CreateUnit(GetOwningPlayer(fv.h), 'h005', fv.x, fv.y, (GetUnitFacing(fv.h)+90.00))
   endif
   call TimerStart(fv.t, 0.13, true, function FamiliarMove)
endfunction

//===========================================================================
function InitTrig_Familiar_Copy takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    local integer i = 0
    loop
    exitwhen i == 8
    call TriggerRegisterPlayerUnitEvent(t, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
    set i = i+1
    endloop
    call TriggerAddCondition(t, Condition(function FamiliarCond))
    call TriggerAddAction( t, function FamiliarAct )
endfunction


[EDIT]
Apparently, using [lJASS]GetTriggerUnit()[/lJASS] is wrong.
[lJASS]BJDebugMsg(I2S(Agility))[/lJASS] Returned [lJASS]0[/lJASS], meaning, it couldn't get the Agility of [lJASS]GetTriggerUnit()[/lJASS]
But I tried using structs and JASSHelper told me that I'm using the wrong syntax=/

How would I use structs in this case.. ?
But even if [lJASS]GetTriggerUnit()[/lJASS] was the problem..
It should have displayed the floating text or created the dummies to cast spells on the affected units..

Right?


[EDIT=2]
Okay, I now can use the structs without JASSHelper giving me errors =x
But It still only shows me One Debug message, and it's the same one =/

JASS:
struct FamiliarVar
   unit u
   real x
   real y
   real rad
   real xC
   real yC
   timer t
   group g
   real r=400.00
   integer i = 0
   unit h
endstruct

function FamiliarCond takes nothing returns boolean
   return GetSpellAbilityId() == 'A01Y' and GetUnitAbilityLevel(GetTriggerUnit(), 'A01S') > 0
   return GetSpellAbilityId() == 'A01Y' and GetUnitAbilityLevel(GetTriggerUnit(), 'A01P') > 0
endfunction

function FamiliarGroup takes nothing returns nothing
   local FamiliarVar fv = FamiliarVar.create()
   local integer Agility = GetHeroAgi(fv.h, true)
   local integer NapalmLevel
   local real NapalmDmg
   local real x = GetUnitX(GetEnumUnit())
   local real y = GetUnitY(GetEnumUnit())
   local location l = GetUnitLoc(GetEnumUnit())
   local unit u
   BJDebugMsg("Works Without If"+I2S(Agility))
    
    if GetUnitAbilityLevel(fv.h, 'A01S') > 0 then
        BJDebugMsg("First If")
        set NapalmLevel = GetUnitAbilityLevel(fv.h, 'A01S')
        if ModuloInteger(NapalmLevel, 2) == 0 then
            set NapalmDmg = I2R(R2I((((NapalmLevel * 0.5) * Agility))))
        else
            set NapalmDmg = I2R(R2I(((((NapalmLevel+1) * 0.5) * Agility))))
        endif
    elseif GetUnitAbilityLevel(fv.h, 'A01P') > 0
        BJDebugMsg("First If")
        set NapalmLevel = GetUnitAbilityLevel(fv.h, 'A01P')
        set NapalmDmg = I2R(R2I(((((NapalmLevel * 0.11)+0.11) * Agility)))) + (NapalmLevel * 5)
    endif   
    
    
    if IsPlayerAlly(GetOwningPlayer(GetEnumUnit()), GetOwningPlayer(fv.h)) == false then
        call UnitDamageTarget(GetTriggerUnit(), GetEnumUnit(), NapalmDmg, false, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, WEAPON_TYPE_WHOKNOWS)
        if GetUnitAbilityLevel(GetTriggerUnit(), 'A01P') > 0 then
            BJDebugMsg("Second If")
            call DestroyEffect(AddSpecialEffectTarget("Environment\\UndeadBuildingFire\\UndeadLargeBuildingFire2.mdl", GetEnumUnit(), "chest"))
            call UnitAddAbility(GetEnumUnit(), 'Aroa')
            call IssueImmediateOrder(GetEnumUnit(), "roar")
            call UnitRemoveAbility(GetEnumUnit(), 'Aroa')
            call CreateTextTagLocBJ( I2S(R2I(NapalmDmg))+"!", l, 0, 10, 100, 0,0, 0 )
        else
            BJDebugMsg("Second If")
            call DestroyEffect(AddSpecialEffectTarget("Abilities\\Spells\\Undead\\FrostArmor\\FrostArmorDamage.mdl", GetEnumUnit(), "chest"))
            set u = CreateUnit(GetOwningPlayer(fv.h), 'h01O', x, y, bj_UNIT_FACING)
            call UnitAddAbility(u, 'ANab')
            call SetUnitAbilityLevel(u, 'ANab', NapalmLevel)
            call IssueTargetOrder(u, "acidbomb", GetEnumUnit())
            call UnitApplyTimedLife(u, 'BTLF', 1.00)
            set u = null
            call CreateTextTagLocBJ( I2S(R2I(NapalmDmg))+"!", l, 0, 10, 0, 0, 100, 0 )
        endif
        call SetTextTagLifespanBJ( bj_lastCreatedTextTag, 1.00 )
        call SetTextTagPermanentBJ( bj_lastCreatedTextTag, false )
    endif
    
    call RemoveLocation(l)
    set l = null

endfunction

function FamiliarMove takes nothing returns nothing
   local FamiliarVar fv = GetTimerData(GetExpiredTimer())
   set fv.g = CreateGroup()
   call GroupEnumUnitsInRange(fv.g,fv.x, fv.y, 200.00, null) 
   call ForGroup(fv.g, function FamiliarGroup)
   set fv.rad = fv.rad+0.175
   set fv.xC = GetUnitX(fv.h)
   set fv.yC = GetUnitY(fv.h)
   set fv.x = fv.xC + fv.r * Cos(fv.rad)
   set fv.y = fv.yC + fv.r * Sin(fv.rad)
   call IssuePointOrder(fv.u, "move", fv.x, fv.y)
   set fv.i = fv.i + 1
   if fv.i == 100
      call fv.destroy()
      call PauseTimer(fv.t)
      call DestroyTimer(fv.t)
      call KillUnit(fv.u)
      call RemoveUnit(fv.u)
      set fv.u = null
   endif
   call GroupClear(fv.g)
   call DestroyGroup(fv.g)
   set fv.g = null
endfunction

function FamiliarAct takes nothing returns nothing
   local FamiliarVar fv = FamiliarVar.create()
   set fv.t = NewTimer()
   set fv.h = GetTriggerUnit()
   call SetTimerData(fv.t,fv)
   set fv.xC = GetUnitX(fv.h)
   set fv.yC = GetUnitY(fv.h)
   set fv.rad = (GetUnitFacing(fv.h) * bj_DEGTORAD)
   set fv.x = fv.xC + fv.r * Cos(fv.rad)
   set fv.y = fv.yC + fv.r * Sin(fv.rad)
   if GetUnitAbilityLevel(fv.h, 'A01P') > 0 then
      set fv.u = CreateUnit(GetOwningPlayer(fv.h), 'h004', fv.x, fv.y, (GetUnitFacing(fv.h)+90.00))
   else
      set fv.u = CreateUnit(GetOwningPlayer(fv.h), 'h005', fv.x, fv.y, (GetUnitFacing(fv.h)+90.00))
   endif
   call TimerStart(fv.t, 0.13, true, function FamiliarMove)
endfunction

//===========================================================================
function InitTrig_Familiar_Copy takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    local integer i = 0
    loop
    exitwhen i == 8
    call TriggerRegisterPlayerUnitEvent(t, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
    set i = i+1
    endloop
    call TriggerAddCondition(t, Condition(function FamiliarCond))
    call TriggerAddAction( t, function FamiliarAct )
endfunction
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1

      The Helper Discord

      Members online

      No members online now.
      Online now:
      120 (members: 2, guests: 118)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top