Apply timed life not working and memory leaks

S

superkar

New Member
Reaction score
0
Well! I've made this ability called Absorb. It deals damage to enemies in 400 range and gives back 20% of that damage to the caster. I had to make 2 dummy abilities ( ON and OFF) to make it work properly, here is the code!
AbsorbON triggers:

Code: 
function Trig_Absorb_Effect_Conditions takes nothing returns boolean
    if  ( GetSpellAbilityId() == udg_AbsorbON ) then
        return true
    endif
    return false
endfunction
 
function Absorb_Effect_Pick_Condition takes nothing returns boolean
    if ( IsUnitAlly(GetFilterUnit(), Player(0)) == true ) or (IsUnitDeadBJ(GetFilterUnit()) == true) or (IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) == true) or (IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) == true) then
        return false
    endif
    return true
endfunction
 
function Absorb_Effect_Picked_Effect takes nothing returns nothing   
    local unit targ = GetEnumUnit()
    local unit cast = GetTriggerUnit()
    local real dmg = GetWidgetLife(targ)
    set udg_loc = GetUnitLoc(targ)
    call UnitDamageTarget(cast, targ, 10, false, false, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_FIRE, null)
    set dmg = dmg - GetWidgetLife(targ)
    call SetUnitLifeBJ( cast, ( GetUnitStateSwap(UNIT_STATE_LIFE, cast) + dmg/5 ) )
    call DisplayTextToForce(GetPlayersAll(), R2S(dmg))
    call CreateNUnitsAtLoc( 1, 'h001', Player(PLAYER_NEUTRAL_PASSIVE), udg_loc, 0 )
    call RemoveLocation (udg_loc)
    call UnitApplyTimedLifeBJ( 0.99, 'BTLF', GetLastCreatedUnit() )
endfunction
 
function Trig_Absorb_Effect_Actions takes nothing returns nothing
    call AddSpecialEffectTargetUnitBJ( "chest", GetTriggerUnit(), "Objects\\Spawnmodels\\Undead\\UDeathMedium\\UDeath.mdl" )
    call DestroyEffectBJ( GetLastCreatedEffectBJ() )
    call UnitRemoveAbilityBJ( udg_AbsorbON, GetTriggerUnit() )
    call UnitAddAbilityBJ( udg_AbsorbOFF, GetTriggerUnit() )
    call CreateNUnitsAtLoc( 1, 'h000', Player(PLAYER_NEUTRAL_PASSIVE), GetUnitLoc(GetTriggerUnit()), 0 )
    set udg_AbsorbDummyUnitEffect = GetLastCreatedUnit()
    loop
        exitwhen (GetUnitAbilityLevel(GetTriggerUnit(), 'A003') == 0)
        set udg_loc = GetUnitLoc(GetTriggerUnit())
        set udg_group = GetUnitsInRangeOfLocMatching(400.00, udg_loc, Condition(function Absorb_Effect_Pick_Condition))
        call RemoveLocation (udg_loc)
        call ForGroupBJ( udg_group, function Absorb_Effect_Picked_Effect )
        call DestroyGroup (udg_group)
        call TriggerSleepAction( 1 )
    endloop
   
endfunction
 
//===========================================================================
function InitTrig_Absorb_Effect takes nothing returns nothing
    set gg_trg_Absorb_Effect = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Absorb_Effect, EVENT_PLAYER_UNIT_SPELL_CHANNEL )
    call TriggerAddCondition( gg_trg_Absorb_Effect, Condition( function Trig_Absorb_Effect_Conditions ) )
    call TriggerAddAction( gg_trg_Absorb_Effect, function Trig_Absorb_Effect_Actions )
endfunction

And AbsorbOFF triggers:

Code: 
function Trig_Absorb_OFF_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == udg_AbsorbOFF ) ) then
        return false
    endif
    return true
endfunction
 
function Trig_Absorb_OFF_Actions takes nothing returns nothing
    call RemoveUnit( udg_AbsorbDummyUnitEffect )
    call UnitRemoveAbilityBJ( udg_AbsorbOFF, GetTriggerUnit() )
    call UnitAddAbilityBJ( 'A004', GetTriggerUnit() )
    call IssueImmediateOrderBJ( GetTriggerUnit(), "howlofterror" )
    call TriggerSleepAction( 3.00 )
    call UnitRemoveAbilityBJ( 'A004', GetTriggerUnit() )
    call UnitAddAbilityBJ( udg_AbsorbON, GetTriggerUnit() )
endfunction
 
//===========================================================================
function InitTrig_Absorb_OFF takes nothing returns nothing
    set gg_trg_Absorb_OFF = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Absorb_OFF, EVENT_PLAYER_UNIT_SPELL_CHANNEL )
    call TriggerAddCondition( gg_trg_Absorb_OFF, Condition( function Trig_Absorb_OFF_Conditions ) )
    call TriggerAddAction( gg_trg_Absorb_OFF, function Trig_Absorb_OFF_Actions )
endfunction

Some explanation! When AbsorbOn is cast, this ability is removed and a loop that requires the caster to have AbsorbOFF starts: every 1 second, every unit in 400 range of the caster is picked, damage is dealt to them, a special effect is created in their position using a dummy unit, these dummies are set to die .99 seconds after and some life is given to the caster (20% of the dmg). If the player uses AbsorbOFF, this ability is taken away, so the loop stops. Another dummy ability is given and used to put a cooldown (couldn't think of anything better as there is no "put ability on cooldown" action), after this cooldown the dummy is removed and AbsorbON is given back. Following some guides, I've tried to solve leak problems, correct me if I am wrong, but the ability kept on lagging (up to making the game unplayable). I created a trigger to count units on the map and it says that the unit count keeps on getting higher and higher while the ability is ON. So I guess the dummy units for the special effect on targets are not dying. I tried to not create the dummies but the lag is the same.

SO! I can see I have 2 problems, one is the fact that dummies are not dying, the other is that there is some leaking, not depending on the dummies not dying. What am I doing wrong?? Help please!!
 
dracolich

dracolich

TH.net Regular
Reaction score
15
why do you use another units to provide visual? enormous summon of units cause lags itself, regardless anything.
 
S

superkar

New Member
Reaction score
0
The lag doesn't depend on the dummy units being created, it actually appears mostly when AbsorbOFF is used! Anyway, if I used a special effect, I wouldn't be able to destroy it after 1 second as the commands are inside a "pick" loop
 
dracolich

dracolich

TH.net Regular
Reaction score
15
of course u can. just save them in hashtable?
u use
local unit targ = GetEnumUnit()
local unit cast = GetTriggerUnit()
but dont null them.
if you wonder about timelife then change dummy's model to selectable one (remove locust ability too) and change PLAYER_PASSIVE to trigger player. Then select it and check for timeline.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/
  • The Helper The Helper:
    New recipe is Cheeseburger Pie! https://www.thehelper.net/threads/recipe-cheeseburger-pie.194191/

      The Helper Discord

      Members online

      Online now:
      289 (members: 2, guests: 287)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top