How can I exist this loop using custom script?

Lightstalker

New Member
Reaction score
55
I need to exit the following loop when the ability cast is equal to ability integer A. How to do this? +rep

Trigger:
  • Allocate Skills
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • Ability_Points[(Player number of (Owner of (Triggering unit)))] Greater than or equal to 1
    • Actions
      • For each (Integer A) from 1 to 12, do (Actions)
        • Loop - Actions
          • Set Ability_Integer = (Integer A))
 

_whelp

New Member
Reaction score
54
Try this.

Trigger:
  • Allocate Skills
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • Ability_Points[(Player number of (Owner of (Triggering unit)))] Greater than or equal to 1
    • Actions
      • Custom Script: local integer i = 1
      • Custom Script: loop
      • Custom Script: exitwhen i == 12 or udg_Ability_Integer == i
      • Custom Script: set udg_Ability_Integer = i
      • Custom Script: endloop
 

Tom Jones

N/A
Reaction score
437
Try this.

Trigger:
  • Allocate Skills
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • Ability_Points[(Player number of (Owner of (Triggering unit)))] Greater than or equal to 1
    • Actions
      • Custom Script: local integer i = 1
      • Custom Script: loop
      • Custom Script: exitwhen i == 12 or udg_Ability_Integer == i
      • Custom Script: set udg_Ability_Integer = i
      • Custom Script: endloop
Care to revise the above a little? [del]No point in giving the poor guy a endless loop :)[/del]
 

Lightstalker

New Member
Reaction score
55
Try this.

Trigger:
  • Allocate Skills
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • Ability_Points[(Player number of (Owner of (Triggering unit)))] Greater than or equal to 1
    • Actions
      • Custom Script: local integer i = 1
      • Custom Script: loop
      • Custom Script: exitwhen i == 12 or udg_Ability_Integer == i
      • Custom Script: set udg_Ability_Integer = i
      • Custom Script: endloop

do you know anything one line? like

JASS:
Custom script:   exitwhen (GetItemTypeId(udg_Ability_Sold) == udg_RandomAbility_Item[udg_Ability_Integer])
 

WolfieeifloW

WEHZ Helper
Reaction score
372
Care to revise the above a little? No point in giving the poor guy a endless loop :)
I don't think it's endless is it?
It just sets the udg_Ability_Integer to i after the first run so the second run through is automatically exited because it meets the condition.
 

WolfieeifloW

WEHZ Helper
Reaction score
372
Code:
Custom Script: exitwhen i == 12 or udg_Ability_Integer == i
Custom Script: set udg_Ability_Integer = i
The second condition isn't met the first run through;
But on the second run, since udg_Ability_Integer got set to "i", udg_Ability_Integer == i would be true (and the loop would stop) .
 

Tom Jones

N/A
Reaction score
437
Oh, indeed you're right. However then the script serves no purpose, all it does is set udg_Ability_Integer to 1. I can find easier methods to set my variables to one. My first comment still stands.
 

Tom Jones

N/A
Reaction score
437
One is sufficient:

Trigger:
  • For each (Integer A) from 1 to 12, do (Actions)
    • Loop - Actions
      • Custom script: exitwhen bj_forLoopAIndex == udg_Ability_Integer
 

Lightstalker

New Member
Reaction score
55
One is sufficient:

Trigger:
  • For each (Integer A) from 1 to 12, do (Actions)
    • Loop - Actions
      • Custom script: exitwhen bj_forLoopAIndex == udg_Ability_Integer

Damn I thought it worked but it doesn't. Maybe I didn't explain well enough so Here's the trigger:

Trigger:
  • Allocating Skills
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • And - All (Conditions) are true
        • Conditions
          • ((Triggering unit) is A Hero) Equal to True
          • Ability_Points[(Player number of (Owner of (Triggering unit)))] Greater than or equal to 1
    • Actions
      • Set Ability_Cast = (Ability being cast)
      • For each (Integer A) from 1 to 12, do (Actions)
        • Loop - Actions
          • Set Ability_Integer = (Integer A)
          • <b><u><span style="color: Red">(EXIT LOOP HERE when Ability Cast = Ability_Learn[Ability_Integer])</span></u></b>
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Ability being cast) Equal to Ability_Learn[Ability_Integer]
        • Then - Actions
          • Unit - Increase level of Ability_Cast for (Triggering unit)
          • Unit - Increase level of Ability_Use[(Integer A)] for (Triggering unit)
        • Else - Actions


I need custom script for the line in bold and red. ((EXIT LOOP HERE when Ability Cast = Ability_Learn[Ability_Integer])
 

Artificial

Without Intelligence
Reaction score
326
Trigger:
  • Allocating Skills
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • And - All (Conditions) are true
        • Conditions
          • ((Triggering unit) is A Hero) Equal to True
          • Ability_Points[(Player number of (Owner of (Triggering unit)))] Greater than or equal to 1
    • Actions
      • Set Ability_Cast = (Ability being cast)
      • For each (Integer A) from 1 to 12, do (Actions)
        • Loop - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • Ability_Cast Equal to Ability_Learn[(Integer A)]
            • Then - Actions
              • Unit - Increase level of Ability_Cast for (Triggering unit)
              • Unit - Increase level of Ability_Use[(Integer A)] for (Triggering unit)
            • Else - Actions

There you go, no custom script needed. =)
 

Lightstalker

New Member
Reaction score
55
Trigger:
  • Allocating Skills
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • And - All (Conditions) are true
        • Conditions
          • ((Triggering unit) is A Hero) Equal to True
          • Ability_Points[(Player number of (Owner of (Triggering unit)))] Greater than or equal to 1
    • Actions
      • Set Ability_Cast = (Ability being cast)
      • For each (Integer A) from 1 to 12, do (Actions)
        • Loop - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • Ability_Cast Equal to Ability_Learn[(Integer A)]
            • Then - Actions
              • Unit - Increase level of Ability_Cast for (Triggering unit)
              • Unit - Increase level of Ability_Use[(Integer A)] for (Triggering unit)
            • Else - Actions

There you go, no custom script needed. =)

Thanks but I want to use custom script to exit the loop when the ability cast is found so that it doesn't keep on going because its too inefficient. Right now, it just has to check 12 times, but soon will have to check 50 times, and if the ability is found right at the begining then there's no point in it to keep on checking for it. Know what I'm saying?
 

Wilfred1100

New Member
Reaction score
0
Plllllllllllease help me im about to commit suicide Cuz of this bastard :mad:

Please - how do i get those green question marks or loop things?
At the point where it branches off.

If i had the action

If condition then do action else do action

They all start as red, so i cant press ok
I need to make it into

If (All Conditions are True) then do (Actions) else do (Actions)

How do i turn it from:
If condition then do action else do action
to
If (All Conditions are True) then do (Actions) else do (Actions)
 

Admit

New Member
Reaction score
25
Please - how do i get those green question
How do i turn it from:
If condition then do action else do action
to
If (All Conditions are True) then do (Actions) else do (Actions)

Just press the down arrow?
Select the trigger below it (there are two "if then else" triggers.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1

      The Helper Discord

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top