Jass Help

N

NetherHawk

New Member
Reaction score
26
Ok i know its old - fashioned and out of date to use kattana handle vars but i'm having some problems. My trigger does not fire all the time even if i set the random integer thingy to be 100%.

JASS:
function AutoFire_Jass_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'B00X' // autofire buff
endfunction

function AutoFire_Attacker takes nothing returns boolean
    local trigger tr = GetTriggeringTrigger()
    local unit u = GetHandleUnit(tr,"attacker")
    return GetAttacker() == u // to check if the attacking unit is still the same? could this be the problem?
endfunction

function AutoFireGroup_Conditions takes nothing returns boolean
    local trigger tr = GetTriggeringTrigger()
    local unit u = GetHandleUnit(tr,"attacker")
    local boolean b1 = IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(u)) == true
    local boolean b2 = IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) == false
    local boolean b3 = IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) == false
    local boolean b4 = IsUnitType(GetFilterUnit(), UNIT_TYPE_DEAD) == false
    return b1 and b2 and b3 and b4
endfunction

function AutoFire_Attack takes nothing returns nothing
    local trigger tr = GetTriggeringTrigger()
    local unit u = GetHandleUnit(tr,"attacker")
    local unit ux = GetHandleUnit(tr,"target")
    local location ul = GetUnitLoc(u)    
    local unit d = CreateUnit( GetOwningPlayer(u), 'n005',GetLocationX(ul),GetLocationY(ul), bj_UNIT_FACING ) // create dummy to attack
    local group g = CreateGroup()
    
    
    call SetUnitPathing(d,false)    
    
    call SetHandleHandle(tr,"attacker",u)
    
    call SetUnitAbilityLevel(d,'A01C',GetUnitAbilityLevel(u,'A01D') )
    set g = GetUnitsInRangeOfLocMatching(600,ul, Condition(function AutoFireGroup_Conditions))  
    call GetRandomSubGroup(1, g)  // i doubt its cuz of no units in the group cuz the map i use has plenty of units surrounding the hero
    call UnitApplyTimedLifeBJ( 1.00, 'BTLF', d)
    call SetUnitAnimation( u, "spell" )             
    call IssueTargetOrderBJ( d, "attackonce", ux)
    call UnitAddAbility(d, 'Aloc')
    
    call DisableTrigger(tr)
    call FlushHandleLocals(tr)
    call DestroyTrigger(tr) 
    call GroupClear(g)
    call DestroyGroup(g)
    set u = null
    set ux = null
    call RemoveLocation(ul)     
    set d = null  
endfunction



function AutoFire_Jass_Actions takes nothing returns nothing
    local unit u = GetAttacker()
    local unit ux = GetAttackedUnitBJ()       
    local trigger tr = CreateTrigger()
    
    if  GetRandomInt(1, 100) <= 100 then // the 100% thing
    //if  GetRandomInt(1, 100) <= (20 + (5*(GetUnitAbilityLevel(u,'A01D')))) then //A01D spell id
            call SetHandleHandle(tr,"attacker",u)    
            call TriggerRegisterUnitEvent(tr,ux,EVENT_UNIT_DAMAGED) // to get when unit is damaged instead of the abuse attack thing 
            call TriggerAddCondition(tr, Condition( function AutoFire_Attacker ) )
            call TriggerAddAction(tr , function AutoFire_Attack)
                                                                              
            call SetHandleHandle(tr,"attacker",u)
            call SetHandleHandle(tr,"target",ux)
        else
    endif     
endfunction

//===========================================================================
function InitTrig_Auto_Fire_Jass takes nothing returns nothing
    set gg_trg_Auto_Fire_Jass = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Auto_Fire_Jass, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_Auto_Fire_Jass, Condition( function AutoFire_Jass_Conditions ) )
    call TriggerAddAction( gg_trg_Auto_Fire_Jass, function AutoFire_Jass_Actions )
endfunction



several stuff i have done to try to find out the problem is, removing the locust thing, removing the AutoFireGroup_Conditions .
 
cr4xzZz

cr4xzZz

Also known as azwraith_ftL.
Reaction score
51
You are back? Dude I missed you (you still remember me, don't you? xD)...

I suggest you forget all these handle variables and learn vJASS - you can find everything in the Tutorial Repository. It's an extension of JASS so you may find a lot of useful things when using it.
http://www.thehelper.net/forums/showthread.php?t=80241&highlight=vJASS I know it's GUI to JASS but it has some common syntax used in vJASS (nothing special, just cleaner code).
http://www.thehelper.net/forums/showthread.php?t=79426 Basic usage of structs in vJASS.
 
N

NetherHawk

New Member
Reaction score
26
off topic: ahaha yeah .. x.x i lent someone my cd and then reformatted my com so i dint have wc3 with me for a vry long time >.<!

i know who to use structs but in the end u still use handle vars/cs-system/abc to attach? so whats the diff? this part i dont understand. what are methods for? =x

on topic: asides from my method, what is the problem with the coding?
 
chobibo

chobibo

Level 1 Crypt Lord
Reaction score
48
Welcome back dude, I hope you enjoy your stay lol.

many leaks. example:
JASS:
function AutoFireGroup_Conditions takes nothing returns boolean
    local trigger tr = GetTriggeringTrigger()
    local unit u = GetHandleUnit(tr,&quot;attacker&quot;)
    local boolean b1 = IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(u)) == true
    local boolean b2 = IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) == false
    local boolean b3 = IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) == false
    local boolean b4 = IsUnitType(GetFilterUnit(), UNIT_TYPE_DEAD) == false
    return b1 and b2 and b3 and b4
endfunction


null local variables after using them, warcraft's handle Id recycler won't recycle the handle Id's if a local pointing to a handle is not released.
JASS:
function AutoFireGroup_Conditions takes nothing returns boolean
    local trigger tr = GetTriggeringTrigger()
    local unit u = GetHandleUnit(tr,&quot;attacker&quot;)
    local boolean b1 = IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(u)) == true
    local boolean b2 = IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) == false
    local boolean b3 = IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) == false
    local boolean b4 = IsUnitType(GetFilterUnit(), UNIT_TYPE_DEAD) == false
    set tr=null
    set u=null
    return b1 and b2 and b3 and b4
endfunction


some BJ's are causing execution slowdown, some not all:
JASS:
GetAttackedUnitBJ()

from the Event "A unit is attacked" so:
JASS:
GetTriggerUnit()
 
Viikuna

Viikuna

No Marlo no game.
Reaction score
265
Handle Vars are outdated these days because they say that I2H is dangerous and can cause some weird bugs.

Structs are integers so you can safely use Handle Vars with structs.

just use SetHandleInt and GetHandleInt.

They also say that destroying triggers is dangerous, so you should maybe try to make that spell without dynamic triggers.
 
darkbeer

darkbeer

Beer is Good!
Reaction score
84
just a hint you can easily use a loop to avoid making 4 booleans:

JASS:
function AutoFireGroup_Conditions takes nothing returns boolean
    local trigger tr = GetTriggeringTrigger()
    local unit u = GetHandleUnit(tr,&quot;attacker&quot;)
    loop
        exitwhen IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(u)) == false
        exitwhen IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) == true
        exitwhen IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) == true
        exitwhen IsUnitType(GetFilterUnit(), UNIT_TYPE_DEAD) == true
        set tr=null
         set u=null
        return true
    endloop
    set tr=null
    set u=null
    return false
endfunction
 
E

emjlr3

Change can be a good thing
Reaction score
395
wtf do you need a loop for...

JASS:
return IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(u)) and not IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) and not IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) and GetWidgetLife(GetFilterUnit())&gt;.405


JASS:
GetSpellAbilityId() == &#039;B00X&#039; // autofire buff


will never return true because its firing off the attack event not spell cast/effect/etc. event

you want to check if:

JASS:
GetUnitAbilityLevel(GetAttacker(),&#039;XXXX&#039;)&gt;0


the attacker has the auto fire ability
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/
  • The Helper The Helper:
    New recipe is Cheeseburger Pie! https://www.thehelper.net/threads/recipe-cheeseburger-pie.194191/

      The Helper Discord

      Members online

      Online now:
      155 (members: 2, guests: 153)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top