My loop only runs once :S

okay, I've tried to rewrite it using gwypaas method, BUT i've got a similar problem, it won't run my PushEmBack function, check it out and plx help me out too...
btw I think I fixed most of the leaks

JASS:
globals
    trigger gg_trg_Crush
    group g
endglobals

function Trig_Crush_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A069' ) ) then
        return false
    endif
    return true
endfunction

function PushEmBack takes unit u, location targetLoc returns nothing
local real ufacing
local real distance
local location newLoc
    loop
        set distance = DistanceBetweenPoints(GetUnitLoc(u), GetSpellTargetLoc())
        exitwhen (distance>200.00)
        set ufacing = GetUnitFacing(u)
        if (ufacing>180.00) then
        set ufacing = ufacing-180.00
        else
        set ufacing = ufacing+180.00
        endif 
        set newLoc = PolarProjectionBJ(GetUnitLoc(u), 30.00, ufacing)
        call SetUnitPositionLoc(u, newLoc)
        call AddSpecialEffectTargetUnitBJ( "origin", u, "Abilities\\Spells\\Human\\FlakCannons\\FlakTarget.mdl" )           
        call SetUnitPathing(u, false)
        call SetUnitFacing(u, AngleBetweenPoints(GetSpellTargetLoc(), GetUnitLoc(u)))
        call UnitDamageTargetBJ( GetTriggerUnit(), u, 20.00, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_ENHANCED )
        call TriggerSleepAction(0.01)
    endloop
call SetUnitPathing(u, true)
set u = null
call RemoveLocation(newLoc)
call RemoveLocation(targetLoc)
set newLoc = null
set targetLoc = null
endfunction

function Trig_Crush_Actions takes nothing returns nothing
local real spTaX = GetLocationX(GetSpellTargetLoc())
local real spTaY = GetLocationY(GetSpellTargetLoc())
local unit u
local location targetLoc
call AddSpecialEffect("Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl", spTaX, spTaY )
set g = GetUnitsInRangeOfLocAll(200.00, GetSpellTargetLoc())
set u = FirstOfGroup(g)
loop
    exitwhen u == null
    call PushEmBack(u, targetLoc)
    call GroupRemoveUnit(g, u)
    set u = FirstOfGroup(g)
endloop
call DestroyGroup(g)
set g = null
set u = null
call RemoveLocation(targetLoc)
set targetLoc = null
endfunction

//===========================================================================
function InitTrig_Crush takes nothing returns nothing
    set gg_trg_Crush = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Crush, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Crush, Condition( function Trig_Crush_Conditions ) )
    call TriggerAddAction( gg_trg_Crush, function Trig_Crush_Actions )
endfunction
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    News portal has been retired. Main page of site goes to Headline News forum now
  • The Helper The Helper:
    I am working on getting access to the old news portal under a different URL for those that would rather use that for news before we get a different news view.
  • Ghan Ghan:
    Easily done
    +1
  • The Helper The Helper:
    https://www.thehelper.net/pages/news/ is a link to the old news portal - i will integrate it into the interface somewhere when i figure it out
  • Ghan Ghan:
    Need to try something
  • Ghan Ghan:
    Hopefully this won't cause problems.
  • Ghan Ghan:
    Hmm
  • Ghan Ghan:
    I have converted the Headline News forum to an Article type forum. It will now show the top 20 threads with more detail of each thread.
  • Ghan Ghan:
    See how we like that.
  • The Helper The Helper:
    I do not see a way to go past the 1st page of posts on the forum though
  • The Helper The Helper:
    It is OK though for the main page to open up on the forum in the view it was before. As long as the portal has its own URL so it can be viewed that way I do want to try it as a regular forum view for a while
  • Ghan Ghan:
    Yeah I'm not sure what the deal is with the pagination.
  • Ghan Ghan:
    It SHOULD be there so I think it might just be an artifact of having an older style.
  • Ghan Ghan:
    I switched it to a "Standard" article forum. This will show the thread list like normal, but the threads themselves will have the first post set up above the rest of the "comments"
  • The Helper The Helper:
    I don't really get that article forum but I think it is because I have never really seen it used on a multi post thread
  • Ghan Ghan:
    RpNation makes more use of it right now as an example: https://www.rpnation.com/news/
  • The Helper The Helper:
  • The Helper The Helper:
    What do you think Tom?
  • tom_mai78101 tom_mai78101:
    I will have to get used to this.
  • tom_mai78101 tom_mai78101:
    The latest news feed looks good
  • The Helper The Helper:
    I would like to see it again like Ghan had it the first time with pagination though - without the pagination that view will not work but with pagination it just might...
  • The Helper The Helper:
    This drink recipe I have had more than a few times back in the day! Mind Eraser https://www.thehelper.net/threads/cocktail-mind-eraser.194720/

      The Helper Discord

      Staff online

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top