Spellpack Nuke, Flame Storm, Blink Back, Fade Run

Well, care to explain please? I can't figure it out myself.
 
when the caster begins some animation, create dummy units that you will use and have them display the same animation

when needed, move them to the correct spot, display them and freeze em
 
Each of your spells need descriptions before this can be approved.
You need at least one screenshot for this to be approved - For the spells index.
Would be appreciated if that image was 256x256 pxls. :)

Nuke:
I suggest making DMG a configurable function instead of a global which is multiplied by the level.

JASS:
set SOUND = gg_snd_nuclear

gg_snd_nuclear is buried deep within that code.
How about:
JASS:
//constants
private constant string SOUNDPATH = "Some\\Path"

// Init Function
set Sound = CreateSoundFilenameWithLabel(SOUNDPATH, ..., ..)

Notice how Sound, a non-constant global isn't in all-caps.
You can also get rid of that timer you create at init like this.

Quit destroying the group, and make it a global group, which is created at init, and never destroyed.
I don't see you destroying the timer you create dynamically.
Infact, you shouldn't destroy timers. How about replacing AncientData with TimerUtils?

Locations are so GUI. :p

DistanceBetweenPoints could be set to a variable, as you're using it twice.
Though you could remove it by not using locations.

You don't null 't' in NukeAct.

You don't destroy your struct.

JASS:
method DmgE ...

Why?

JASS:
call UnitDamagePoint (..)

Desyncs on Macs. Get rid of realistic. It's simpler to just make them 'return true' in the filter.

Configurable?

It'd also be better if the sound was 3D.​


Flame Storm
Same DMG stuff applies here as the previous spell.

JASS:
[4]
Configurable?

Configurable?

As with before, locations are too GUI for Jass. :p
Your code will be more efficient, and you'd get rid of most of those BJs. They're all crappy, location-based ones.

Your function names suck.


Set those to variables. You're calling them each 4 times.

JASS:
.
        set a.ticker = a.ticker + TT_PERIOD * 100
        if a.ticker == TIME * 100 then

Why the *100? o_O


Desyncs.

I thought I'd mention here that basically all of these points should be repeated about 50 times. Especially the BJs and locations. They're fugly.​

I didn't bother looking at the rest, as I bet all of these points will be repeated again.
Fix these up, and I'll look over it all again.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    News portal has been retired. Main page of site goes to Headline News forum now
  • The Helper The Helper:
    I am working on getting access to the old news portal under a different URL for those that would rather use that for news before we get a different news view.
  • Ghan Ghan:
    Easily done
    +1
  • The Helper The Helper:
    https://www.thehelper.net/pages/news/ is a link to the old news portal - i will integrate it into the interface somewhere when i figure it out
  • Ghan Ghan:
    Need to try something
  • Ghan Ghan:
    Hopefully this won't cause problems.
  • Ghan Ghan:
    Hmm
  • Ghan Ghan:
    I have converted the Headline News forum to an Article type forum. It will now show the top 20 threads with more detail of each thread.
  • Ghan Ghan:
    See how we like that.
  • The Helper The Helper:
    I do not see a way to go past the 1st page of posts on the forum though
  • The Helper The Helper:
    It is OK though for the main page to open up on the forum in the view it was before. As long as the portal has its own URL so it can be viewed that way I do want to try it as a regular forum view for a while
  • Ghan Ghan:
    Yeah I'm not sure what the deal is with the pagination.
  • Ghan Ghan:
    It SHOULD be there so I think it might just be an artifact of having an older style.
  • Ghan Ghan:
    I switched it to a "Standard" article forum. This will show the thread list like normal, but the threads themselves will have the first post set up above the rest of the "comments"
  • The Helper The Helper:
    I don't really get that article forum but I think it is because I have never really seen it used on a multi post thread
  • Ghan Ghan:
    RpNation makes more use of it right now as an example: https://www.rpnation.com/news/
  • The Helper The Helper:
  • The Helper The Helper:
    What do you think Tom?
  • tom_mai78101 tom_mai78101:
    I will have to get used to this.
  • tom_mai78101 tom_mai78101:
    The latest news feed looks good
  • The Helper The Helper:
    I would like to see it again like Ghan had it the first time with pagination though - without the pagination that view will not work but with pagination it just might...
  • The Helper The Helper:
    This drink recipe I have had more than a few times back in the day! Mind Eraser https://www.thehelper.net/threads/cocktail-mind-eraser.194720/

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top