[Request] Toss spell targetting modification

Silencer

New Member
Reaction score
0
Hi guys.. i am not really good in writing JASS, ok i am really bad in it.
All i can to is modify numbers or set "false" in "true".

So i have here a code about tinys toss in dota.. all i want is that it can damages neutrals AND remove the damage if the unit is an allied AND make it possible to toss also items.

I dont know if that is much to change or not, i find the parts to change but dont even know what to write.

Well if someone of you could change that for me, i would be really happy. Here is the code:

JASS:
//TESH.scrollpos=0
//TESH.alwaysfold=0
function DistanceBetweenXY takes real x1,real y1,real x2,real y2 returns real
    return SquareRoot(((x1-x2)*(x1-x2))+((y1-y2)*(y1-y2)))
endfunction

function AngleBetweenXY takes real x1,real y1,real x2,real y2 returns real
    return Atan2(y2-y1,x2-x1)
endfunction

function GenericTrue takes nothing returns boolean
    return true
endfunction

function KillTrees takes nothing returns nothing
    call KillDestructable(GetEnumDestructable())
endfunction

function DestroyTrees takes real x,real y,real d returns nothing
    local rect r=Rect(x-d,y-d,x+d,y+d)
    call EnumDestructablesInRect(r,Condition(function GenericTrue),function KillTrees)
    call RemoveRect(r)
    set r=null
endfunction

function TossCheck takes nothing returns boolean
    return (IsUnitType(GetFilterUnit(),UNIT_TYPE_STRUCTURE) == false and GetUnitState(GetFilterUnit(), UNIT_STATE_LIFE) > 0)
endfunction

function TossPickUnit takes unit Source returns unit
    local unit TossUnit=null
    local group g=CreateGroup()
    call GroupEnumUnitsInRange(g,GetUnitX(Source),GetUnitY(Source),275,Condition(function TossCheck))
    call GroupRemoveUnit(g,Source)
    set TossUnit=GroupPickRandomUnit(g)
    call DestroyGroup(g)
    set udg_unit = TossUnit
    set TossUnit=null
    return udg_unit
endfunction

function DamageGroupToss takes nothing returns nothing
    if(IsUnitType(GetFilterUnit(),UNIT_TYPE_STRUCTURE) == true) then
        call UnitDamageTarget(udg_unit,GetEnumUnit(),udg_damage/3,true,false,ATTACK_TYPE_NORMAL,DAMAGE_TYPE_FIRE,WEAPON_TYPE_WHOKNOWS)
    else
        call UnitDamageTarget(udg_unit,GetEnumUnit(),udg_damage,true,false,ATTACK_TYPE_NORMAL,DAMAGE_TYPE_FIRE,WEAPON_TYPE_WHOKNOWS)
    endif
endfunction

function DamageCheck takes nothing returns boolean
    return ( GetUnitState(GetFilterUnit(), UNIT_STATE_LIFE) > 0 and IsPlayerEnemy(GetOwningPlayer(GetFilterUnit()),GetOwningPlayer(udg_unit))) 
endfunction

function TossDamage takes unit Source,real x,real y,real r,real d returns nothing
    local group g=CreateGroup()

    set udg_unit=Source
    set udg_damage=d
    call GroupEnumUnitsInRange(g,x,y,r,Condition(function DamageCheck))
    call ForGroup(g,function DamageGroupToss)
    call DestroyGroup(g)
endfunction

function TossMove takes nothing returns boolean
    local trigger t=GetTriggeringTrigger()
    local integer cache=GetHandleId(t)
    local integer Runtimes=GetTriggerEvalCount(t)
    local unit Source=LoadUnitHandle(udg_gHash,cache,StringHash("Source"))
    local unit TossUnit=LoadUnitHandle(udg_gHash,cache,StringHash("TossUnit"))
    local unit Target=LoadUnitHandle(udg_gHash,cache,StringHash("Target"))
    local real x0=LoadReal(udg_gHash,cache,StringHash("TargetX"))
    local real y0=LoadReal(udg_gHash,cache,StringHash("TargetY"))
    local real x1=GetUnitX(TossUnit)
    local real y1=GetUnitY(TossUnit)
    local real x2=GetUnitX(Target)
    local real y2=GetUnitY(Target)
    local real AngleToFly
    local real DistanceToFly
    local real DistanceThis
    local real Height
    local real NewX
    local real NewY

    if DistanceBetweenXY(x0,y0,x2,y2)>1000 then
        set x2=x0
        set y2=y0
    endif
    set AngleToFly=AngleBetweenXY(x1,y1,x2,y2)
    set DistanceToFly=DistanceBetweenXY(x1,y1,x2,y2)
    set DistanceThis=DistanceToFly/ IMaxBJ(51-Runtimes,1)
    set Height=(Runtimes-25)*(Runtimes-25)
    set NewX=x1+DistanceThis*Cos(AngleToFly)
    set NewY=y1+DistanceThis*Sin(AngleToFly)

    if Runtimes<51 then
        call SetUnitFlyHeight(TossUnit,775-Height,0)
        call SetUnitPosition(TossUnit,NewX,NewY)
    else
        call SetUnitFlyHeight(TossUnit,GetUnitDefaultFlyHeight(TossUnit),0)
        call PauseUnit(TossUnit,false)
        call SetUnitPathing(TossUnit,true)
        call SetUnitPosition(TossUnit,x2,y2)
        //Toss ends
    
        call DestroyEffect(AddSpecialEffect("Abilities\\Spells\\Orc\\WarStomp\\WarStompCaster.mdl",GetUnitX(TossUnit),GetUnitY(TossUnit)))
        if IsUnitAlly(TossUnit,GetOwningPlayer(Source))then
            call UnitDamageTarget(Source,TossUnit,0.2*75*GetUnitAbilityLevel(Source,'A009'),true,false,ATTACK_TYPE_NORMAL,DAMAGE_TYPE_FIRE,WEAPON_TYPE_WHOKNOWS)
        else
            call UnitDamageTarget(Source,TossUnit,0.2*75*GetUnitAbilityLevel(Source,'A009'),true,false,ATTACK_TYPE_NORMAL,DAMAGE_TYPE_FIRE,WEAPON_TYPE_WHOKNOWS)
        endif
        call DestroyTrees(x2,y2,300)
        call TossDamage(Source,x2,y2,300,75*GetUnitAbilityLevel(Source,'A009'))
        call FlushChildHashtable(udg_gHash,cache)
        call DestroyTrigger(t)
    endif

    set t=null
    set Source=null
    set TossUnit=null
    set Target=null
    return false
endfunction

function TossOnEffect takes nothing returns nothing
    local unit Source=GetTriggerUnit()
    local unit TossUnit=TossPickUnit(Source)
    local unit Target=GetSpellTargetUnit()
    local trigger t=CreateTrigger()
    local integer cache=GetHandleId(t)

    call PauseUnit(TossUnit,true)
    call SetUnitPathing(TossUnit,false)
    call UnitAddAbility(TossUnit,'Amrf')
    call UnitRemoveAbility(TossUnit,'Amrf')
//Toss starts

    call SaveUnitHandle(udg_gHash,cache,StringHash("Source"),Source)
    call SaveUnitHandle(udg_gHash,cache,StringHash("TossUnit"),TossUnit)
    call SaveUnitHandle(udg_gHash,cache,StringHash("Target"),Target)
    call SaveReal(udg_gHash,cache,StringHash("TargetX"),GetUnitX(Target))
    call SaveReal(udg_gHash,cache,StringHash("TargetY"),GetUnitY(Target))

    call TriggerRegisterTimerEvent(t,0.02,true)
    call TriggerAddCondition(t,Condition(function TossMove))

    set Source=null
    set TossUnit=null
    set Target=null
    set t=null
endfunction

function TossOnCast takes nothing returns nothing
    local unit Source=GetTriggerUnit()
    local unit TossUnit=TossPickUnit(Source)

    if TossUnit==null then
        call DisplayTextToPlayer(GetOwningPlayer(Source),0,0,"No Vaild Unit to Toss!")
        call PauseUnit(Source,true)
        call IssueImmediateOrder(Source,"stop")
        call PauseUnit(Source,false)
    endif
    
    set Source=null
    set TossUnit=null
endfunction

function TossConditions takes nothing returns boolean
    if GetSpellAbilityId()=='A009' then
        if GetTriggerEventId()==EVENT_PLAYER_UNIT_SPELL_CAST then
            call TossOnCast()
        else
            call TossOnEffect()
        endif
    endif
    
    return false
endfunction

//===========================================================================
function InitTrig_Toss_Old takes nothing returns nothing
    set gg_trg_Toss_Old = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ(gg_trg_Toss_Old, EVENT_PLAYER_UNIT_SPELL_CAST)
    call TriggerRegisterAnyUnitEventBJ(gg_trg_Toss_Old, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition( gg_trg_Toss_Old, Condition( function TossConditions))
endfunction
 

Summoned

New Member
Reaction score
51
JASS:
function DamageCheck takes nothing returns boolean
    return ( GetUnitState(GetFilterUnit(), UNIT_STATE_LIFE) > 0 and IsPlayerEnemy(GetOwningPlayer(GetFilterUnit()),GetOwningPlayer(udg_unit))) 
endfunction


Change to:

JASS:
function DamageCheck takes nothing returns boolean
    return ( GetUnitState(GetFilterUnit(), UNIT_STATE_LIFE) > 0 and not IsPlayerAlly(GetOwningPlayer(GetFilterUnit()),GetOwningPlayer(udg_unit))) 
endfunction


I don't think there's a way to toss items. They have x and y coordinates, but no flying height.
 

Silencer

New Member
Reaction score
0
Okay but now i cant toss allied players, thats not what i want. I want only that you can attack neutrals too with this spell. (Now its only "isplayerenemy")
 

Lyerae

I keep popping up on this site from time to time.
Reaction score
105
Wouldn't it be possible to just remove the last part, after the 0?

So: [ljass]return ( GetUnitState(GetFilterUnit(), UNIT_STATE_LIFE) > 0 and not IsPlayerAlly(GetOwningPlayer(GetFilterUnit()),GetOwningPlayer(udg_unit)))[/ljass]

Into: [ljass]return ( GetUnitState(GetFilterUnit(), UNIT_STATE_LIFE) > 0[/ljass]
 

Summoned

New Member
Reaction score
51
Okay but now i cant toss allied players, thats not what i want. I want only that you can attack neutrals too with this spell. (Now its only "isplayerenemy")
You probably changed the wrong function. Make sure it's DamageCheck (for when the target lands), not TossCheck (for selecting units to toss).
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Staff online

      • Ghan
        Administrator - Servers are fun

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top