code question

feistaghelm

feistaghelm

New Member
Reaction score
2
Trigger:
  • Testing Might 3
    • Events
      • Unit - A unit Dies
    • Conditions
      • (Quests[2] is enabled) Equal to True
    • Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Owner of (Killing unit)) Equal to Player 1 (Red)
          • (Owner of (Dying unit)) Equal to Neutral Hostile
        • Then - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • (Unit-type of (Triggering unit)) Equal to Skeleton Archer
              • (Owner of (Killing unit)) Equal to Player 1 (Red)
            • Then - Actions
              • Set SkeletonArcherKills = (SkeletonArcherKills + 1)
              • Quest - Change the description of Quests[2] to ((Kill 2 Skeleton Archers: + (String(SkeletonArcherKills))) + /2)
              • Quest - Display to (All players) the Quest Update message: ((Skeleton Archer: + (String(SkeletonArcherKills))) + /2)
            • Else - Actions
              • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • (Unit-type of (Triggering unit)) Equal to Satyr
                  • (Owner of (Killing unit)) Equal to Player 1 (Red)
                • Then - Actions
                  • Set SatyrKills = (SatyrKills + 1)
                  • Quest - Change the description of Quests[2] to ((Kill 2 Sayrs: + (String(SatyrKills))) + /2)
                  • Quest - Display to (All players) the Quest Update message: ((Satyr: + (String(SatyrKills))) + /2)
                • Else - Actions
                  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    • If - Conditions
                      • (Unit-type of (Triggering unit)) Equal to Satyr Trickster
                      • (Owner of (Killing unit)) Equal to Player 1 (Red)
                    • Then - Actions
                      • Set SatyrTricksterKills = (SatyrTricksterKills + 1)
                      • Quest - Change the description of Quests[2] to ((Kill 1 Satyr Trickster: + (String(SatyrTricksterKills))) + /1)
                      • Quest - Display to (All players) the Quest Update message: ((Satyr Trickster: + (String(SatyrTricksterKills))) + /1)
                    • Else - Actions
                      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                        • If - Conditions
                          • (Unit-type of (Triggering unit)) Equal to Lesser Voidwalker
                          • (Owner of (Killing unit)) Equal to Player 1 (Red)
                        • Then - Actions
                          • Set LesserVoidwalkerKills = (LesserVoidwalkerKills + 1)
                          • Quest - Change the description of Quests[2] to ((Kill 2 Lesser Voidwalkers: + (String(LesserVoidwalkerKills))) + /2)
                          • Quest - Display to (All players) the Quest Update message: ((Lesser Voidwalker: + (String(LesserVoidwalkerKills))) + /2)
                        • Else - Actions
                          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            • If - Conditions
                              • (Unit-type of (Triggering unit)) Equal to Felguard
                              • (Owner of (Killing unit)) Equal to Player 1 (Red)
                            • Then - Actions
                              • Set FelguardKills = (FelguardKills + 1)
                              • Quest - Change the description of Quests[2] to ((Kill 2 Felguards: + (String(FelguardKills))) + /2)
                              • Quest - Display to (All players) the Quest Update message: ((Felguard: + (String(FelguardKills))) + /2)
                            • Else - Actions
                              • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                • If - Conditions
                                  • SkeletonArcherKills Equal to 2
                                  • SatyrKills Equal to 2
                                  • SatyrTricksterKills Equal to 1
                                  • LesserVoidwalkerKills Equal to 2
                                  • FelguardKills Equal to 2
                                • Then - Actions
                                  • Quest - Mark Quests[2] as Completed
                                  • Quest - Display to (All players) the Quest Update message: Looks like you hand...
                                  • Player - Add 250 to Player 1 (Red) Current gold
                                  • Hero - Add 150 experience to (Killing unit), Show level-up graphics
                                  • Trigger - Turn off (This trigger)
                                • Else - Actions
        • Else - Actions


I've tried 3 different variations of a multiple target kill quest and none of them complete. One of them is posted already in the forums and I updated it with the help I got, but sadly it still doesn't complete. It is under "quest help" by feistaghelm Do I ned to have the killing unit listed in each condition section? Same as the triggering unit belonging to neutral hostle? If I get this code to work i will be 80% done with my map. Sorry for the long post. +Rep to any help.


UPDATE!!!

I switched the code on this page to show the multi-target code that works. Only 1 problem.... it doesn't complete unless you kill 1 more creep of any kind on the map. So close, yet so far away. How do I get it to complete within the creeps required? There should be a way to make the last condition stand for itself instead as an else action like x-maul posted below, yet I am too noob to figure that part out. Again +Rep to anyone that can fix this.
 
X-maul

X-maul

AKA: Demtrod
Reaction score
201
Trigger:
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • SkeletonArcherKills Equal to 2
      • SatyrKills Equal to 2
      • SatyrTricksterKills Equal to 1
      • LesserVoidwalkerKills Equal to 2
      • FelguardKills Equal to 2
    • Then - Actions
      • Quest - Mark Quests[2] as Completed
      • Quest - Display to (All players) the Quest Update message: Looks like you hand...
      • Player - Add 250 to Player 1 (Red) Current gold
      • Unit Group - Pick every unit in (Units in (Playable map area) matching (((Triggering unit) is A Hero) Equal to True)) and do (Actions)
        • Loop - Actions
          • Hero - Add 150 experience to (Triggering unit), Show level-up graphics
    • Else - Actions
    • Else - Actions

This part needs to stand for itself, not in the else action.
Actually I would suggest you to put all the If/Then/Else for themself.
 
feistaghelm

feistaghelm

New Member
Reaction score
2
X-maul said:
Trigger:
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • SkeletonArcherKills Equal to 2
      • SatyrKills Equal to 2
      • SatyrTricksterKills Equal to 1
      • LesserVoidwalkerKills Equal to 2
      • FelguardKills Equal to 2
    • Then - Actions
      • Quest - Mark Quests[2] as Completed
      • Quest - Display to (All players) the Quest Update message: Looks like you hand...
      • Player - Add 250 to Player 1 (Red) Current gold
      • Unit Group - Pick every unit in (Units in (Playable map area) matching (((Triggering unit) is A Hero) Equal to True)) and do (Actions)
        • Loop - Actions
          • Hero - Add 150 experience to (Triggering unit), Show level-up graphics
    • Else - Actions
    • Else - Actions

This part needs to stand for itself, not in the else action.
Actually I would suggest you to put all the If/Then/Else for themself.
Click to expand...



I tried moving it to the brginning of the code and have the same issue. Also what so you mean by your last line? You kinda lost me there.

I wrote a nice little bit and before I could post it the f*ing site logged me out. So I will just say that I need to know where exactly to move/add/delete a line SPECIFICALLY because I have only been coding for about two weeks. And please explain all your move/add/delete to me like a nooblet because that is what I am.
 
H

Happy

Well-Known Member
Reaction score
71
if you move it to the beginning it checks whether the kills are equal to the number you want and THEN it sets the kills so it wont work....you have to let it be where it is in the trigger but move it outside the big if/then/else....
 
feistaghelm

feistaghelm

New Member
Reaction score
2
FINALLY!!!!!!
I was finally able to figure out the code placement. It took all day but here is the finished code in all it's glory. Thank you to: x-maul, happy, TomTTT, and Bankde for your suggestions. Anyone can use this code and if you have questions, I'll be happpy to answer them. But for now, goodnight.

Trigger:
  • Multiple Kill Quest
    • Events
      • Unit - A unit Dies
    • Conditions
      • (Quests[2] is enabled) Equal to True
    • Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Owner of (Killing unit)) Equal to Player 1 (Red)
          • (Owner of (Dying unit)) Equal to Neutral Hostile
        • Then - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • (Unit-type of (Dying unit)) Equal to Skeleton Archer
              • (Owner of (Killing unit)) Equal to Player 1 (Red)
            • Then - Actions
              • Set SkeletonArcherKills = (SkeletonArcherKills + 1)
              • Quest - Change the description of Quests[2] to ((Kill 2 Skeleton Archers: + (String(SkeletonArcherKills))) + /2)
              • Quest - Display to (All players) the Quest Update message: ((Skeleton Archer: + (String(SkeletonArcherKills))) + /2)
            • Else - Actions
              • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • (Unit-type of (Dying unit)) Equal to Satyr
                  • (Owner of (Killing unit)) Equal to Player 1 (Red)
                • Then - Actions
                  • Set SatyrKills = (SatyrKills + 1)
                  • Quest - Change the description of Quests[2] to ((Kill 2 Sayrs: + (String(SatyrKills))) + /2)
                  • Quest - Display to (All players) the Quest Update message: ((Satyr: + (String(SatyrKills))) + /2)
                • Else - Actions
                  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    • If - Conditions
                      • (Unit-type of (Dying unit)) Equal to Satyr Trickster
                      • (Owner of (Killing unit)) Equal to Player 1 (Red)
                    • Then - Actions
                      • Set SatyrTricksterKills = (SatyrTricksterKills + 1)
                      • Quest - Change the description of Quests[2] to ((Kill 1 Satyr Trickster: + (String(SatyrTricksterKills))) + /1)
                      • Quest - Display to (All players) the Quest Update message: ((Satyr Trickster: + (String(SatyrTricksterKills))) + /1)
                    • Else - Actions
                      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                        • If - Conditions
                          • (Unit-type of (Dying unit)) Equal to Lesser Voidwalker
                          • (Owner of (Killing unit)) Equal to Player 1 (Red)
                        • Then - Actions
                          • Set LesserVoidwalkerKills = (LesserVoidwalkerKills + 1)
                          • Quest - Change the description of Quests[2] to ((Kill 2 Lesser Voidwalkers: + (String(LesserVoidwalkerKills))) + /2)
                          • Quest - Display to (All players) the Quest Update message: ((Lesser Voidwalker: + (String(LesserVoidwalkerKills))) + /2)
                        • Else - Actions
                          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            • If - Conditions
                              • (Unit-type of (Dying unit)) Equal to Felguard
                              • (Owner of (Killing unit)) Equal to Player 1 (Red)
                            • Then - Actions
                              • Set FelguardKills = (FelguardKills + 1)
                              • Quest - Change the description of Quests[2] to ((Kill 2 Felguards: + (String(FelguardKills))) + /2)
                              • Quest - Display to (All players) the Quest Update message: ((Felguard: + (String(FelguardKills))) + /2)
                            • Else - Actions
        • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • SkeletonArcherKills Equal to 2
          • SatyrKills Equal to 2
          • SatyrTricksterKills Equal to 1
          • LesserVoidwalkerKills Equal to 2
          • FelguardKills Equal to 2
        • Then - Actions
          • Quest - Mark Quests[2] as Completed
          • Quest - Display to (All players) the Quest Update message: Looks like you hand...
          • Player - Add 250 to Player 1 (Red) Current gold
          • Hero - Add 200 experience to (Killing unit), Show level-up graphics
          • Trigger - Turn off (This trigger)
        • Else - Actions
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • WildTurkey WildTurkey:
    is there a stephen green in the house?
     +1
  • The Helper The Helper:
    What is up WildTurkey?
  • The Helper The Helper:
    Looks like Google fixed whatever mistake that made the recipes on the site go crazy and we are no longer trending towards a recipe site lol - I don't care though because it motivated me to spend alot of time on the site improving it and at least now the content people are looking at is not stupid and embarrassing like it was when I first got back into this like 5 years ago.
  • The Helper The Helper:
    Plus - I have a pretty bad ass recipe collection now! That section of the site is 10 thousand times better than it was before
  • The Helper The Helper:
    We now have a web designer at my job. A legit talented professional! I am going to get him to redesign the site theme. It is time.
  • Varine Varine:
    I got one more day of community service and then I'm free from this nonsense! I polished a cop car today for a funeral or something I guess
  • Varine Varine:
    They also were digging threw old shit at the sheriff's office and I tried to get them to give me the old electronic stuff, but they said no. They can't give it to people because they might use it to impersonate a cop or break into their network or some shit? idk but it was a shame to see them take a whole bunch of radios and shit to get shredded and landfilled
  • The Helper The Helper:
    whatever at least you are free
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?

      The Helper Discord

      Staff online

      Members online

      Online now:
      358 (members: 1, guests: 357)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top