(1) Is not a member of Dialog

[TriggerHappy]

I Don't understand why this is happening.

// 
    method ShowDialog takes nothing returns nothing
        local integer i = 0
        call DialogSetMessage(this.Dialog, this.name)
        loop
            exitwhen i > 11
            call DialogDisplay(Player(i), this.Dialog, true) 
            set i = i + 1
        endloop
    endmethod

    function ShowDialog takes Dialog d returns nothing
        call d.ShowDialog() // I get the error here ( (1) Is not a member of Dialog )
    endfunction

 

[XeNiM666]

    function ShowDialog takes Dialog d returns nothing
        call d.ShowDialog() // I get the error here
    endfunction

d.ShowDialog()
Must be a static method.

So it would be:

static method ShowDialog takes nothing returns dialog

 

[TriggerHappy]

Why would it return Dialog?

 

[XeNiM666]

i dont know.
well it must return something right?

 

[TriggerHappy]

It's not the create method, It just displays the dialog. I tried your way and i still got the error.

EDIT : Turns out you can't name a method the same as a function.

 

[TriggerHappy]

Struct .this Help!

hmm I'll post the code first

//
struct Dialog
    static method create takes string name returns Dialog
        local Dialog d   = Dialog.allocate()
        set d.Dialog     = DialogCreate()
        set d.name       = name
        
        call TriggerRegisterDialogEvent(bj_DIALOG, d.Dialog)
        
        return d
    endmethod
   
    method ShowAll takes nothing returns nothing
        local integer i = 0
        call BJDebugMsg("Dialog Name : " + .name)
        call DialogSetMessage(this.Dialog, this.name)
        loop
            exitwhen i > 11
            call DialogDisplay(Player(i), this.Dialog, true) 
            set i = i + 1
        endloop
    endmethod

endstruct
    function ShowDialog takes Dialog d returns nothing
        call d.ShowAll()
    endfunction

When i try to show the dialog it looks like it doesn't find the dialog :

    call CreateDialog(test, "Dialog Name")
    call ShowDialog(test)

It Displays no dialog name, Am i using the .this function correctly?

 

[chobibo]

syntax is structname.method not variable_name.method, that's for static methods. An example:

struct Dialogs
    dialog d
    
    static method show takes nothing returns nothing
        local integer i = 0
        call DialogSetMessage(this.Dialog, this.name)
        loop
            exitwhen i > 11
            call DialogDisplay(Player(i), this.Dialog, true) 
            set i = i + 1
        endloop
    endmethod
    
endstruct


private function This_is_it takes nothing returns nothing
    call Dialogs.show()
endfunction

 

[Renendaru]

Doesn't show dialog show dialogs, not strings?

 

[TriggerHappy]

call BJDebugMsg("Dialog Name : " + this.name)

Displays nothing , the dialog doesn't show either.

 

[Renendaru]

Might be that it wasn't initialized or something....

 

[chobibo]

try using this native

native DialogDisplay                takes player whichPlayer, dialog whichDialog, boolean flag returns nothing

 

[TriggerHappy]

It is , if i put

call BJDebugMsg("Dialog Name : " + this.name)

in the create method it displays the name.

@chobibo

......

//
    method ShowAll takes nothing returns nothing
        local integer i = 0
        call BJDebugMsg("Dialog Name : " + .name)
        call DialogSetMessage(this.Dialog, this.name)
        loop
            exitwhen i > 11
            call DialogDisplay(Player(i), this.Dialog, true) 
            set i = i + 1
        endloop
    endmethod

 

[TriggerHappy]

@chobibo

Thanks for trying but...... My way works.

 

[chobibo]

No, what I meant was you need to use the structname alongside the method your calling, I'm not introducing another way of doing your trigger.
I don't know if you named your struct "d" but if you named the struct "x" then a static method may be called by this syntax without needing to create an instance.

x.display()

Sorry for the vagueness of my first post.

 

[TriggerHappy]

I'm still a bit confused on what your trying to say. I have this

//
    function ShowDialog takes Dialog d returns nothing
        call d.ShowAll()
    endfunction

then i call it like this...

globals
    Dialog test = 0
endglobals

function Trig_Untitled_Trigger_001_Actions takes nothing returns nothing
    call CreateDialog(test, "Dialog Name")
    call ShowDialog(test)
endfunction

 

[chobibo]

This is what I mean, I'm talking about the struct's static method:

struct myStruct // structname
    integer myInt // member
    
    method myInstanceMethod takes nothing returns nothing      // Instance method
    endmethod
    
    
    static method myStaicMethod takes nothing returns nothing // static method
    endmethod
    
endstruct

function call_instance_method takes nothing returns nothing
    local myStruct d = myStruct.creat() // d is a struct of type myStruct,
                                        // you need it to call the instance
                                        // method myInstancemethod
                                        
    call d.myInstanceMethod()   // you call the instance method
endfunction

function call_static_method takes nothing returns nothing
    call myStruct.myStaticMethod()  // You don't need an instance of myStruct
                                    // to call it's static method
endfunction

 

[chobibo]

Oh, sorry I didn't see that you've already used it. You're not creating an instance of type Dialog in the function ShowDialog dude.

    function ShowDialog takes Dialog d returns nothing
        call d.ShowAll()
endfunction

You need to create an instance of struct Dialog

    function ShowDialog takes Dialog d returns nothing
        local Dialog d=Dialog.create()
        call d.ShowAll()
endfunction

 

[TriggerHappy]

You're not creating an instance of type Dialog in the function ShowDialog

lol sorry, That Means?

edit : Nevermind , you edited your post. but i already had created it.

//
    function CreateDialog takes Dialog d, string name returns nothing
        set d = d.create(name)
    endfunction

function Trig_Untitled_Trigger_001_Actions takes nothing returns nothing
    call CreateDialog(test, "Dialog Name")
    call ShowDialog(test)
endfunction

 

[chobibo]

That means you're not creating a dialog because you're not calling the allocator (create method) for Dialog, try using this:

function ShowDialog takes Dialog d returns nothing
        local Dialog d=Dialog.create()
        call d.ShowAll()
endfunction

 

[TriggerHappy]

but i already had created it.

//
    function CreateDialog takes Dialog d, string name returns nothing
        set d = d.create(name)
    endfunction

function Trig_Untitled_Trigger_001_Actions takes nothing returns nothing
    call CreateDialog(test, "Dialog Name")
    call ShowDialog(test)
endfunction

EDIT :

I'm going to need to remove the CreateDialog() Function.