A simpler inventory system?

M

MikeTheGuy

Guest
I'm sure I'm not the first one to think of this.

I was looking at the inventory systems and it seems that most require either finding substrings or making a ton of triggers. Mine, if the trigger works, would only need 1 trigger. Basically, my idea is to assign an item type (ie. sword, shield, helm, etc.) to each item class. So, for example: Artifact: Helmet, Purchasable: Armor, Permanent: Weapon, Charged: Shield (or weapon 2), Campaign: Leggings, Miscellaneous: Boots. And then Powerup (obviously remove the "use automatically when acquired" if you need to) for your general items, like quest items, potions, etc. Then, this trigger would be used to restrict the items:

PHP: 
inventory
    Events
        Unit - A unit Acquires an item
    Conditions
        Or - Any (Conditions) are true
            Conditions
                (Item-class of (Item being manipulated)) Equal to Artifact
                (Item-class of (Item being manipulated)) Equal to Purchasable
                (Item-class of (Item being manipulated)) Equal to Permanent
                (Item-class of (Item being manipulated)) Equal to Charged
                (Item-class of (Item being manipulated)) Equal to Campaign
                (Item-class of (Item being manipulated)) Equal to Miscellaneous
    Actions
        For each (Integer A) from 1 to 6, do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Item-class of (Item carried by (Hero manipulating item) in slot (Integer A))) Equal to (Item-class of (Item being manipulated))
                    Then - Actions
                        Hero - Drop the item from slot (Integer A) of (Hero manipulating item)
                        Game - Display to (All players) the text: Sorry, you can only...
                    Else - Actions
                        Do nothing

However, the trigger does not work. It will not allow you to pick up any item of those classes, even if there is no other item of that class in your inventory.
 
Ghan

Ghan

Administrator - Servers are fun
Staff member
Reaction score
889
It might be that since the trigger fires after the unit has already picked up the item, it counts that item in its evaluation, so it will always drop it, due to the fact that it is comparing the item to itself at some point. Add a comparison in the loop that the item in the Integer A slot is NOT the item being manipulated and see if that works.
 
M

MikeTheGuy

Guest
That's what I got to thinking as well. So I did what you said and added that comparison, but now the trigger doesn't display the message or drop the item when two items of the same class are picked up. This is the new trigger, all I added was that comparison.

PHP: 
inventory
    Events
        Unit - A unit Acquires an item
    Conditions
        Or - Any (Conditions) are true
            Conditions
                (Item-class of (Item being manipulated)) Equal to Artifact
                (Item-class of (Item being manipulated)) Equal to Purchasable
                (Item-class of (Item being manipulated)) Equal to Permanent
                (Item-class of (Item being manipulated)) Equal to Charged
                (Item-class of (Item being manipulated)) Equal to Campaign
                (Item-class of (Item being manipulated)) Equal to Miscellaneous
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Item-class of (Item carried by (Hero manipulating item) in slot (Integer A))) Equal to (Item-class of (Item being manipulated))
                (Item-type of (Item carried by (Hero manipulating item) in slot (Integer A))) Not equal to (Item-type of (Item being manipulated))
            Then - Actions
                Hero - Drop the item from slot (Integer A) of (Hero manipulating item)
                Game - Display to (All players) the text: Sorry, you can only...
            Else - Actions
                Do nothing

I think the problem might have something to do with that comparison. I think that the program is thinking that, yes, the item is of the same class but it is not the same item type as the one that was found, so therefore it is allowed to be picked up.
 
Ghan

Ghan

Administrator - Servers are fun
Staff member
Reaction score
889
Try a straight item comparison like this:

Code: 
(Item carried by <Unit> in slot (Integer A)) Not equal to (Item being manipulated)
 
M

MikeTheGuy

Guest
Hmm...I just tried that and it doesn't work either. This is really confusing. I've looked over the trigger many times but I can't tell why it's doing this.
 
M

MikeTheGuy

Guest
Alright, the way it's set up is there's a hero surrounded by items. The items are sorted so that they're all in pairs of the same class. For example, the two in front of the hero are Artifacts, etc. I did this so I could see if the system worked.
 

Attachments

  • MTG Inventory.w3x
    17.5 KB · Views: 66
Ghan

Ghan

Administrator - Servers are fun
Staff member
Reaction score
889
Oh, I could kick myself, but I won't. :p You don't have a loop. You need to add a For Each Integer A loop like this:

Code: 
For each (Integer A) from 1 to 6, do (Actions)
    Loop - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Item-class of (Item carried by (Hero manipulating item) in slot (Integer A))) Equal to (Item-class of (Item being manipulated))
                (Item carried by (Hero manipulating item) in slot (Integer A)) Not equal to (Item being manipulated)
            Then - Actions
                [COLOR="Red"]Hero - Drop (Item being manipulated) from (Hero manipulating item)[/COLOR]
                Game - Display to (All players) the text: Sorry, you can only...
            Else - Actions
                Do nothing

I also changed the thing in red because otherwise it would switch items.
 
M

MikeTheGuy

Guest
lol I JUST realized that when I looked at the trigger after I posted. And when I tested after adding the loop back in it worked, but yeah I noticed the bug where it switches items, I'll change that. Thanks for your help, it should work now. +rep
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1

      The Helper Discord

      Members online

      No members online now.
      Online now:
      125 (members: 1, guests: 124)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top