Ability trigger doesn't work

[Varedis]

What's wrong with my trigger?

Events
Unit - A unit Finishes casting an ability
Conditions
(Ability being cast) Equal to Coruption
Actions
Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Triggering unit)) and Retain color
Unit - Replace (Ownership-changed unit) with a Queen of Suffering using The new unit's default life and mana

My ability has to change a creep into a Queen of suffering and make it mine, but the problem is that when I use the trigger: Finishes casting an ability, it doesn't work, it just shows the art effects and nothing happens, but when I use: Begins casting an ability, the trigger works, but the art effects don't work, the creep just turn instantly into a queen of suffering.

that's my first problem, if u can't fix that one, then fix this one.


There's an ability in Warcraft 3 called Dark Conversion, the one used in purging Stratholme, what do you call the zombie the commoner is conversed into? Summoned unit or what? I used evrything, even Replaced unit but still the triggered didn't work.
trigger:

Events
Unit - A unit Finishes casting an ability
Conditions
(Ability being cast) Equal to Dark Conversion
Actions
Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Triggering unit)) and Retain color

same problem here: if I use finishes casting an ability, the queen of suffering (I replaced zombie with queen of suffering in Object Editor) isn't mine, the trigger doesn't work, but if I use begins casting an ability, the queen of suffering is mine, but the unit has no skills at all :S, even if I add new skills to the queen of suffering, it doesn't show them when I conversed a creep into her.

I tried to use the trigger:

Events
Unit - A unit Finishes casting an ability
Conditions
(Ability being cast) Equal to Corruption
Actions
Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Triggering unit)) and Retain color
Unit - Add Avatar to (Ownership-changed unit)

but it doesn't work, the creep get the ability avatar but when the creep turns into the queen of suffering, all abilities are gone, even avater, I don't know what to call the queen of suffering so I can't add the ability with a trigger to her.




Can anyone fix my problem

 

[Necrach]

Welcome to thehelper!

Try with "Starts the effect of an ability" and see if it works. If it don't, tell me!

EDIT: Also, you might want to change triggering unit to casting unit. And check some tutorial about leaks in GUI!

 

[hopy]

Events
Unit - A unit Finishes casting an ability
Conditions
(Ability being cast) Equal to Coruption
Actions
Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Triggering unit)) and Retain color
Unit - Replace (Ownership-changed unit) with a Queen of Suffering using The new unit's default life and mana

• Events
  • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Coruption
  • Actions
    • Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Triggering unit)) and Retain color
    • Unit - Replace (Target unit of ability being cast) with a Queen of Suffering using The new unit's default life and mana

This could work, Starts the effect of an ability is better and can't be abused.
And I believe that (Ownership-changed unit) only works if your event would've been:

• Events
  • Unit - A unit Changes owner

• Events
  • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Corruption
  • Actions
    • Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Triggering unit)) and Retain color
    • Unit - Add Avatar to (Target unit of ability being cast)

I think that should work for this one as well.

I'm sorry I don't have time to type my usual detailed 5 pages long stories. Let me know if it doesn't work.

 

[Varedis]

• Events
  • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Coruption
  • Actions
    • Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Triggering unit)) and Retain color
    • Unit - Replace (Target unit of ability being cast) with a Queen of Suffering using The new unit's default life and mana

This could work, Starts the effect of an ability is better and can't be abused.
And I believe that (Ownership-changed unit) only works if your event would've been:

• Events
  • Unit - A unit Changes owner

• Events
  • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Corruption
  • Actions
    • Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Triggering unit)) and Retain color
    • Unit - Add Avatar to (Target unit of ability being cast)

I think that should work for this one as well.

I'm sorry I don't have time to type my usual detailed 5 pages long stories. Let me know if it doesn't work.

It did work, only the ability adding part, because the trigger adds avatar to the target of unit of ability being cast, but my target gets converted into something else, that something else isn't Target unit of ability being cast, and if my target gets converted it loses all his skills, if you can tell me what to call my queen of suffering (it isn't target unit of ability being cast, nor replaced unit) I can add the ability to the queen of suffering.

EDIT: spell is based on dark conversion, you should check it.

 

[Varedis]

• Events
  • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Coruption
  • Actions
    • Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Triggering unit)) and Retain color
    • Unit - Replace (Target unit of ability being cast) with a Queen of Suffering using The new unit's default life and mana

This could work, Starts the effect of an ability is better and can't be abused.
And I believe that (Ownership-changed unit) only works if your event would've been:

• Events
  • Unit - A unit Changes owner

• Events
  • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Corruption
  • Actions
    • Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Triggering unit)) and Retain color
    • Unit - Add Avatar to (Target unit of ability being cast)

I think that should work for this one as well.

I'm sorry I don't have time to type my usual detailed 5 pages long stories. Let me know if it doesn't work.

I tested your first option, it did work, only problem is, I want the creep to turn into queen of suffering after the missle art hit, not before, can u fix that for me,

 

[hopy]

First of all, please watch the double post; some people will give rep- for that and stuff.

I want the creep to turn into queen of suffering after the missle art hit, not before, can u fix that for me,

I will admit it... I'm not sure. You could add a short wait based on the distance between caster and target. Just make sure to save (Target unit of ability being cast) in a variable because it will be overwriten by other single target abilities cast during the wait.
This however will make it non-MUI, or 1 per player MUI or however you'd call it if you add an array to it.

EDIT: spell is based on dark conversion, you should check it.

A bit of a confusing spell. I wonder if the replacing unit would still count as a (Target Unit of Ability being cast).

It did work, only the ability adding part, because the trigger adds avatar to the target of unit of ability being cast, but my target gets converted into something else, that something else isn't Target unit of ability being cast, and if my target gets converted it loses all his skills, if you can tell me what to call my queen of suffering (it isn't target unit of ability being cast, nor replaced unit) I can add the ability to the queen of suffering.

Well, you could try again using (Replaced unit) again, maybe it'll work this time. A different methode would be:

• Actions
  • Set Unit_Group = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Equal to Queen of Suffering) and ((Level of Avatar for (Matching unit)) Equal to 0)))
  • Unit Group - Pick every unit in Unit_Group and do (Actions)
    • Loop - Actions
      • Unit - Add Avatar to (Picked unit)
  • Custom script: call DestroyGroup (udg_Unit_Group)

Place that at the end of the trigger. It's supposed to look for all Queen of Suffering units that don't have the Avatar spell yet and give it to them.

 

[Varedis]

First of all, please watch the double post; some people will give rep- for that and stuff.


I will admit it... I'm not sure. You could add a short wait based on the distance between caster and target. Just make sure to save (Target unit of ability being cast) in a variable because it will be overwriten by other single target abilities cast during the wait.
This however will make it non-MUI, or 1 per player MUI or however you'd call it if you add an array to it.


A bit of a confusing spell. I wonder if the replacing unit would still count as a (Target Unit of Ability being cast).


Well, you could try again using (Replaced unit) again, maybe it'll work this time. A different methode would be:

• Actions
  • Set Unit_Group = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Equal to Queen of Suffering) and ((Level of Avatar for (Matching unit)) Equal to 0)))
  • Unit Group - Pick every unit in Unit_Group and do (Actions)
    • Loop - Actions
      • Unit - Add Avatar to (Picked unit)
  • Custom script: call DestroyGroup (udg_Unit_Group)

Place that at the end of the trigger. It's supposed to look for all Queen of Suffering units that don't have the Avatar spell yet and give it to them.

The ability problem is fixed, but I have to do something about the missile art, any suggestion for waiting triggers?

ability stats:
duration hero: 6
duration normal: 6
casting time: 3

Wait 6.00 seconds
trigger?

 

[hopy]

ability stats:
duration hero: 6
duration normal: 6
casting time: 3

Wait 6.00 seconds
trigger?

Well the duration is afther the missile art if I'm correct.
And since it's "A unit Starts the effect of an ability" the trigger activates afther the casting time. The wait should be something like: 0.5 seconds or something.
You could do something like: 0.2 + (0.1x((distance between target and hero)/50) but that would take like an hour of testing and would be completely useless. xD

The easyst thing to do here is to make the animation on target rather than a missile, or make the missile speed 9999 or something. That way you wont need a wait, it will run perfectly and no testing needed. The only difference would be that instead of having an animation flying to your target the animation would play above the target. (Dark Summoning animation would work perfectly for this).