Alliance Trigger

[The Arcot]

Hello again, Im back with yet another question.

I made an alliance trigger (like you type -ally red and become red's ally) but it doesn't work. Ill post it here, and if anyone could help me figure out why it's broken, then I will thank you greatly.

Spoiler

Set String Variables
    Events
        Map initialization
    Conditions
    Actions
        Set Teamstring[1] = Red
        Set Teamstring[2] = Blue
        Set Teamstring[3] = Teal
        Set Teamstring[4] = Purple
        Set Teamstring[5] = Yellow
        Set Teamstring[6] = Orange
        Set Teamstring[7] = Green
        Set Teamstring[8] = Pink
        Set Teamstring[9] = Gray
        Set Teamstring[10] = Light Blue
        Set Teamstring[11] = Dark Green

Spoiler

Ally
    Events
        Player - Player 1 (Red) types a chat message containing -ally  as A substring
        Player - Player 2 (Blue) types a chat message containing -ally  as A substring
        Player - Player 3 (Teal) types a chat message containing -ally  as A substring
        Player - Player 4 (Purple) types a chat message containing -ally  as A substring
        Player - Player 5 (Yellow) types a chat message containing -ally  as A substring
        Player - Player 6 (Orange) types a chat message containing -ally  as A substring
        Player - Player 7 (Green) types a chat message containing -ally  as A substring
        Player - Player 8 (Pink) types a chat message containing -ally  as A substring
        Player - Player 9 (Gray) types a chat message containing -ally  as A substring
        Player - Player 10 (Light Blue) types a chat message containing -ally  as A substring
        Player - Player 11 (Dark Green) types a chat message containing -ally  as A substring
    Conditions
        (Substring((Entered chat string), 1, 6)) Equal to -ally 
    Actions
        For each (Integer A) from 1 to 11, do (Actions)
            Loop - Actions
                If ((Substring(Teamstring[(Integer A)], 1, 5)) Equal to (Substring((Entered chat string), 7, 12))) then do (Player - For (Triggering player), turn Alliance (non-aggression) On toward (Player((Integer A)))) else do (Do nothing)
                If ((Substring(Teamstring[(Integer A)], 1, 5)) Equal to (Substring((Entered chat string), 7, 12))) then do (Player - For (Triggering player), turn Shared vision On toward (Player((Integer A)))) else do (Do nothing)

Spoiler

Unally
    Events
        Player - Player 1 (Red) types a chat message containing -unally  as A substring
        Player - Player 2 (Blue) types a chat message containing -unally  as A substring
        Player - Player 3 (Teal) types a chat message containing -unally  as A substring
        Player - Player 4 (Purple) types a chat message containing -unally  as A substring
        Player - Player 5 (Yellow) types a chat message containing -unally  as A substring
        Player - Player 6 (Orange) types a chat message containing -unally  as A substring
        Player - Player 7 (Green) types a chat message containing -unally  as A substring
        Player - Player 8 (Pink) types a chat message containing -unally  as A substring
        Player - Player 9 (Gray) types a chat message containing -unally  as A substring
        Player - Player 10 (Light Blue) types a chat message containing -unally  as A substring
        Player - Player 11 (Dark Green) types a chat message containing -unally  as A substring
    Conditions
        (Substring((Entered chat string), 1, 8)) Equal to -unally 
    Actions
        For each (Integer A) from 1 to 11, do (Actions)
            Loop - Actions
                If ((Substring(Teamstring[(Integer A)], 1, 5)) Equal to (Substring((Entered chat string), 7, 12))) then do (Player - For (Triggering player), turn Alliance (non-aggression) Off toward (Player((Integer A)))) else do (Do nothing)
                If ((Substring(Teamstring[(Integer A)], 1, 5)) Equal to (Substring((Entered chat string), 7, 12))) then do (Player - For (Triggering player), turn Shared vision Off toward (Player((Integer A)))) else do (Do nothing)

 

[Azylaminaz]

Tell me if I'm wrong, but WarCraft coding works the same as any other coding?

As in..
ABC
012

Right?
So... Your code would need to do:

If ((Substring(Teamstring[(Integer A)], 0, 4)) Equal to (Substring((Entered chat string), 6, 11))) then do (Player - For (Triggering player), turn Alliance (non-aggression) On toward (Player((Integer A)))) else do (Do nothing)

I always get confusing switching back and forth with JASS and VB. >.>

 

[The Arcot]

Ah, but I put 1,5 because don't I have to skip the dash?

 

[The Arcot]

Anyone else care to shed some light on the situation?

 

[C0mput3r]

Not to spoil anything, but if this (WarCraft) was like StarCraft, wouldn't you be able to change your Alliance in-game without triggers? The button beside Log on the screen's top left?

Anyway, can you give some info on what works and what doesn't or does it just not work entirely?

Slightly Off Topic.. Well completly off topic?

Spoiler

PS: Going to sleep now, usually only on forum on weekdays, however its the Winter Break!! no school!! So i have plenty of time tommorow

 

[The Arcot]

It just doesn't do anything.

 

[The Arcot]

I still need help, if theres anyone who can offer it

 

[Azylaminaz]

Ah, but I put 1,5 because don't I have to skip the dash?

        (Substring((Entered chat string), 1, 6)) Equal to -ally

At the end of the string "-ally " there is a space.
Blah, GUI stinks, makes me solution invalid. In JASS, I would be right though.

Perhaps you should try to fix your variables. I don't get why you would do substrings on constants.

Spoiler

        Set Teamstring[1] = Red
        Set Teamstring[2] = Blue
        Set Teamstring[3] = Teal
        Set Teamstring[4] = Purple
        Set Teamstring[5] = Yellow
        Set Teamstring[6] = Orange
        Set Teamstring[7] = Green
        Set Teamstring[8] = Pink
        Set Teamstring[9] = Gray
        Set Teamstring[10] = Light Blue
        Set Teamstring[11] = Dark Green

Change to:

Spoiler

        Set Teamstring[1] = Red
        Set Teamstring[2] = Blu
        Set Teamstring[3] = Tea
        Set Teamstring[4] = Pur
        Set Teamstring[5] = Yel
        Set Teamstring[6] = Ora
        Set Teamstring[7] = Gre
        Set Teamstring[8] = Pin
        Set Teamstring[9] = Gra
        Set Teamstring[10] = Lig
        Set Teamstring[11] = Dar

Another solution would be to use player numbers.
Basic setup:

Spoiler

Ally
    Events
        Player - Player 1 (Red) types a chat message containing -ally as A substring
    Conditions
    Actions
        Player - Make (Triggering player) treat (Player((Integer((Substring((Entered chat string), 7, 8)))))) as an Ally with shared vision

 

[The Arcot]

It still doesnt seem to be working, but maybe I missed something.

If there is anyone who actually has a working Alliance trigger that they know for sure works, would you mind sharing it?

 

[NationCreati]

Ya, sure. It's VERY simple; but hey, it works.

Alli
    Events
        Player - Player 1 (Red) types a chat message containing -Alli as A substring
        Player - Player 2 (Blue) types a chat message containing -Alli as A substring
        Player - Player 3 (Teal) types a chat message containing -Alli as A substring
        Player - Player 4 (Purple) types a chat message containing -Alli as A substring
        Player - Player 5 (Yellow) types a chat message containing -Alli as A substring
        Player - Player 6 (Orange) types a chat message containing -Alli as A substring
        Player - Player 7 (Green) types a chat message containing -Alli as A substring
        Player - Player 8 (Pink) types a chat message containing -Alli as A substring
        Player - Player 9 (Gray) types a chat message containing -Alli as A substring
        Player - Player 10 (Light Blue) types a chat message containing -Alli as A substring
        Player - Player 11 (Dark Green) types a chat message containing -Alli as A substring
        Player - Player 12 (Brown) types a chat message containing -Alli as A substring
    Conditions
        (Substring((Entered chat string), 1, 5)) Equal to -alli
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to red
            Then - Actions
                Player - Make (Triggering player) treat Player 1 (Red) as an Neutral
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to blue
            Then - Actions
                Player - Make (Triggering player) treat Player 2 (Blue) as an Neutral
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to teal
            Then - Actions
                Player - Make (Triggering player) treat Player 3 (Teal) as an Neutral
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to purple
            Then - Actions
                Player - Make (Triggering player) treat Player 4 (Purple) as an Neutral
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to yellow
            Then - Actions
                Player - Make (Triggering player) treat Player 5 (Yellow) as an Neutral
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to orange
            Then - Actions
                Player - Make (Triggering player) treat Player 6 (Orange) as an Neutral
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to green
            Then - Actions
                Player - Make (Triggering player) treat Player 7 (Green) as an Neutral
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to pink
            Then - Actions
                Player - Make (Triggering player) treat Player 8 (Pink) as an Neutral
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to gray
            Then - Actions
                Player - Make (Triggering player) treat Player 9 (Gray) as an Neutral
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to grey
            Then - Actions
                Player - Make (Triggering player) treat Player 9 (Gray) as an Neutral
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to light blue
            Then - Actions
                Player - Make (Triggering player) treat Player 10 (Light Blue) as an Neutral
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to Dark Green
            Then - Actions
                Player - Make (Triggering player) treat Player 11 (Dark Green) as an Neutral
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to Brown
            Then - Actions
                Player - Make (Triggering player) treat Player 12 (Brown) as an Neutral
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Substring((Entered chat string), 7, 20)) Equal to all
            Then - Actions
                Player Group - Pick every player in (All players) and do (Player - Make (Triggering player) treat (Picked player) as an Neutral)
            Else - Actions

NOTE: this trigger is for making people neutral; but hopefully you can modify it to do what you want.