Anti-leaking problem

[Skippy]

Hi there,
I had a simple trigger:

• Normal
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Player Group - Pick every player in (All players) and do (Actions)
      • Loop - Actions
        • Player - Add 1 to (Picked player) Current gold

But this trigger causes memory leaks. So I changed it into:

• Normal
  • Events
    • Time - Every 1.00 seconds of game time
  • Conditions
  • Actions
    • Set Temp_Player_Group = (All players)
    • Player Group - Pick every player in Temp_Player_Group and do (Actions)
      • Loop - Actions
        • Player - Add 1 to (Picked player) Current gold
    • Custom script: call DestroyForce( udg_Temp_Player_Group)

and think it is ok now. However, it works only once, not periodicaly every 1 second. WHY????

 

[Silver]

You destroyed "All Players" after the first go, which you should never do.

 

[Skippy]

How to fix it?

 

[Lord Regno]

Remove the last trigger maby? call destroy delete that.

 

[trees123]

All players doesn't leak, your first trigger was okay.

 

[TheSpoon]

I don't know why that doesn't work,
Doesn't work on mine either.

Anyway heres a working alternative:

Add Gold
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        For each (Integer A) from 1 to 12, do (Actions)
            Loop - Actions
                Player - Add 1 to (Player((Integer A))) Current gold

Edit: Trees123 is right I think, which makes my trigger pointless : <

 

[Skippy]

That's the problem, I don't know how to determine what causes leaks and what doesn't.

 

[Avahor]

change Time - Every 1.00 seconds of game time
for Time - Every 1.00 seconds

and define amount of normal time to equal a 1 second game-time. that´s minor

 

[Lightstalker]

All players doesn't leak.

Read a tutorial on leaks: http://world-editor-tutorials.thehelper.net/cat_usersubmit.php?view=27242

 

[HydraRancher]

What DOESNT cause leaks but is thought to:

Present: This means they are already existent, therefore don't leak
(Playable Map Area) - Region
Player Group - Player # - Player Group
(All Players) - Player Group
---And so on-----

Definite Leaks:
Every type of "Point", position, center etc.
Every type of "Region" apart from the specified
Every type of "Player Group" apart from the specified
Every type of "Unit Group", count units in region <gen>, etc.
Every type of "String" These are un-fixable but are re-used

 

[Scary Nachos]

Try this tool, it helps a bit
http://www.thehelper.net/forums/showthread.php?t=85048

 

[Skippy]

Try this tool, it helps a bit
http://www.thehelper.net/forums/showthread.php?t=85048

Looks good, but doesn't work

 

[Skippy]

Is this correct?

• Unit - Move (Triggering unit) instantly to (Position of My_unit 001 &lt;gen&gt;), facing my_angle

 

[Scary Nachos]

Looks good, but doesn't work

What doesnt work? Go here if it doesnt work, read what to do.
http://www.ascentive.com/support/new/support_dll.phtml?dllname=RICHTX32.OCX

 

[Tyman2007]

"Position of" leaks. Set a variable then remove it after use.

 

[Skippy]

And what about "composite" functions? Is (for example) this correct??

• Set Temp_Unit_Group = (Units within 400.00 of (Position of (Triggering unit)) matching (((Triggering unit) belongs to an enemy of (Owner of (Matching unit))) Equal to True))

 

[Moridin]

Well I think that leaks at:
Position of

You'll need to set it as a point variable and destroy it after.