Custom script trigger problem (Not sure if it should be in JASS forum)

I_RULE_YOU

New Member
Reaction score
34
I'm trying to have an aura that slowly draws in enemy heroes, and when I try to enable the trigger I get a popup window highlighting:

Code:
set x = GetLocationX(udg_Grudge5)

And telling me it expected a variable name. Heres the complete trigger below:

Code:
Grudge Aura
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        Custom script:   local real x
        Custom script:   local real y
        Set GrudgeGroup = (Units in ALLREGION matching (((Level of Grudge Aura  for (Matching unit)) Greater than 0) and (((Matching unit) is alive) Equal to True)))
        Unit Group - Pick every unit in GrudgeGroup and do (Actions)
            Loop - Actions
                Set Grudge1 = (Picked unit)
                Set Grudge2 = (Position of Grudge1)
                Set Grudge3 = (Units within 900.00 of Grudge2 matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) belongs to an enemy of (Owner of Grudge1)) Equal to True) and (((Matching unit) is A Hero) Equal
                Unit Group - Pick every unit in Grudge3 and do (Actions)
                    Loop - Actions
                        Set Grudge4 = (Position of (Picked unit))
                        Set Grudge5 = (Grudge4 offset by (10.00 x (Real((Level of Grudge Aura  for Grudge1)))) towards (Angle from Grudge4 to Grudge2) degrees)
                        Custom script:   set x = GetLocationX(udg_Grudge5)
                        Custom script:   set y = GetLocationY(udg_Grudge5)
                        Custom script:   call SetUnitX(GetEnumUnit(),x)
                        Custom script:   call SetUnitY(GetEnumUnit(),y)
                        Custom script:   call RemoveLocation(udg_Grudge4)
                        Custom script:   call RemoveLocation(udg_Grudge5)
                        Custom script:   call DestroyGroup(udg_Grudge4)
                        Custom script:   call RemoveLocation(udg_Grudge1)


Code:
Grudge AuraB
    Events
        Map initialization
    Conditions
    Actions
        Set ALLREGION = (Playable map area)

This is probably a simple problem, but it has dumbfounded me. What should I do?
 

MasterRofl

New Member
Reaction score
8
Go grab the NewGen Editor even if you don't use JASS; WE's checker sucks.

EDIT:

I think it's because when you use "Pick Every Unit in Group", another function is created. Therefore, "x" doesn't exist in the new function as a local.

E.g., something like this would be generated by the GUI:
JASS:
function Callback takes nothing returns nothing
    set udg_Grudge4 = GetUnitLoc(GetPickedUnit())
    set udg_Grudge5 = (Grudge4 offset by (10.00 x (Real((Level of Grudge Aura  for Grudge1)))) towards (Angle from Grudge4 to Grudge2) degrees) //too lazy to convert this
    set x = GetLocationX(udg_Grudge5)
    set y = GetLocationY(udg_Grudge5)
    call SetUnitX(GetEnumUnit(),x)
    call SetUnitY(GetEnumUnit(),y)
    call RemoveLocation(udg_Grudge4)
    call RemoveLocation(udg_Grudge5)
    call DestroyGroup(udg_Grudge4)
    call RemoveLocation(udg_Grudge1)
endfunction

function Actions takes nothing returns nothing
    ...
    ForGroupBJ(udg_Grudge3, function Callback)
    ...
endfunction

and "x" isn't declared in the new function. The same applies to "y".

What you can do is change
JASS:
set x = GetLocationX(udg_Grudge5)
set y = GetLocationY(udg_Grudge5)

to
JASS:
local real x = GetLocationX(udg_Grudge5)
local real y = GetLocationY(udg_Grudge5)

and remove
JASS:
Custom script:   local real x
Custom script:   local real y

at the top of your actions.
 

Tom_Kazansky

--- wraith it ! ---
Reaction score
157
Code:
Custom script:   local real x
Custom script:   local real y

These lines should be in the Loop - Actions of the Unit Group - Pick.

Code:
Grudge Aura
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        Set GrudgeGroup = (Units in ALLREGION matching (((Level of Grudge Aura  for (Matching unit)) Greater than 0) and (((Matching unit) is alive) Equal to True)))
        Unit Group - Pick every unit in GrudgeGroup and do (Actions)
            Loop - Actions
                Custom script:   local real x
                Custom script:   local real y
                Set Grudge1 = (Picked unit)
                Set Grudge2 = (Position of Grudge1)
                Set Grudge3 = (Units within 900.00 of Grudge2 matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) belongs to an enemy of (Owner of Grudge1)) Equal to True) and (((Matching unit) is A Hero) Equal
                Unit Group - Pick every unit in Grudge3 and do (Actions)
                    Loop - Actions
                        Set Grudge4 = (Position of (Picked unit))
                        Set Grudge5 = (Grudge4 offset by (10.00 x (Real((Level of Grudge Aura  for Grudge1)))) towards (Angle from Grudge4 to Grudge2) degrees)
                        Custom script:   set x = GetLocationX(udg_Grudge5)
                        Custom script:   set y = GetLocationY(udg_Grudge5)
                        Custom script:   call SetUnitX(GetEnumUnit(),x)
                        Custom script:   call SetUnitY(GetEnumUnit(),y)
                        Custom script:   call RemoveLocation(udg_Grudge4)
                        Custom script:   call RemoveLocation(udg_Grudge5)
                        Custom script:   call DestroyGroup(udg_Grudge4)
                        Custom script:   call RemoveLocation(udg_Grudge1)

The Loop - Actions of the Unit Group - Pick... is a different function, so you should declare the local vars in it.

EDIT: a bit slower than MasterRofl :p
 

MasterRofl

New Member
Reaction score
8
Oh and by the way, I don't believe there is a point in removing/destroying global locations/groups.
 

MasterRofl

New Member
Reaction score
8
Code:
Grudge Aura
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        Set GrudgeGroup = (Units in ALLREGION matching (((Level of Grudge Aura  for (Matching unit)) Greater than 0) and (((Matching unit) is alive) Equal to True)))
        Unit Group - Pick every unit in GrudgeGroup and do (Actions)
            Loop - Actions
                Set Grudge1 = (Picked unit)
                Set Grudge2 = (Position of Grudge1)
                Set Grudge3 = (Units within 900.00 of Grudge2 matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) belongs to an enemy of (Owner of Grudge1)) Equal to True) and (((Matching unit) is A Hero) Equal
                Unit Group - Pick every unit in Grudge3 and do (Actions)
                    Loop - Actions
                        Set Grudge4 = (Position of (Picked unit))
                        Set Grudge5 = (Grudge4 offset by (10.00 x (Real((Level of Grudge Aura  for Grudge1)))) towards (Angle from Grudge4 to Grudge2) degrees)
                        Custom script:   local real x = GetLocationX(udg_Grudge5)
                        Custom script:   local real y = GetLocationY(udg_Grudge5)
                        Custom script:   call SetUnitX(GetEnumUnit(),x)
                        Custom script:   call SetUnitY(GetEnumUnit(),y)
 

I_RULE_YOU

New Member
Reaction score
34
Did it just like that, and now it highlights:

Code:
local real x = GetLocationX(udg_Grudge5)

And it's telling me it expects a code statement.
 

Tom_Kazansky

--- wraith it ! ---
Reaction score
157
@MasterRofl, variables must be declared at the top (of the function - top of the Loop - Actions)

@I_RULE_YOU, oh sorry, I didn't notice there is another loop

Code:
Grudge Aura
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        Set GrudgeGroup = (Units in ALLREGION matching (((Level of Grudge Aura  for (Matching unit)) Greater than 0) and (((Matching unit) is alive) Equal to True)))
        Unit Group - Pick every unit in GrudgeGroup and do (Actions)
            Loop - Actions
                Set Grudge1 = (Picked unit)
                Set Grudge2 = (Position of Grudge1)
                Set Grudge3 = (Units within 900.00 of Grudge2 matching ((((Matching unit) is alive) Equal to True) and ((((Matching unit) is A structure) Equal to False) and ((((Matching unit) belongs to an enemy of (Owner of Grudge1)) Equal to True) and (((Matching unit) is A Hero) Equal
                Unit Group - Pick every unit in Grudge3 and do (Actions)
                    Loop - Actions
                        Custom script:   local real x  //they should be here
                        Custom script:   local real y
                        Set Grudge4 = (Position of (Picked unit))
                        Set Grudge5 = (Grudge4 offset by (10.00 x (Real((Level of Grudge Aura  for Grudge1)))) towards (Angle from Grudge4 to Grudge2) degrees)
                        Custom script:   set x = GetLocationX(udg_Grudge5)
                        Custom script:   set y = GetLocationY(udg_Grudge5)
                        Custom script:   call SetUnitX(GetEnumUnit(),x)
                        Custom script:   call SetUnitY(GetEnumUnit(),y)
                        Custom script:   call RemoveLocation(udg_Grudge4)
                        Custom script:   call RemoveLocation(udg_Grudge5)
                        Custom script:   call DestroyGroup(udg_Grudge4)
                        Custom script:   call RemoveLocation(udg_Grudge1)
 

Choppa

www.warcraft-gamers.po.gs
Reaction score
59
Oh and by the way, I don't believe there is a point in removing/destroying global locations/groups.

Lol, memory leaks aren't just in warcraft, they're everywhere and they do exist.

Make a .bat file and make it open it's self e.g

start thisfile.bat

That's like a memory leak because you're not closing it down again, so it will keep opening untill you run out of memory.
 

I_RULE_YOU

New Member
Reaction score
34
@Tom_Kazansky

Did that, stops me and highlights:

Code:
call RemoveLocation(udg_Grudge1)

Telling me "Invalid argument type (location)"

:(
 

I_RULE_YOU

New Member
Reaction score
34
So should I replace it with RemoveUnit or something, or just get rid of that line of code?

P.S: Should I try posting this in JASS help forum?
 

Choppa

www.warcraft-gamers.po.gs
Reaction score
59
Remove these

Custom script: call DestroyGroup(udg_Grudge4)
Custom script: call RemoveLocation(udg_Grudge1
 

Xorifelse

I'd love to elaborate about discussions...........
Reaction score
87
> Oh and by the way, I don't believe there is a point in removing/destroying global locations/groups.

Globals that extend a handle can create leaks, aka Locations.
There is no real point of destroying a global group yes, however a call GroupClear() can sometimes avoid bugs not to mention it clears the memory a bit for the time not using the global.

Global location types do leak, since its not the global reference you destroy but the object that the global is referring to.
Giving that global a new object to refer to, without destroying the old object means it has to find a new space in the memory for a new object.
Meaning the old reference to the object is gone, and the old object still exists.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Monovertex Monovertex:
    How are you all? :D
    +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top