Damage detection trigger, NOT working

sunshinex3

You can change this now in User CP.
I need to figure out why this isn't working, it fires off when not using the variables and just using a solid number so the second trigger works but when trying to use the bidedamagetaken variable it doesn't work, so im wondering if it is the custom script that is just below that's the problem?

I have this is in initialization its a custom script i was told would add the event unit takes damage to a trigger
Code:
library DamagedEventAdder initializer init
  private function init takes nothing returns nothing

    //change the name of the trigger to match the name of the trigger you want it added to
    //the format is: gg_trg_ + the name of the trigger with _ instead of spaces (see below)

    //if you change the name of the trigger in the trigger editor (or delete the trigger entirely) you will have to change it here
    //if you have multiple triggers that need this event you can duplicate the below line here for any number of triggers, just use the right name!

    call TriggerRegisterAnyUnitEventBJ(gg_trg_BideActivate, EVENT_PLAYER_UNIT_DAMAGED)
  endfunction
endlibrary
First trigger that i need "unit takes damage"
Trigger:
  • BideActivate
    • Events
    • Conditions
      • ((Damage Target) has buff Biding (NerubianKing)) Equal to True
    • Actions
      • Set VariableSet BideDamageTaken[(Player number of (Owner of (Damage Target)))] = (BideDamageTaken[(Player number of (Owner of (Damage Target)))] + (Damage taken))


this trigger works with a straight number but not with the variable arithmetic that i have here

Trigger:
  • BideDeactivate
    • Events
      • Unit - A unit Is issued an order with no target
    • Conditions
      • And - All (Conditions) are true
        • Conditions
          • ((Ordered unit) has buff Biding (NerubianKing)) Equal to True
          • (Issued order) Equal to (Order(unimmolation))
    • Actions
      • Set VariableSet TempPoint = (Position of (Ordered unit))
      • Unit - Cause (Ordered unit) to damage circular area after 0.00 seconds of radius 400.00 at TempPoint, dealing (BideDamageTaken[(Player number of (Owner of (Ordered unit)))] x (Real((Level of Bide (NerubianKing) for (Ordered unit))))) damage of attack type Spells and damage type Magic
      • Custom script: call RemoveLocation (udg_TempPoint)
[/code]
 
Last edited:

jonas

Ultra Cool Member
Add some debug messages.
Display the damage taken and the new value of BideDamageTaken in the first trigger.
Display the BideDamageTaken and the Level of Bide in the second trigger.

If your first trigger doesn't fire, remove the condition.

If even without the conditon it doesn't fire, it is the custom script. In that case please repost the custom script with
Code:
 code tags
 

jonas

Ultra Cool Member
Yep. The code itself looks good to me though.
Can you post a screenshot of the code in your trigger editor?

Maybe it is accidentally turned off, or in the comment section.

Another thing you can try is a new GUI trigger like this:

event : a unit enters the map
condition: type of triggering unit is (Nerubian King)
action: add event to trigger (BideActivate) : (triggering unit) takes damage
 

sunshinex3

You can change this now in User CP.
event : a unit enters the map
condition: type of triggering unit is (Nerubian King)
action: add event to trigger (BideActivate) : (triggering unit) takes damage
"can't find (triggering unit) takes damage"
i think that's why i had to add the custom script library.
 
Last edited:

jonas

Ultra Cool Member
Unfortunately I don't have Wc3 installed, but I was sure there is a GUI function to make that happen.
If there isn't, you can also try with this line of custom script which should do the same:



Another thing you can do is add the following to the custom script you already have:

Code:
if gg_trg_BideActivate == null then
    call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, "initialization called but trigger is null")
else
    call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, "initialization called and trigger exists")
endif
This should write some text at the beginning of the game. (Let me know if there are any syntax errors... sorry that I can't check that myself)
 

sunshinex3

You can change this now in User CP.
I am going to put this behind me i guess it's not possible with gui this is what i did it turned out fine.

Trigger:
  • BideActivate
    • Events
      • Unit - A unit Is attacked
    • Conditions
      • ((Attacked unit) has buff Biding (NerubianKing)) Equal to True
    • Actions
      • Set VariableSet BideDamageTaken[(Player number of (Owner of (Attacked unit)))] = (BideDamageTaken[(Player number of (Owner of (Attacked unit)))] + 1.00)


Number is increased based on how many attacks are made on the unit instead of damage taken, works well with tanks.


Trigger:
  • BideDeactivate
    • Events
      • Unit - A unit Is issued an order with no target
    • Conditions
      • And - All (Conditions) are true
        • Conditions
          • ((Ordered unit) has buff Biding (NerubianKing)) Equal to True
          • (Issued order) Equal to (Order(unimmolation))
    • Actions
      • Set VariableSet TempPoint = (Position of (Ordered unit))
      • Unit - Cause (Ordered unit) to damage circular area after 0.00 seconds of radius 400.00 at TempPoint, dealing (BideDamageTaken[(Player number of (Owner of (Ordered unit)))] x (Real((Level of Bide (NerubianKing) for (Ordered unit))))) damage of attack type Spells and damage type Magic
      • Set VariableSet BideDamageTaken[(Player number of (Owner of (Ordered unit)))] = 0.00
      • Custom script: call RemoveLocation (udg_TempPoint)



causes damage based on number of attacks made on caster and then resets the damage to 0.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • tom_mai78101 tom_mai78101:
    Make sure you keep checking out my news..
    +2
  • Jesus4Lyf Jesus4Lyf:
    Man, I made this account 15 years ago? Wild. :)
  • Ghan Ghan:
    Seeing J4L is definitely a blast from the past.
  • Jesus4Lyf Jesus4Lyf:
    Oh hey Ghan! Long time. :)
    +1
  • jonas jonas:
    J4L! What has happened in your life
  • Jesus4Lyf Jesus4Lyf:
    Hmm, how to summarize... Moved to the USA and got married. Became a professional software engineer and solution lead. Learning Godot for game dev. :)
  • jonas jonas:
    So you are pursuing game dev as a hobby? What industry is your dayjob in?
  • jonas jonas:
    FAANG?
  • Jesus4Lyf Jesus4Lyf:
    Not quite FAANG, less pay for a less hours/stress. Yeah, game dev as a hobby.
  • jonas jonas:
    makes sense. Do we have a hobby game dev subforum to showcase some work?
  • Blackveiled Blackveiled:
    Happy Thursday
    +1
  • The Helper The Helper:
    Happy Thursday!
  • The Helper The Helper:
    TGIF!
  • The Helper The Helper:
    hey tom_mai please do not archive anymore news
  • Ghan Ghan:
    AMD Ryzen 7000 next week :D
    +1
  • The Helper The Helper:
    noice!
  • tom_mai78101 tom_mai78101:
    "hey tom_mai please do not archive anymore news" ----> Got it. What should we do with the "News Archive" subforum?
  • The Helper The Helper:
    I think leave it for real old news that cannot be sorted the reason we had it in the first place was a server issue that we do not have anymore. I don't want to get rid of the archive just not put anything in it for now until we figure it out more
  • The Helper The Helper:
    The side chat has nothing on the discord. it is not possible but the biggest thing on my wish list right now is a sidechat channel on the disord that hooks up to this...
  • Ghan Ghan:
    I've been selected for the Diablo IV beta.
    +1
  • Ghan Ghan:
    Woo!
    +1
  • The Helper The Helper:
    that is so cool
  • V-SNES V-SNES:
    Eh just noticed the new discord section on the side. Looks great!
    +1
  • Blackveiled Blackveiled:
    :( feels bad I can't ever get selected for any beta I sign up for. It's annoying as heck.
    +1

    The Helper Discord

    Members online

    No members online now.

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top