Damage detection trigger, NOT working

sunshinex3

You can change this now in User CP.
I need to figure out why this isn't working, it fires off when not using the variables and just using a solid number so the second trigger works but when trying to use the bidedamagetaken variable it doesn't work, so im wondering if it is the custom script that is just below that's the problem?

I have this is in initialization its a custom script i was told would add the event unit takes damage to a trigger
Code:
library DamagedEventAdder initializer init
  private function init takes nothing returns nothing

    //change the name of the trigger to match the name of the trigger you want it added to
    //the format is: gg_trg_ + the name of the trigger with _ instead of spaces (see below)

    //if you change the name of the trigger in the trigger editor (or delete the trigger entirely) you will have to change it here
    //if you have multiple triggers that need this event you can duplicate the below line here for any number of triggers, just use the right name!

    call TriggerRegisterAnyUnitEventBJ(gg_trg_BideActivate, EVENT_PLAYER_UNIT_DAMAGED)
  endfunction
endlibrary
First trigger that i need "unit takes damage"
Trigger:
  • BideActivate
    • Events
    • Conditions
      • ((Damage Target) has buff Biding (NerubianKing)) Equal to True
    • Actions
      • Set VariableSet BideDamageTaken[(Player number of (Owner of (Damage Target)))] = (BideDamageTaken[(Player number of (Owner of (Damage Target)))] + (Damage taken))


this trigger works with a straight number but not with the variable arithmetic that i have here

Trigger:
  • BideDeactivate
    • Events
      • Unit - A unit Is issued an order with no target
    • Conditions
      • And - All (Conditions) are true
        • Conditions
          • ((Ordered unit) has buff Biding (NerubianKing)) Equal to True
          • (Issued order) Equal to (Order(unimmolation))
    • Actions
      • Set VariableSet TempPoint = (Position of (Ordered unit))
      • Unit - Cause (Ordered unit) to damage circular area after 0.00 seconds of radius 400.00 at TempPoint, dealing (BideDamageTaken[(Player number of (Owner of (Ordered unit)))] x (Real((Level of Bide (NerubianKing) for (Ordered unit))))) damage of attack type Spells and damage type Magic
      • Custom script: call RemoveLocation (udg_TempPoint)
[/code]
 
Last edited:

jonas

Well-Known Member
Add some debug messages.
Display the damage taken and the new value of BideDamageTaken in the first trigger.
Display the BideDamageTaken and the Level of Bide in the second trigger.

If your first trigger doesn't fire, remove the condition.

If even without the conditon it doesn't fire, it is the custom script. In that case please repost the custom script with
Code:
 code tags
 

jonas

Well-Known Member
Yep. The code itself looks good to me though.
Can you post a screenshot of the code in your trigger editor?

Maybe it is accidentally turned off, or in the comment section.

Another thing you can try is a new GUI trigger like this:

event : a unit enters the map
condition: type of triggering unit is (Nerubian King)
action: add event to trigger (BideActivate) : (triggering unit) takes damage
 

sunshinex3

You can change this now in User CP.
event : a unit enters the map
condition: type of triggering unit is (Nerubian King)
action: add event to trigger (BideActivate) : (triggering unit) takes damage
"can't find (triggering unit) takes damage"
i think that's why i had to add the custom script library.
 
Last edited:

jonas

Well-Known Member
Unfortunately I don't have Wc3 installed, but I was sure there is a GUI function to make that happen.
If there isn't, you can also try with this line of custom script which should do the same:



Another thing you can do is add the following to the custom script you already have:

Code:
if gg_trg_BideActivate == null then
    call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, "initialization called but trigger is null")
else
    call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, "initialization called and trigger exists")
endif
This should write some text at the beginning of the game. (Let me know if there are any syntax errors... sorry that I can't check that myself)
 

sunshinex3

You can change this now in User CP.
I am going to put this behind me i guess it's not possible with gui this is what i did it turned out fine.

Trigger:
  • BideActivate
    • Events
      • Unit - A unit Is attacked
    • Conditions
      • ((Attacked unit) has buff Biding (NerubianKing)) Equal to True
    • Actions
      • Set VariableSet BideDamageTaken[(Player number of (Owner of (Attacked unit)))] = (BideDamageTaken[(Player number of (Owner of (Attacked unit)))] + 1.00)


Number is increased based on how many attacks are made on the unit instead of damage taken, works well with tanks.


Trigger:
  • BideDeactivate
    • Events
      • Unit - A unit Is issued an order with no target
    • Conditions
      • And - All (Conditions) are true
        • Conditions
          • ((Ordered unit) has buff Biding (NerubianKing)) Equal to True
          • (Issued order) Equal to (Order(unimmolation))
    • Actions
      • Set VariableSet TempPoint = (Position of (Ordered unit))
      • Unit - Cause (Ordered unit) to damage circular area after 0.00 seconds of radius 400.00 at TempPoint, dealing (BideDamageTaken[(Player number of (Owner of (Ordered unit)))] x (Real((Level of Bide (NerubianKing) for (Ordered unit))))) damage of attack type Spells and damage type Magic
      • Set VariableSet BideDamageTaken[(Player number of (Owner of (Ordered unit)))] = 0.00
      • Custom script: call RemoveLocation (udg_TempPoint)



causes damage based on number of attacks made on caster and then resets the damage to 0.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    Have been talking to a childhood friend who is an Artist and is interested in doing some game music. He has a studio in his house. Yes!
  • The Helper The Helper:
    Going to try and get my friend into the homebrew game indie market he is real interested
  • Varine Varine:
    Does reforged require the port forwarding? Is that even still a thing?
  • The Helper The Helper:
    I do not think that is a thing anymore
  • The Helper The Helper:
    Battle.net is different now and I do not think they are using the same network code
  • The Helper The Helper:
    I am sure they are not
  • tom_mai78101 tom_mai78101:
    Lately, news aren't as enticing as they seemed. Or maybe I'm getting old and desensitized.
  • jonas jonas:
    I think news are more serious recently
  • tom_mai78101 tom_mai78101:
    More serious doesn't necessarily mean it's more interesting. :(
  • The Helper The Helper:
    I find that news.google.com has lots of interesting science stuff going on and the Space X stuff with Starship is super cool too
  • The Helper The Helper:
    plus the boring company and physics stuff happening now but I am more into the science now but there is still some crazy news I see out there using Reddit as a news source though and aggregate services like news.google and stuff and put AP in there I always read the news and yes sometimes it is not as interesting as others
  • The Helper The Helper:
    At some point I am going to look at Xenforo and see if it integrates with Hubspot at all. Would love to look at forum under a full marketing account in Hubspot since I have access to that stuff with my current gig
  • Ghan Ghan:
    Kind of surprised it wouldn't have its own forum product offering.
  • Ghan Ghan:
    That said, when Blizzard switched forum software, they went with Discourse, not xenForo.
  • jonas jonas:
    I think news.google shows you personalized news
  • midnight8 midnight8:
    any of the peeps in here run youtube channels? Figure of all the peeps in this forum, got to be some other geeks like me with channels
  • Ghan Ghan:
    I can say I've uploaded a YouTube video.
    +1
  • The Helper The Helper:
    I can say I know someone that uploaded a youtube video :)
  • jonas jonas:
    A friend of mine has a channel where he uploads some of the crazy machines he has built. Like when he plugged an electric motor into a 3d printed gearbox, attached it to his bycicle and then drove 50mph with it.
  • The Helper The Helper:
    You should post a link to his channel in General Discussion I would definitely check it out

    Members online

    No members online now.

    Affiliates

    Hive Workshop NUON Dome
    Top