Enemy takes 0 damage

F

Frizz.Meister

New Member
Reaction score
0
Dummy unit dies instantly when spell is cast.

A dummy unit dies instantly when spell is cast. My spell is a glaive being thrown(point targeted) and when it strikes a target the dummy unit (glaive) should die and the target should take damage. I know it sounds simple but i cannot work out why my dummy unit dies on what appears to be the first timer callback. Any help?

If it helps anyone it is like dota elunes arrow spell but with out the stun.

CODE:
JASS:
function Trig_Throw_Glaive_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A002' ) ) then
        return false
    endif
    return true
endfunction

function Distancecheck takes nothing returns boolean
    if ( not ( DistanceBetweenPoints(GetUnitLoc(GetLastCreatedUnit()), GetSpellTargetLoc()) < 1600.00 ) ) then
        return false
    endif
    return true
endfunction

function buildingcheck takes nothing returns boolean
    return ( IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) == false )
endfunction

function enemycheck takes nothing returns boolean
    return ( IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(GetTriggerUnit())) == true )
endfunction

function glaive1stand takes nothing returns boolean
    return GetBooleanAnd( buildingcheck(), enemycheck() )
endfunction

function Targetcheck takes nothing returns boolean
    if ( not ( CountUnitsInGroup(GetLastCreatedGroup()) > 0 ) ) then
        return false
    endif
    return true
endfunction

function glaivedeadcheck takes nothing returns boolean
    return (IsUnitDeadBJ(udg_Glaive[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]) == true)
endfunction

function Glaive_Movement takes nothing returns nothing
    local group gr
    local timer t = GetExpiredTimer()
    local unit u = GetHandleUnit(t, "u")
    local unit g = GetHandleUnit(t, "g")
    local unit h
    if ( Distancecheck() ) then
        call SetUnitPositionLoc(g, PolarProjectionBJ(GetUnitLoc(g),10,udg_Glaiveangle[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]))
        set gr=GetUnitsInRangeOfLocMatching(80.00, GetUnitLoc(GetLastCreatedUnit()), Condition(function glaive1stand))
        if ( Targetcheck() ) then
            call KillUnit( g )
            set h=GroupPickRandomUnit(GetLastCreatedGroup())
            call UnitDamageTargetBJ( u, h, 21.00, ATTACK_TYPE_MELEE, DAMAGE_TYPE_NORMAL )
    else
    endif
        set gr=null
    else
        call KillUnit( g )
    endif   
    set h=null
    set gr=null
    set g=null
    set u=null
endfunction

function Trig_Throw_Glaive_Actions takes nothing returns nothing
    local unit u=GetTriggerUnit()
    local unit g
    local timer t=CreateTimer()
    set udg_GlaiveThrower[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]=GetUnitLoc(GetTriggerUnit())
    set udg_GlaiveTarget[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]=GetSpellTargetLoc()
    set udg_Glaiveangle[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]=AngleBetweenPoints(GetUnitLoc(u), udg_GlaiveTarget[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))])
    call CreateNUnitsAtLoc(1,'n001',GetOwningPlayer(GetTriggerUnit()),PolarProjectionBJ(GetUnitLoc(GetTriggerUnit()),75.00,udg_Glaiveangle[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]),udg_Glaiveangle[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))])
    set g=GetLastCreatedUnit()
    call SetHandleHandle(t, "u", u)
    call SetHandleHandle(t, "g", g)
    set udg_Glaive[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]=g
    call TimerStart(t, 0.01, true, function Glaive_Movement)
    loop
        exitwhen ( glaivedeadcheck() )
        call TriggerSleepAction(RMaxBJ(bj_WAIT_FOR_COND_MIN_INTERVAL, 0.20))
    endloop
    call DestroyTimer(t)
    call FlushHandleLocals(t)
    set t=null
    set g=null
    set u=null
endfunction

//===========================================================================
function InitTrig_Throw_Glaive takes nothing returns nothing
    set gg_trg_Throw_Glaive = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Throw_Glaive, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Throw_Glaive, Condition( function Trig_Throw_Glaive_Conditions ) )
    call TriggerAddAction( gg_trg_Throw_Glaive, function Trig_Throw_Glaive_Actions )
endfunction
 
F

Frizz.Meister

New Member
Reaction score
0
Hi all,
I have made a simple spell that allows the unit to throw a glaive at a point and when it his the enemy the glaive(dummy unit) will die. However the enemy doesnt appear to take damage.

Can anyone help

JASS:
function Trig_Throw_Glaive_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A002' ) ) then
        return false
    endif
    return true
endfunction

function buildingcheck takes nothing returns boolean
    return ( IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) == false )
endfunction

function enemycheck takes nothing returns boolean
    return ( IsUnitAlly(GetFilterUnit(), GetOwningPlayer(GetTriggerUnit())) != false )
endfunction

function glaive1stand takes nothing returns boolean
    return GetBooleanAnd( buildingcheck(), enemycheck() )
endfunction

function Targetcheck takes nothing returns boolean
    if ( not ( CountUnitsInGroup(udg_GlaiveGroup) > 0 ) ) then
        return false
    endif
    return true
endfunction

function glaivedeadcheck takes nothing returns boolean
    return (IsUnitDeadBJ(udg_Glaive[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]) == true)
endfunction

function Glaive_Movement takes nothing returns nothing
    local timer t = GetExpiredTimer()
    local unit u = GetHandleUnit(t, "u")
    local unit g = GetHandleUnit(t, "g")
    local unit h
    call SetUnitPositionLoc(g, PolarProjectionBJ(GetUnitLoc(g),25,udg_Glaiveangle[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]))
    set udg_GlaiveGroup=GetUnitsInRangeOfLocMatching(90.00, GetUnitLoc(g), Condition(function glaive1stand))
    if ( Targetcheck() ) then
            set h=GroupPickRandomUnit(udg_GlaiveGroup)
            call KillUnit(g)
            call UnitDamageTargetBJ( u, h, 21.00, ATTACK_TYPE_MELEE, DAMAGE_TYPE_NORMAL )
    else
    endif
    set h=null
    set g=null
    set u=null
    call DestroyGroup(udg_GlaiveGroup)
endfunction

function Trig_Throw_Glaive_Actions takes nothing returns nothing
    local unit u=GetTriggerUnit()
    local unit g
    local timer t=CreateTimer()
    set udg_GlaiveThrower[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]=GetUnitLoc(GetTriggerUnit())
    set udg_GlaiveTarget[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]=GetSpellTargetLoc()
    set udg_Glaiveangle[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]=AngleBetweenPoints(GetUnitLoc(u), udg_GlaiveTarget[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))])
    call CreateNUnitsAtLoc(1,'n001',GetOwningPlayer(GetTriggerUnit()),PolarProjectionBJ(GetUnitLoc(GetTriggerUnit()),1.00,udg_Glaiveangle[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]),udg_Glaiveangle[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))])
    set g=GetLastCreatedUnit()
    call UnitApplyTimedLifeBJ( 0.35,'BTLF',g)
    call SetUnitPathing( GetLastCreatedUnit(), false )
    set udg_Glaive[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]=GetLastCreatedUnit()
    call SetHandleHandle(t, "u", u)
    call SetHandleHandle(t, "g", g)
    call TimerStart(t, 0.03, true, function Glaive_Movement)
    loop
        exitwhen ( glaivedeadcheck() )
        call TriggerSleepAction(RMaxBJ(bj_WAIT_FOR_COND_MIN_INTERVAL, 0.03))
    endloop
    call DestroyTimer(t)
    call FlushHandleLocals(t)
    set t=null
    set g=null
    set u=null
endfunction

//===========================================================================
function InitTrig_Throw_Glaive takes nothing returns nothing
    set gg_trg_Throw_Glaive = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Throw_Glaive, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Throw_Glaive, Condition( function Trig_Throw_Glaive_Conditions ) )
    call TriggerAddAction( gg_trg_Throw_Glaive, function Trig_Throw_Glaive_Actions )
endfunction
 
quraji

quraji

zap
Reaction score
144
Code: 
    local unit [B]h[/B]
    call SetUnitPositionLoc(g, PolarProjectionBJ(GetUnitLoc(g),25,udg_Glaiveangle[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]))
    set udg_GlaiveGroup=GetUnitsInRangeOfLocMatching(90.00, GetUnitLoc(g), Condition(function glaive1stand))
    if ( Targetcheck() ) then
            set h=GroupPickRandomUnit(udg_GlaiveGroup)
            call KillUnit(g)
            call UnitDamageTargetBJ( u, [B]h[/B], 21.00, ATTACK_TYPE_MELEE, DAMAGE_TYPE_NORMAL )

I'm not sure exactly how UnitDamageWhatever works (I never use it), but I'm assuming h should have some value.
 
trb92

trb92

Throwing science at the wall to see what sticks
Reaction score
142
h does have a value.

Code: 
local unit h
    call SetUnitPositionLoc(g, PolarProjectionBJ(GetUnitLoc(g),25,udg_Glaiveangle[GetPlayerId(GetOwningPlayer(GetTriggerUnit()))]))
    set udg_GlaiveGroup=GetUnitsInRangeOfLocMatching(90.00, GetUnitLoc(g), Condition(function glaive1stand))
    if ( Targetcheck() ) then
            [b]set h=GroupPickRandomUnit(udg_GlaiveGroup)[/b]
            call KillUnit(g)
            call UnitDamageTargetBJ( u, h, 21.00, ATTACK_TYPE_MELEE, DAMAGE_TYPE_NORMAL )
 
F

Frizz.Meister

New Member
Reaction score
0
Upon further testing it seems like h isnt even being detected which would make sense to the lack of damage. But it raises the question.

Why isnt h being detected?
 
bOb666777

bOb666777

Stand against the ugly world domination face!
Reaction score
117
Tom Jones said:
JASS:
function enemycheck takes nothing returns boolean
    return ( IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(GetTriggerUnit())) == true )
endfunction

GetTriggerUnit() isn't defined, event responses doesn't get passed to a timer, that's why we use attachment systems. Thus it'll return null player and mess up the group pick. You have to assign the player to some variable and make a comparision with that.
Click to expand...

He is actually using attachments
Except he's also using a lot of BJ variables and globals
And he's not attaching the player

Cmon, globals and bj variables arent pretty :(
you should try to learn how to do various thing without using bjs and globals
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      89 (members: 1, guests: 88)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top