Flash point skill, got it , need help.

Kyzerdrood

Kyzerdrood

New Member
Reaction score
3
hey everyone, i made a post earlier, which im going to go post in right after this, about me needing the Flash Point skill from the Magician in TBR.

basically what it does, is when u cast something, it creates two circles of explosions outside the unit doing damage.

anyway, i asked the map creator of the map, and he recently lost his unprotected maps and couldnt give me the spell, but would if he could.

so im not patient and dont want to wait for him to get his maps back, so i just opened the script in jasscraft and got the spell.

Problem is, he said it leaks badly.

And, when i imported it, it has a two second delay or so before it acually happens, it instantly spawns fire effects but takes a few seconds to do the damage and explosions.


im new with jass and i dont know whats causing the delay and how to fix the leaks, i would +rep anyone who could make this leakless, and show me what to do to get rid of the delay.




Idk if i can rep, i think i can, and ill try to rep anyone who helps.


Heres the code
its a big jumble lol

Trigger
JASS:
//TESH.scrollpos=51
//TESH.alwaysfold=0
function notin takes nothing returns nothing
    local unit udg_flashpointCaster
    local real udg_flashpointMana=0
    local trigger gg_trg_flashpoint=null 
endfunction

function Trig_flashpoint_Conditions takes nothing returns boolean
  if(not(GetSpellAbilityId()=='A0K7'))then
    return false
    endif
    return true
    endfunction
function Trig_flashpoint_Func001002003 takes nothing returns boolean
    return(IsPlayerEnemy(GetOwningPlayer(GetFilterUnit()),GetOwningPlayer(GetTriggerUnit()))==true)
endfunction
function Trig_flashpoint_Func002002 takes nothing returns nothing
    call UnitDamageTargetBJ(GetTriggerUnit(),GetEnumUnit(),I2R(udg_damageBonus[GetConvertedPlayerId(GetOwningPlayer(GetTriggerUnit()))]),ATTACK_TYPE_NORMAL,DAMAGE_TYPE_MAGIC)
endfunction
function Trig_flashpoint_Func004C takes nothing returns boolean
  if(not(IsUnitType(GetSpellAbilityUnit(),UNIT_TYPE_HERO)==true))then
    return false
    endif
    return true
endfunction
function Trig_flashpoint_Func005Func002C takes nothing returns boolean
    return true
endfunction
function Trig_flashpoint_Func009002 takes nothing returns nothing
    call RemoveUnit(GetEnumUnit())
endfunction
function Trig_flashpoint_Actions takes nothing returns nothing
    set udg_group1=GetUnitsInRangeOfLocMatching(600.00,GetUnitLoc(GetTriggerUnit()),Condition(function Trig_flashpoint_Func001002003))
    call ForGroupBJ(udg_group1,function Trig_flashpoint_Func002002)
    set udg_flashpointCaster=GetTriggerUnit()
if(Trig_flashpoint_Func004C())then
    set bj_forLoopAIndex=1
    set bj_forLoopAIndexEnd=11
loop
exitwhen bj_forLoopAIndex>bj_forLoopAIndexEnd
    set bj_forLoopBIndex=1
    set bj_forLoopBIndexEnd=18
loop
exitwhen bj_forLoopBIndex>bj_forLoopBIndexEnd
    set udg_point1=GetUnitLoc(GetTriggerUnit())
    set udg_point2=PolarProjectionBJ(udg_point1,350.00,((I2R(GetForLoopIndexA())*90.00)+(I2R(GetForLoopIndexB())*5.00)))
    call CreateNUnitsAtLoc(1,'h01S',GetOwningPlayer(GetTriggerUnit()),udg_point2,bj_UNIT_FACING)
    set udg_point2=PolarProjectionBJ(udg_point1,350.00,((I2R(GetForLoopIndexA())*180.00)+(I2R(GetForLoopIndexB())*5.00)))
    call CreateNUnitsAtLoc(1,'h01S',GetOwningPlayer(GetTriggerUnit()),udg_point2,bj_UNIT_FACING)
    set udg_point2=PolarProjectionBJ(udg_point1,350.00,((I2R(GetForLoopIndexA())*270.00)+(I2R(GetForLoopIndexB())*5.00)))
    call CreateNUnitsAtLoc(1,'h01S',GetOwningPlayer(GetTriggerUnit()),udg_point2,bj_UNIT_FACING)
    set udg_point2=PolarProjectionBJ(udg_point1,350.00,((I2R(GetForLoopIndexA())*360.00)+(I2R(GetForLoopIndexB())*5.00)))
    call CreateNUnitsAtLoc(1,'h01S',GetOwningPlayer(GetTriggerUnit()),udg_point2,bj_UNIT_FACING)
    call RemoveLocation(udg_point1)
    call RemoveLocation(udg_point2)
    set bj_forLoopBIndex=bj_forLoopBIndex+1
endloop
    call TriggerSleepAction(0.01)
    set bj_forLoopAIndex=bj_forLoopAIndex+1
endloop
    else
    endif
    set bj_forLoopAIndex=1
    set bj_forLoopAIndexEnd=10
loop
exitwhen bj_forLoopAIndex>bj_forLoopAIndexEnd
    set udg_nuclear_flame_level=GetUnitAbilityLevelSwapped('A0K7',GetTriggerUnit())
if(Trig_flashpoint_Func005Func002C())then
    set bj_forLoopAIndex=1
    set bj_forLoopAIndexEnd=16
loop
exitwhen bj_forLoopAIndex>bj_forLoopAIndexEnd
    call CreateNUnitsAtLoc(1,'h01T',GetOwningPlayer(GetTriggerUnit()),GetUnitLoc(GetTriggerUnit()),bj_UNIT_FACING)
    call SetUnitAbilityLevelSwapped('A0K8',GetLastCreatedUnit(),udg_nuclear_flame_level)
    call UnitApplyTimedLifeBJ(2.00,'BTLF',GetLastCreatedUnit())
    call IssuePointOrderLocBJ(GetLastCreatedUnit(),"impale",PolarProjectionBJ(GetUnitLoc(GetTriggerUnit()),100.00,udg_nuclear_flame_area))
    set udg_nuclear_flame_area=(udg_nuclear_flame_area+25.00)
    set bj_forLoopAIndex=bj_forLoopAIndex+1
endloop
else
endif
    set bj_forLoopAIndex=bj_forLoopAIndex+1
endloop
 call TriggerSleepAction(0.70)
 call TriggerSleepAction(0.50)
    set udg_group1=GetUnitsOfTypeIdAll('h01S')
    call ForGroupBJ(udg_group1,function Trig_flashpoint_Func009002)
    call DestroyGroup(udg_group1)
endfunction

function InitTrig_flashpoint takes nothing returns nothing
    set gg_trg_flashpoint=CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(gg_trg_flashpoint,EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddCondition(gg_trg_flashpoint,Condition(function Trig_flashpoint_Conditions))
    call TriggerAddAction(gg_trg_flashpoint,function Trig_flashpoint_Actions)
endfunction
 
T

TriggerHappy

...
Reaction score
341
You just converted a GUI trigger to JASS.

Tips..
  • Remove all the BJ's
  • Fix all the integer A/B loops, use local integers instead
  • Fix all those conditions, dont make'em call to other functions

It would be better writing that code from scratch in JASS, Than converting from GUI and porting to good JASS.
 
Kyzerdrood

Kyzerdrood

New Member
Reaction score
3
as i said, i took it from the j file in his map, since he didnt have the unprotected GUI version, and i dont no how to make it from scratch or make it in GUI lol.
 
T

TriggerHappy

...
Reaction score
341
Well thats just a GUI trigger (when a map is saved, triggers are compiled to jass) so... Read up on some jass tutorials, and fixing this should be a breeze.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though

      The Helper Discord

      Members online

      No members online now.
      Online now:
      254 (members: 0, guests: 254)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top