grow/shrink trigger not working

PrisonLove

Hard Realist
Reaction score
78
I'm using the vanilla editor (running on a mac) and I have a trigger that fires when a unit picks up a red mushroom (it's a mario map). As you know, when you get a red mushroom in mario your character grows, gets more health/damage/other stuff. That's what's happening here. Everything about this trigger works, except for the shrinking portion. The character grows, gets damage, range, etc, the range and damage go back to normal, but the character never gets smaller and I don't know why.

Here is the code:

JASS:
function RedMushroomConditions takes nothing returns boolean
    return GetItemTypeId(GetManipulatedItem()) == 'I003'
endfunction


function RedMushroomShrink takes nothing returns nothing
    local timer t = GetExpiredTimer()
    local integer id = GetHandleId(t)
    local unit caster = LoadUnitHandle(udg_hash, id, 0)
    local real scaleAmnt = LoadReal(udg_hash, id, 1)
    local real scaleFactor = scaleAmnt - 5
    local real scale = 200 - scaleFactor
    local real scaleCap = 100.00

    if (scale > scaleCap) then
        call SetUnitScalePercent(caster, scale, scale, scale)
        set scaleAmnt = scaleFactor
        call SaveReal(udg_hash, id, 1, scaleAmnt)
    else
        call PauseTimer(t)
        call DestroyTimer(t)
        call FlushChildHashtable(udg_hash, id)
    endif
    
    set t = null
    set caster = null
endfunction


function RedMushroomGrow takes nothing returns nothing
    local timer t = GetExpiredTimer()
    local integer id = GetHandleId(t)
    local unit caster = LoadUnitHandle(udg_hash, id, 0)
    local real scaleAmnt = LoadReal(udg_hash, id, 1)
    local real scaleFactor = scaleAmnt + 5
    local real scale = 100.00 + scaleFactor
    local real scaleCap = 215.00

    if (scale < scaleCap) then
        call SetUnitScalePercent(caster, scale, scale, scale)
        set scaleAmnt = scaleFactor
        call SaveReal(udg_hash, id, 1, scaleAmnt)
    else
        call PauseTimer(t)
        call DestroyTimer(t)
    endif
    
    set t = null
    set caster = null
endfunction


function RedMushroomActions takes nothing returns nothing
    local unit caster = GetTriggerUnit()
    local player p = GetOwningPlayer(caster)
    local integer i = GetPlayerId(p) + 1
    local timer t = CreateTimer()
    local timer t2 = CreateTimer()
    local integer id = GetHandleId(t)
    local real duration = 10
    local real scaleAmnt = 0

    set udg_damageAmount<i> = udg_damageAmount<i> + 40
    set udg_offsetRange<i> = udg_offsetRange<i> + 50
    set udg_attackRange<i> = udg_attackRange<i> + 50
    call UnitAddAbility(caster, &#039;A00B&#039;)

    call SaveUnitHandle(udg_hash, id, 0, caster)
    call SaveReal(udg_hash, id, 1, scaleAmnt)

    call TimerStart(t, .03, true, function RedMushroomGrow)

    call TriggerSleepAction(duration)

    set scaleAmnt = LoadReal(udg_hash, id, 1)
    set id = GetHandleId(t2)
    call SaveUnitHandle(udg_hash, id, 0, caster)
    call SaveReal(udg_hash, id, 1, scaleAmnt)
    call TimerStart(t2, .03, true, function RedMushroomShrink)

    call UnitRemoveAbility(caster, &#039;A00B&#039;)
    set udg_damageAmount<i> = udg_damageAmount<i> - 40
    set udg_offsetRange<i> = udg_offsetRange<i> - 50
    set udg_attackRange<i> = udg_attackRange<i> - 50

    set caster = null
    set p = null
    set t = null
    set t2 = null
endfunction

//===========================================================================
function InitTrig_RedMushroom takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_PICKUP_ITEM )
    call TriggerAddCondition( t, Condition( function RedMushroomConditions ) )
    call TriggerAddAction( t, function RedMushroomActions )
    set t = null
endfunction</i></i></i></i></i></i></i></i></i></i></i></i>
 

the Immortal

I know, I know...
Reaction score
51
Your calculations are wrong.

[ljass] local real scale = 200 - scaleFactor[/ljass]

this should be simply

[ljass] local real scale = 100.00 + scaleFactor[/ljass]


as it is in your other function. Or set scaleAmnt to 0 for the shrink function.
Also you can make the 2 functions one, saving whether you are increasing or decreasing in the hashtable. I'd trade these 2 function calls for some readability / less spaghettiness.


PS. Explanation: Growing stops at 215% scale, meaning [ljass]scaleAmnt = 115[/ljass]. You don't reset it first time you shrink, so it becomes 110, and then [ljass]scale = 200 - scaleFactor = 200 - 110 = 90 < 100[/ljass] which stops the timer, when it should actually be [ljass]100 + scaleFactor = 100 + 110 = 210[/ljass].

On the other hand, you can set [ljass]scaleAmnt = 0[/ljass], make it increase by 5 in the shrink function (not decrease) and then calculate size with [ljass]scale = 215 - scaleFactor = 215 - 5 = 210 //(205, 200, ...)[/ljass]

Hope it helps.
 

PrisonLove

Hard Realist
Reaction score
78
Yep, that did it, thanks a lot. I was trying to figure out how to put them both into one function, any ideas? I know they're far too similar not to be one function.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Staff online

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top