Help me Clean up my spell

[lindenkron]

Leaks, things that can be improved / made difference, any input (that is relevant) is appreciated.

• ShiveringFeeling
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Shivering Experience
  • Actions
    • Set i = 3.00
    • Set TempLocation = (Target point of ability being cast)
    • Set TempGroup = (Units within 250.00 of TempLocation)
    • Unit Group - Pick every unit in TempGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True
          • Then - Actions
            • Unit - Set (Picked unit) movement speed to ((Current movement speed of (Triggering unit)) mod 2.00)
            • Animation - Change (Picked unit)'s size to (80.00%, 8.00%, 80.00%) of its original size
          • Else - Actions
    • For each (Integer A) from 1 to 20, do (Actions)
      • Loop - Actions
        • Wait 0.05 seconds
        • Set TempPoint[((Integer A) + (Player number of (Owner of (Triggering unit))))] = (TempLocation offset by (Random real number between 0.00 and 250.00) towards (Random angle) degrees)
        • Special Effect - Create a special effect at TempPoint[((Integer A) + (Player number of (Owner of (Triggering unit))))] using Abilities\Spells\Other\Drain\ManaDrainTarget.mdl
        • Set SpecialEffect = (Last created special effect)
        • Trigger - Run DestroyEffect <gen> (ignoring conditions)
        • Custom script: call RemoveLocation(udg_TempPoint[GetConvertedPlayerId(GetOwningPlayer(GetTriggerUnit()))])
        • Set TempPoint[((Integer A) + (Player number of (Owner of (Triggering unit))))] = (TempLocation offset by (Random real number between 0.00 and 250.00) towards (Random angle) degrees)
        • Special Effect - Create a special effect at TempPoint[((Integer A) + (Player number of (Owner of (Casting unit))))] using Abilities\Weapons\DragonHawkMissile\DragonHawkMissile.mdl
        • Special Effect - Destroy (Last created special effect)
        • Environment - Create a 2.00 second random deformation at TempLocation with radius 250.00, using depths between -32.00 and 32.00, updating every 0.20 seconds
        • Environment - Stop (Last created terrain deformation) over 0.50 seconds
        • Custom script: call RemoveLocation(udg_TempPoint[GetConvertedPlayerId(GetOwningPlayer(GetTriggerUnit()))])
        • Unit - Cause (Casting unit) to damage circular area after 0.00 seconds of radius 250.00 at TempLocation, dealing 5.00 damage of attack type Spells and damage type Normal
    • Unit Group - Pick every unit in TempGroup and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True
          • Then - Actions
            • Unit - Set (Picked unit) movement speed to (Default movement speed of (Triggering unit))
            • Animation - Change (Picked unit)'s size to (100.00%, 100.00%, 100.00%) of its original size
          • Else - Actions
    • Custom script: call DestroyGroup(udg_TempGroup)
    • Custom script: call RemoveLocation(udg_TempLocation)

• DestroyEffect
  • Events
  • Conditions
  • Actions
    • Custom script: local effect tempEffect
    • Custom script: set tempEffect = udg_SpecialEffect
    • Set i = (i - 0.15)
    • Wait i seconds
    • Custom script: set udg_SpecialEffect = tempEffect
    • Custom script: call DestroyEffect( udg_SpecialEffect )

In advance,
Thanks
-Lindenkron

 

[darkbeer]

waits in an integer A loop can cause you some problems if you have any other integer A loop running while your trigger is running so better use a integer variable.

put setting of i inside the loop, since you have waits there other triggers will interfere as well. (unless youre using the destroy effect thing only for this trigger)

also does TempGroup always stay the same for 1 second?
i doubt it, so there can be bugs here as well and the units wont be resizedand get their normal movement speed. (if any other trigger is using tempgroup while this one is running it wont)

to avoid that use a local group.

hm im not sure but i think its better if you use a slow spell and a dummy to slow units, what if the current moemnt speed f the unit is affected by some buff or items, dont know if the default movemnt speed will include that. So not sure about this.

Note: Waits arent very accurate and not suited for very small values so yours will probably wait for around 0.2 seconds instead of 0.05 but if you dont have a problem with that then its okay

 

[lindenkron]

Hmm okay, thanks. Ill look into it.

Also, could you give me some suggestions on how to make it MUI? Kinda needed for spells

 

[X-maul]

if you want it MUI, then make all your Variables area, and then make the area' [Player number of owner of triggering unit], that might help

 

[darkbeer]

well using locals is enough for this i guess^^

basically we create a local for everything we need after the wait and set our Globals to the locals after each wait. Same principle you used in the destroy effect trigger.

    * ShiveringFeeling
          o Events
                + Unit - A unit Starts the effect of an ability
          o Conditions
                + (Ability being cast) Equal to Shivering Experience
          o Actions
                + Custom script: local group g
                + Custom script: local integer i = 1
                + Custom script: local location loc
                + Set i = 3.00
                + Set TempLocation = (Target point of ability being cast)
                + Custom script: set loc = udg_TempLocation
                + Set TempGroup = (Units within 250.00 of TempLocation)
                + Unit Group - Pick every unit in TempGroup and do (Actions)
                      # Loop - Actions
                            * If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                  o If - Conditions
                                        + ((Picked unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True
                                  o Then - Actions
                                        + Unit - Set (Picked unit) movement speed to ((Current movement speed of (Triggering unit)) mod 2.00)
                                        + Animation - Change (Picked unit)'s size to (80.00%, 8.00%, 80.00%) of its original size
                                  o Else - Actions
                 + Custom script: set g = udg_TempGroup
                 + Custom script: loop //a loop^^
                            * Custom script: exitwhen i > 20 // does this 20 times
                            * Wait 0.05 seconds
                            * Custom script: set udg_TempLocation = loc // getting our old location
                            * Custom script: set bj_forLoopAIndex = i //sets integerA to the value of our local integer i
                            * Set TempPoint[((Integer A) + (Player number of (Owner of (Triggering unit))))] = (TempLocation offset by (Random real number between 0.00 and 250.00) towards (Random angle) degrees) // dont really get this^^ why does TempPoint need an array? and why the + Player number thing
                            * Special Effect - Create a special effect at TempPoint[((Integer A) + (Player number of (Owner of (Triggering unit))))] using Abilities\Spells\Other\Drain\ManaDrainTarget.mdl
                            * Set SpecialEffect = (Last created special effect)
                            * Trigger - Run DestroyEffect <gen> (ignoring conditions)
                            * Custom script: call RemoveLocation(udg_TempPoint[[COLOR="Red"]bj_forLoopAIndex +[/COLOR] GetConvertedPlayerId(GetOwningPlayer(GetTriggerUnit()))]) // wheres the integerA in the array which you used before?
                            * Set TempPoint[((Integer A) + (Player number of (Owner of (Triggering unit))))] = (TempLocation offset by (Random real number between 0.00 and 250.00) towards (Random angle) degrees)
                            * Special Effect - Create a special effect at TempPoint[((Integer A) + (Player number of (Owner of (Casting unit))))] using Abilities\Weapons\DragonHawkMissile\DragonHawkMissile.mdl
                            * Special Effect - Destroy (Last created special effect)
                            * Environment - Create a 2.00 second random deformation at TempLocation with radius 250.00, using depths between -32.00 and 32.00, updating every 0.20 seconds
                            * Environment - Stop (Last created terrain deformation) over 0.50 seconds
                            * Custom script: call RemoveLocation(udg_TempPoint[GetConvertedPlayerId(GetOwningPlayer(GetTriggerUnit()))])
                            * Unit - Cause (Casting unit) to damage circular area after 0.00 seconds of radius 250.00 at TempLocation, dealing 5.00 damage of attack type Spells and damage type Normal
                            * Custom script: set i = i + 1
                + Custom script: set udg_TempGroup = g
                + Unit Group - Pick every unit in TempGroup and do (Actions)
                      # Loop - Actions
                            * If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                  o If - Conditions
                                        + ((Picked unit) belongs to an enemy of (Owner of (Casting unit))) Equal to True
                                  o Then - Actions
                                        + Unit - Set (Picked unit) movement speed to (Default movement speed of (Triggering unit))
                                        + Animation - Change (Picked unit)'s size to (100.00%, 100.00%, 100.00%) of its original size
                                  o Else - Actions
                + Custom script: call DestroyGroup(udg_TempGroup) // this should destroy both groups i think
                + Custom script: call RemoveLocation(udg_TempLocation)
                + Custom script: call RemoveLocation(loc)
                + Custom script: set loc = null
                + Custom script: set g = null

EDIT: @ X-Maul isnt that called MPI?

EDIT2: @ Windwalk ... thats what he did there^^

 

[Windwalk]

• Set TempPoint[((Integer A) + (Player number of (Owner of (Triggering unit))))] = (TempLocation offset by (Random real number between 0.00 and 250.00) towards (Random angle) degrees)

this leaks

when its offset by (REAL) towards (w/e) the offset will cause a leak..

just set another variable

Set TempPoint2 = TempPoint offset by w/ew/e

and destroy it later

 

[lindenkron]

Thanks darkbeer, I'll look into this later on It's kind of a site project when I'm not 'into' something else. At the moment I'm having the major issues with my bomb in the current map I'm working on. If it wouldn't be to much to ask, could you take a look at it? It's called changing ownership to custom value.

In advance,
Thanks
-Lindenkron