Help the newbie alert.

A

alzidaney

Guest
Ok newbie to this forum and to JASS as well. I'm making use of someone's free code posted in the free trigger code thread.

His definition for the code function I used is as follows

Code:
function GetNearestUnitMatching takes real sourceX, real sourceY, real range, boolexpr cond, boolean considerdead returns unit

Now, below here is what I attempted to do with the function. (OBviously its wrong. Its part of the whole trigger code btw.)

Code:
function IsEnemy takes nothing returns boolean
    local unit nextunit = GetEnumUnit()
    
    return GetOwningPlayer(nextunit) == GetOwningPlayer(udg_Summoned)
endfunction

function Trig_Tornado_Effect_Actions takes nothing returns nothing
       local unit nearest
       //local boolexpr bolexpr = 
       nearest = call GetNearestUnitMatching(GetLocationX(GetUnitLoc(GetSummonedUnit())), GetLocationY(GetUnitLoc(GetSummonedUnit())), 125, Condition(IsEnemy) , false)
endfunction

The error shows in the line
Code:
nearest = call GetNearestUnitMatching(GetLocationX(GetUnitLoc(GetSummonedUnit())), GetLocationY(GetUnitLoc(GetSummonedUnit())), 125, Condition(IsEnemy) , false)

It says that "Expected Code Statement". Im lost. Totally. I tried searching around this forum but to no avail. :(
 
A

alzidaney

Guest
Just tried it. Does'nt work. What's the diff between Filter and Enum anyways?
 

phyrex1an

Staff Member and irregular helper
Reaction score
447
FilterUnit is the unit that is 'filtered' in a boolexpr callback, EnumUnit is the unit 'picked' with ForGroup.

In addition to my last post change this:
nearest = call GetNearestUnitMatching(...)
to
set nearest = GetNearestUnitMatching(...)
 
A

alzidaney

Guest
Thx for the explaination on Filter and Enum. :)

Anyway, now there's a new error. It says "Expected Expression".
For that same line as well. :(
 
A

alzidaney

Guest
For which part should I use that? I tried it in the 'Condition(function IsEnemy)' but it still gave the same error..
 

corvusHaunt

New Member
Reaction score
96
Try this
Code:
function IsEnemy takes nothing returns boolean  //this function leaks a unit btw
    local unit nextunit = GetEnumUnit()  
    
    return GetOwningPlayer(nextunit) == GetOwningPlayer(udg_Summoned)
endfunction

function Trig_Tornado_Effect_Actions takes nothing returns nothing
       local unit nearest = GetSummonedUnit()
       local boolexpr bolexpr = Condition(function IsEnemy)
     
       set nearest = GetNearestUnitMatching(GetUnitX(nearest), GetUnitY(nearest), 125, bolexpr , false)
       
        //don't forget to clean up the boolexpr:
        call DestroyBoolExpr(bolexpr)
        set bolexpr = null
endfunction
 
A

alzidaney

Guest
OMFG. I love you man! :) Works finally. So.. Can you explain what you did
and what's the cause? :D THX THX THXTHX!!!
 

corvusHaunt

New Member
Reaction score
96
Your code:
Code:
function Trig_Tornado_Effect_Actions takes nothing returns nothing
       local unit nearest
       //local boolexpr bolexpr = 
       nearest = [COLOR=Red]call[/COLOR] GetNearestUnitMatching(GetLocationX(GetUnitLoc(GetSummonedUnit())), GetLocationY(GetUnitLoc(GetSummonedUnit())), 125, Condition(IsEnemy) , false)
endfunction

Code:
function Trig_Tornado_Effect_Actions takes nothing returns nothing
       local unit nearest = GetSummonedUnit() //You get the point of this unit, then get the X,Y of that point, twice; which is useless, I switched to GetUnitX/Y
       local boolexpr bolexpr = Condition(function IsEnemy) //store the boolexpr in a variable so we can destroy the leak
     
       set nearest = GetNearestUnitMatching(GetUnitX(nearest), GetUnitY(nearest), 125, bolexpr , false) //you only need to use "call" when calling the function directly, passing a function to return a value does not need this
       
        //don't forget to clean up the boolexpr:
        call DestroyBoolExpr(bolexpr)  //destroy the condition
        set bolexpr = null  //remove the var leak
endfunction

Glad I could help, have fun with this neat function :)
(PS- I made this and gave it to WP, he added the bj_lastHauntedGoldMine, I know him :p)
 
A

alzidaney

Guest
Oh geez.. And to think it was like so hard to figure that out.. Only you did it. :) Nice job! Thx a lot oh great one! ;)

Anyway, my JassCraft doesnt compile properly. When I click syntax check,
it will go "Checking ____filename___" for some time.. Then it comes out, "Parse successful : 1733 lines: common.j"

I have no idea what that means. I gave up and use WE's syntax checker, though some said its not fully fullproof.. Any suggestions?
 

corvusHaunt

New Member
Reaction score
96
Hmmm, I don't what that could be. WE's syntax checker isn't that great, JASSCraft's is a step up, plus the fact you don't have to worry about the crashes the syntax checker in WE sometimes causes when trying to enable a disabled trigger, save or test.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/
  • The Helper The Helper:
    I think we need to add something to the bottom of the front page that shows the Headline News forum that has a link to go to the News Forum Index so people can see there is more news. Do you guys see what I am saying, lets say you read all the articles on the front page and you get to the end and it just ends, no kind of link for MOAR!
  • The Helper The Helper:
    Happy Wednesday!
    +1
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    Sticking with the desserts for now the latest recipe is Fried Apple Pies - https://www.thehelper.net/threads/recipe-fried-apple-pies.194297/
  • The Helper The Helper:
    Finally finding about some of the bots that are flooding the users online - bytespider apparently is a huge offender here - ignores robots.txt and comes in from a ton of different IPs

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top