Help with coding

N

NetherHawk

New Member
Reaction score
26
Ok, i tried writing the code for dota's Berserker Call which forces all enemy units in the vicinity to attack it. This aint working for me. Can you point me in the right direction?

JASS:
scope BerserkerCall initializer Init
// Objects used:
// 'A009' = Berserker Call (Axe : Mogul Kahn)
// 'B003' = Berserker Call Buff
// 'A008' = Berserker Call Effect (armour)
// 'h00A' = Spellcaster  

globals
    unit bcu
endglobals

private struct berserker
    unit bsu
    group bsg 
    trigger bst
        
    method onDestroy takes nothing returns nothing
        call ReleaseGroup(.bsg)
        call DestroyTrigger(.bst)
        set .bst = null
        set .bsg = null  
        set .bsu = null
    endmethod
endstruct

private function Berserker_Call_Conditions takes nothing returns boolean
	return GetSpellAbilityId()=='A009'
endfunction

private function Berserker_Call_Check takes nothing returns boolean
    local berserker d = GetTriggerStructA(GetTriggeringTrigger())
	if GetUnitAbilityLevel(GetFilterUnit(),'B003') > 0 and IsUnitInGroup(GetFilterUnit(),d.bsg) == true and GetUnitState(d.bsu,UNIT_STATE_LIFE) > 0 then
	   call DisableTrigger(d.bst)
       call IssueTargetOrder(GetFilterUnit(),"attack",d.bsu)
       call EnableTrigger(d.bst)
    endif	
	return false
endfunction

private function Berserker_Call_Filter takes nothing returns boolean
    return GetUnitAbilityLevel(GetFilterUnit(),'B003') > 0 and IsUnitEnemy(GetFilterUnit(),GetOwningPlayer(bcu)) == true
endfunction     

private function Berserker_Call_Attack takes nothing returns nothing
    call IssueTargetOrder(GetEnumUnit(),"attack",bcu)
endfunction       

private function Berserker_Call_CreepAttack takes nothing returns nothing
	if GetOwningPlayer(GetEnumUnit())== Player(0) then		
		call IssuePointOrder(GetEnumUnit(),"attack",GetRectCenterX(gg_rct_Scourge_Spawn),GetRectCenterY(gg_rct_Scourge_Spawn))
	elseif GetOwningPlayer(GetEnumUnit())== Player(6) then		
		call IssuePointOrder(GetEnumUnit(),"attack",GetRectCenterX(gg_rct_Sentinel_Spawn),GetRectCenterY(gg_rct_Sentinel_Spawn))
    endif
endfunction

private function Berserker_Call_Actions takes nothing returns nothing
    local berserker d = berserker.create()         
    local unit dx		  	
	
	set d.bsu = GetTriggerUnit()
    set d.bsg = NewGroup()
    set d.bst = CreateTrigger()
	set bcu = d.bsu		
	
	set dx = CreateUnit(GetOwningPlayer(d.bsu),'h00A',GetUnitX(d.bsu),GetUnitY(d.bsu),bj_UNIT_FACING)
    call SetUnitInvulnerable(dx,true)
	call UnitAddAbility(dx,'A008')
	call SetUnitAbilityLevel(dx,'A008',GetUnitAbilityLevel(d.bsu,'A009'))  	
	call IssueTargetOrder(dx,"innerfire",d.bsu)    
   	call UnitAddAbility(dx,'Aloc')
    call UnitApplyTimedLife(dx,'BTLF',.8)
	
    call PolledWait(.2)
	call GroupEnumUnitsInRange(d.bsg,GetUnitX(d.bsu),GetUnitY(d.bsu),300.,Condition(function Berserker_Call_Filter))
    call ForGroup(d.bsg,function Berserker_Call_Attack)    
    
	call TriggerRegisterAnyUnitEventBJ(d.bst,EVENT_PLAYER_UNIT_ISSUED_TARGET_ORDER)
	call TriggerRegisterAnyUnitEventBJ(d.bst,EVENT_PLAYER_UNIT_ISSUED_POINT_ORDER)
	call TriggerRegisterAnyUnitEventBJ(d.bst,EVENT_PLAYER_UNIT_ISSUED_ORDER)
	call TriggerAddCondition(d.bst,Condition(function Berserker_Call_Check))	
    call SetTriggerStructA(d.bst,d)
  	
	call PolledWait(1+(.5*I2R(GetUnitAbilityLevel(d.bsu,'A009'))))		
	call ForGroup(d.bsg,function Berserker_Call_CreepAttack)	   	
	
	call ClearTriggerStructA(d.bst)
	call d.destroy()
    set dx = null
endfunction

private function Init takes nothing returns nothing
	local trigger tr = CreateTrigger()
	call TriggerRegisterAnyUnitEventBJ(tr,EVENT_PLAYER_UNIT_SPELL_EFFECT)
	call TriggerAddCondition(tr,Condition(function Berserker_Call_Conditions))
	call TriggerAddAction(tr,function Berserker_Call_Actions)
endfunction

endscope
 
Azlier

Azlier

Old World Ghost
Reaction score
461
>use taunt or 10 rows GUI trigger

Taunt doesn't do that. And stop suggesting GUI for absolutely everything. If he's learned vJass, why downgrade to GUI?

Okay, I see lots of things wrong with that script. The dynamic triggers are totally unnecessary. Get rid of them. Your script probably needs a total rewrite because it's so messed up.
 
N

NetherHawk

New Member
Reaction score
26
sorry could you point out which part is messed up? im sure it can be fixed ^^


edit: sorry the code works fine. The trigger i used for testing was an old version. Anyway, can you still point out which parts are not properly codeD? what is the meaning of a dynamic triggeR?
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      85 (members: 0, guests: 85)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top