Help with simple system

B

black.sheep

Active Member
Reaction score
24
I've got this system in my map that allows you to read books via dialogs. However it doesn't seem to work for any other player apart from red.

Starting system
Trigger:
  • Book System
    • Events
      • Unit - A unit Uses an item
    • Conditions
    • Actions
      • For each (Integer A) from 1 to 10, do (Actions)
        • Loop - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • (Item-type of (Item being manipulated)) Equal to Book[(Integer A)]
            • Then - Actions
              • Set BookNumber[(Player number of (Owner of (Triggering unit)))] = (Integer A)
              • Dialog - Hide BookDialog[(Player number of (Triggering player))] for (Owner of (Triggering unit))
              • Dialog - Change the title of BookDialog[(Player number of (Triggering player))] to (Name of (Item being manipulated))
              • Dialog - Create a dialog button for BookDialog[(Player number of (Owner of (Triggering unit)))] labelled Page 1
              • Set BookOption1[(Player number of (Triggering player))] = (Last created dialog Button)
              • Dialog - Create a dialog button for BookDialog[(Player number of (Owner of (Triggering unit)))] labelled Page 2
              • Set BookOption2[(Player number of (Triggering player))] = (Last created dialog Button)
              • Dialog - Create a dialog button for BookDialog[(Player number of (Owner of (Triggering unit)))] labelled Page 3
              • Set BookOption3[(Player number of (Triggering player))] = (Last created dialog Button)
              • Dialog - Create a dialog button for BookDialog[(Player number of (Owner of (Triggering unit)))] labelled Exit
              • Set BookQuit[(Player number of (Triggering player))] = (Last created dialog Button)
              • Dialog - Show BookDialog[(Player number of (Triggering player))] for (Owner of (Triggering unit))
              • Skip remaining actions
            • Else - Actions


Selecting the page
Trigger:
  • Select Page
    • Events
      • Dialog - A dialog button is clicked for BookDialog[1]
    • Conditions
    • Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Clicked dialog button) Equal to BookOption1[(Player number of (Triggering player))]
        • Then - Actions
          • Dialog - Hide BookDialog[(Player number of (Triggering player))] for (Triggering player)
          • Game - Display to (Player group((Triggering player))) the text: BookString1[BookNumber[(Player number of (Triggering player))]]
        • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Clicked dialog button) Equal to BookOption2[(Player number of (Triggering player))]
        • Then - Actions
          • Dialog - Hide BookDialog[(Player number of (Triggering player))] for (Triggering player)
          • Game - Display to (Player group((Triggering player))) the text: BookString2[BookNumber[(Player number of (Triggering player))]]
        • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Clicked dialog button) Equal to BookOption3[(Player number of (Triggering player))]
        • Then - Actions
          • Dialog - Hide BookDialog[(Player number of (Triggering player))] for (Triggering player)
          • Game - Display to (Player group((Triggering player))) the text: BookString3[BookNumber[(Player number of (Triggering player))]]
        • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Clicked dialog button) Equal to BookQuit[(Player number of (Triggering player))]
        • Then - Actions
          • Dialog - Hide BookDialog[(Player number of (Triggering player))] for (Triggering player)
        • Else - Actions
      • Dialog - Clear BookDialog[(Player number of (Triggering player))]


There is one final trigger that sets up the books and the strings to be read to the players, but it is not needed.
 
V

velnias

New Member
Reaction score
13
i think u need change like this:

Code: 
Book System
    Events
        Unit - A unit Uses an item
    Conditions
    Actions
        For each (Integer A) from 1 to 10, do (Actions)
            Loop - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Item-type of (Item being manipulated)) Equal to Book[(Integral A)]
                    Then - Actions
                        Set BookNumber[(Player number of (Owner of (Triggering unit)))] = (Integer A) 
                    Else - Actions
<here u need one more IF>
        Dialog - Hide BookDialog for (Owner of (Triggering unit)) 
        Dialog - Change the title of BookDialog to (Name of (Item being manipulated)) 
        Dialog - Create a dialog button for BookDialog labelled Page 1 
        Set BookOption1[(Player number of (Triggering player))] = (Last created dialog Button) 
        Dialog - Create a dialog button for BookDialog labelled Page 2 
        Set BookOption2[(Player number of (Triggering player))] = (Last created dialog Button) 
        Dialog - Create a dialog button for BookDialog labelled Page 3 
        Set BookOption3[(Player number of (Triggering player))] = (Last created dialog Button) 
        Dialog - Create a dialog button for BookDialog labelled Exit 
        Set BookQuit[(Player number of (Triggering player))] = (Last created dialog Button) 
        Dialog - Show BookDialog for (Owner of (Triggering unit))

Code: 
Select Page
    Events
        Dialog - A dialog button is clicked for BookDialog
    Conditions
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Clicked dialog button) Equal to BookOption1[(Player number of (Triggering player))]
            Then - Actions
                Dialog - Hide BookDialog for (Triggering player)
                Game - Display to (Player group((Triggering player))) the text: BookString1[BookNumber[(Player number of (Triggering player))]] 
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Clicked dialog button) Equal to BookOption2[(Player number of (Triggering player))]
            Then - Actions
                Dialog - Hide BookDialog for (Triggering player)
                Game - Display to (Player group((Triggering player))) the text: BookString2[BookNumber[(Player number of (Triggering player))]] 
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Clicked dialog button) Equal to BookOption3[(Player number of (Triggering player))]
            Then - Actions
                Dialog - Hide BookDialog for (Triggering player)
                Game - Display to (Player group((Triggering player))) the text: BookString3[BookNumber[(Player number of (Triggering player))]] 
            Else - Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Clicked dialog button) Equal to BookQuit[(Player number of (Triggering player))]
            Then - Actions
                Dialog - Hide BookDialog for (Triggering player) 
            Else - Actions
       Dialog - Clear BookDialog
 
HydraRancher

HydraRancher

Truth begins in lies
Reaction score
197
Doctor said:
Who has the courage to bother turn that into WC3 code so its legible?
Click to expand...

Me.

Trigger:
  • Book System
    • Events
      • Unit - A unit Uses an item
    • Conditions
    • Actions
      • For each (Integer A) from 1 to 10, do (Actions)
        • Loop - Actions
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • (Item-type of (Item being manipulated)) Equal to Book[(Integral A)]
            • Then - Actions
              • Set BookNumber[(Player number of (Owner of (Triggering unit)))] = (Integer A)
            • Else - Actions
    • &lt;here u need one more IF&gt;
      • Dialog - Hide BookDialog for (Owner of (Triggering unit))
      • Dialog - Change the title of BookDialog to (Name of (Item being manipulated))
      • Dialog - Create a dialog button for BookDialog labelled Page 1
      • Set BookOption1[(Player number of (Triggering player))] = (Last created dialog Button)
      • Dialog - Create a dialog button for BookDialog labelled Page 2
      • Set BookOption2[(Player number of (Triggering player))] = (Last created dialog Button)
      • Dialog - Create a dialog button for BookDialog labelled Page 3
      • Set BookOption3[(Player number of (Triggering player))] = (Last created dialog Button)
      • Dialog - Create a dialog button for BookDialog labelled Exit
      • Set BookQuit[(Player number of (Triggering player))] = (Last created dialog Button)
      • Dialog - Show BookDialog for (Owner of (Triggering unit))


Trigger:
  • Select Page
    • Events
      • Dialog - A dialog button is clicked for BookDialog
    • Conditions
    • Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Clicked dialog button) Equal to BookOption1[(Player number of (Triggering player))]
        • Then - Actions
          • Dialog - Hide BookDialog for (Triggering player)
          • Game - Display to (Player group((Triggering player))) the text: BookString1[BookNumber[(Player number of (Triggering player))]]
        • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Clicked dialog button) Equal to BookOption2[(Player number of (Triggering player))]
        • Then - Actions
          • Dialog - Hide BookDialog for (Triggering player)
          • Game - Display to (Player group((Triggering player))) the text: BookString2[BookNumber[(Player number of (Triggering player))]]
        • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Clicked dialog button) Equal to BookOption3[(Player number of (Triggering player))]
        • Then - Actions
          • Dialog - Hide BookDialog for (Triggering player)
          • Game - Display to (Player group((Triggering player))) the text: BookString3[BookNumber[(Player number of (Triggering player))]]
        • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Clicked dialog button) Equal to BookQuit[(Player number of (Triggering player))]
        • Then - Actions
          • Dialog - Hide BookDialog for (Triggering player)
        • Else - Actions
      • Dialog - Clear BookDialog


Why does he need an extra if?

by the way for the last trigger do this:
Trigger:
  • Select Page
    • Events
      • Dialog - A dialog button is clicked for BookDialog
    • Conditions
    • Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Clicked dialog button) Equal to BookOption1[(Player number of (Triggering player))]
        • Then - Actions
          • Game - Display to (Player group((Triggering player))) the text: BookString1[BookNumber[(Player number of (Triggering player))]]
        • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Clicked dialog button) Equal to BookOption2[(Player number of (Triggering player))]
        • Then - Actions
          • Game - Display to (Player group((Triggering player))) the text: BookString2[BookNumber[(Player number of (Triggering player))]]
        • Else - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Clicked dialog button) Equal to BookOption3[(Player number of (Triggering player))]
        • Then - Actions
          • Game - Display to (Player group((Triggering player))) the text: BookString3[BookNumber[(Player number of (Triggering player))]]
        • Else - Actions
      • Dialog - Hide BookDialog for (Triggering player)
      • Dialog - Clear BookDialog

shortens it alot
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • WildTurkey WildTurkey:
    is there a stephen green in the house?
     +1
  • The Helper The Helper:
    What is up WildTurkey?
  • The Helper The Helper:
    Looks like Google fixed whatever mistake that made the recipes on the site go crazy and we are no longer trending towards a recipe site lol - I don't care though because it motivated me to spend alot of time on the site improving it and at least now the content people are looking at is not stupid and embarrassing like it was when I first got back into this like 5 years ago.
  • The Helper The Helper:
    Plus - I have a pretty bad ass recipe collection now! That section of the site is 10 thousand times better than it was before
  • The Helper The Helper:
    We now have a web designer at my job. A legit talented professional! I am going to get him to redesign the site theme. It is time.
  • Varine Varine:
    I got one more day of community service and then I'm free from this nonsense! I polished a cop car today for a funeral or something I guess
  • Varine Varine:
    They also were digging threw old shit at the sheriff's office and I tried to get them to give me the old electronic stuff, but they said no. They can't give it to people because they might use it to impersonate a cop or break into their network or some shit? idk but it was a shame to see them take a whole bunch of radios and shit to get shredded and landfilled
  • The Helper The Helper:
    whatever at least you are free
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?

      The Helper Discord

      Members online

      No members online now.
      Online now:
      344 (members: 2, guests: 342)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top