Im Making a gold fountain! plz help

[Exuro.]

Hey again again

I have placed a Gold Mine on my map and removed all the abilities and stuff on it!

then i placed a region around it!

Now i want a trigger to give 1 gold every second of game time to owners of the units standing in that region!

how do i do that?

thanks

 

[The Undaddy]

E: Every 1 second
A: Custom script: set bj_wantDestroyGroup = true*
   Pick every unit in the region and do:
   Add [U]Owner of picked unit[/U] to [PlayerGroupVariable]
   Pick every player in [PlayerGroupVariable] and do:
   Add 1 gold to [U]picked player[/U]**
   Clear [PlayerGroupVariable]

*Idk if this is the right syntax (case sensitivity)
**This may be (Set property of some player to (Property of some player + 1))

Obviously [PlayerGroupVariable] is a Player Group variable

 

[Sirroelivan]

Do you want to give gold for every unit, or only if there is 1 or more units?

I presume just if the player has at least one unit in the region?

Gold Fountain
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        For each (Integer A) from 1 to 12, do (Actions)
            Loop - Actions
                Set ug = (Units in <Gold Region> owned by (Player((Integer A))))
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Number of units in ug) Greater than 0
                    Then - Actions
                        Player - Add 1 to (Player((Integer A))) Current gold
                    Else - Actions
                        Do nothing
                Custom script:   call DestroyGroup(udg_ug)

"ug" is a unit-group variable.

 

[Exuro.]

1 unit is all they have!

there are 3 teams, and their all trying to capture this gold fountain! so it doesnt matter who stands in it, every unit in the region shall recieve 1g per second

 

[leo120120]

Maybe this works...

Gold Trigger
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
        Unit Group - Pick every unit in (Units in Rect 000 <gen>) and do (Player - Add 1 to (Owner of (Picked unit)) Current gold)

But it will give 1 of gold to all the units of the player in that area, not only one per player.

EDIT: It will work but i think that it will leak.

 

[The Undaddy]

EDIT: Can't delete this post?

 

[Sirroelivan]

leo's trigger does leak though.

 

[Exuro.]

ye Leo, think your trigger might do the trick! thanks a ton to everyone!

Best fu***** forum this is

 

[Renendaru]

Gold Trigger
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
     Set TempPoint = Rect 000   
     Unit Group - Pick every unit in TempPoint and do (Player - Add 1 to (Owner of (Picked unit)) Current gold)
     Custom Script: call RemoveLocation (udg_TempPoint)

Here's the leakless version.

 

[leo120120]

Now i think you should worry about if it leak or not, i recomend to use Leak Checker v3

EDIT: The rendendaru trigger will work

 

[Renendaru]

I posted a trigger that fixed the location leak.

 

[The Undaddy]

Gold Trigger
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions
     Set TempPoint = Rect 000   
     Unit Group - Pick every unit in TempPoint and do (Player - Add 1 to (Owner of (Picked unit)) Current gold)
     Custom Script: call RemoveLocation (udg_TempPoint)

Here's the leakless version.

Rect isn't point man,the unit group is leaking

 

[Exuro.]

i never fixed leaks in my maps as im new and i get to confused heh!
but on the other hand, i never had problems with leaks! or dont think i have heh!

isent leaks only important to worry about if u got lots of stuff going on in a big map?

 

[Farplane]

i never fixed leaks in my maps as im new and i get to confused heh!
but on the other hand, i never had problems with leaks! or dont think i have heh!

isent leaks only important to worry about if u got lots of stuff going on in a big map?

There are many aspects to decide whether or not a leak is minor.
For instance, if you have map that generally lasts 1 1/2 to 2 hours, a few little leaks will add up. Also, triggers that happen consistantly with a set time
(Every 1 second) should be watched out for.

 

[Renendaru]

Gold Trigger
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions   
     Unit Group - Pick every unit in Rect 000 <gen> and do (Player - Add 1 to (Owner of (Picked unit)) Current gold)
     Set TempGroup = (Picked Unit)
     Custom Script: call DestroyGroup (udg_TempGroup)

That look good now?

 

[The Undaddy]

Gold Trigger
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions   
     Unit Group - Pick every unit in Rect 000 <gen> and do (Player - Add 1 to (Owner of (Picked unit)) Current gold)
     Set TempGroup = (Picked Unit)
     Custom Script: call DestroyGroup (udg_TempGroup)

That look good now?

You're joking right? Right?

 

[Renendaru]

Yea, I'm not thinking right. I'm not good at simple triggers... I like having loops and such.

 

[The Undaddy]

Yea, I'm not thinking right. I'm not good at simple triggers... I like having loops and such.

Ye
Apparently no one wants to post the leak-proof version,so...

Gold Trigger
    Events
        Time - Every 1.00 seconds of game time
    Conditions
    Actions   
     Custom script - set bj_wantDestroyGroup = true
     Unit Group - Pick every unit in Rect 000 <gen> and do (Player - Add 1 to (Owner of (Picked unit)) Current gold)

In case ne1 needs it

 

[Cheesy]

     Custom script - set bj_wantDestroyGroup [B]-[/B] true

Should be:

Custom Script: set bj_wantDestroyGroup = true

(The - // = )