Item System is not working

[AlicanC]

I am working on an Item System. I want to limit items:
-Maximum 2 rings
-Maximum 1 boot
-Maximum 1 helmet etc.
My items names are like this "Ring of AlicanC (Level 1 Ring)", "Frozen Sword (Level 2 Weapon)"
So I make last 4 letter of my items (without ")") an item code like "Ring", "apon", "oots"; but this doesn't work.

Check Items
    Events
        Unit - A unit Acquires an item
        Unit - A unit Uses an item
        Unit - A unit Loses an item
        Unit - A unit Pawns an item (to shop)
    Conditions
    Actions
        Set Last_Unit = (Triggering unit)
        Set Last_Player = (Owner of Last_Unit)
        For each (Integer A) from 1 to 6, do (Actions)
            Loop - Actions
                Set IS_Last_ItemName = (Name of (Item carried by Last_Unit in slot (Integer A)))
                Set IS_Last_ItemCode = (Substring(IS_Last_ItemName, ((Length of IS_Last_ItemName) - 6[B](I tried "-5" and "-4" too!)[/B]), ((Length of IS_Last_ItemName) - 1)))
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        IS_Last_ItemCode Equal to Ring
                    Then - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                IS_Last_RingCount Equal to 2
                            Then - Actions
                                Hero - Drop the item from slot (Integer A) of Last_Unit
                                Game - Display to (All players) for 5.00 seconds the text: |cffff3300!Message|...
                            Else - Actions
                                Set IS_Last_RingCount = (IS_Last_RingCount + 1)
                    Else - Actions
                        Do nothing

I need help

 

[Dustin11]

So specificaly what part of the trigger dosn't work?

 

[AlicanC]

It checks all items; but it doesn't detect rings.

 

[Dustin11]

try not having else actions try re making it without the else action see if that can do anything, becuase you can't leave the else action blank.

 

[AlicanC]

I have never had a problem with empty elses. Actually they are not empty. They have "Do Nothing".

 

[Dustin11]

hmm well i would try it but it's probably not the probelm give me a sec to think

 

[Omni]

put ring in front of all rings like ring of omni
then try: "substring 1,4 equal to ring" as a condition to detect if its a rnig

 

[AlicanC]

I will hardcode it by checking the Item-Type.

Edit:
It works now; but I have to add every Ring I make to this trigger:

Rings
    Events
        Unit - A unit Acquires an item
    Conditions
        Or - Any (Conditions) are true
            Conditions
                (Item-type of (Item being manipulated)) Equal to Protection Ring (Level 1 |cff20a000Ring|r)
                (Item-type of (Item being manipulated)) Equal to Protection Ring (Level 2 |cff20a000Ring|r)
                (Item-type of (Item being manipulated)) Equal to Protection Ring (Level 3 |cff20a000Ring|r)
                (Item-type of (Item being manipulated)) Equal to Regeneration Ring (Level 1 |cff20a000Ring|r)
                (Item-type of (Item being manipulated)) Equal to Regeneration Ring (Level 2 |cff20a000Ring|r)
                (Item-type of (Item being manipulated)) Equal to Superiority Ring (Level 1 |cff20a000Ring|r)
                (Item-type of (Item being manipulated)) Equal to Superiority Ring (Level 2 |cff20a000Ring|r)
    Actions
        Set Last_Unit = (Hero manipulating item)
        Set IS_Last_ItemCount = 0
        For each (Integer A) from 1 to 6, do (Actions)
            Loop - Actions
                Set IS_Last_ItemType = (Item-type of (Item carried by Last_Unit in slot (Integer A)))
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        Or - Any (Conditions) are true
                            Conditions
                                IS_Last_ItemType Equal to Protection Ring (Level 1 |cff20a000Ring|r)
                                IS_Last_ItemType Equal to Protection Ring (Level 2 |cff20a000Ring|r)
                                IS_Last_ItemType Equal to Protection Ring (Level 3 |cff20a000Ring|r)
                                IS_Last_ItemType Equal to Regeneration Ring (Level 1 |cff20a000Ring|r)
                                IS_Last_ItemType Equal to Regeneration Ring (Level 2 |cff20a000Ring|r)
                                IS_Last_ItemType Equal to Superiority Ring (Level 1 |cff20a000Ring|r)
                                IS_Last_ItemType Equal to Superiority Ring (Level 2 |cff20a000Ring|r)
                    Then - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                IS_Last_ItemCount Equal to 2
                            Then - Actions
                                Hero - Drop the item from slot (Integer A) of Last_Unit
                                Game - Display to (All players) for 5.00 seconds the text: |cffff3300!Message|...
                            Else - Actions
                                Set IS_Last_ItemCount = (IS_Last_ItemCount + 1)
                    Else - Actions
                        Do nothing