Itemcrafting Skill

H

Heavy-Gear

New Member
Reaction score
7
For my game Island of Souls I've been working on the itemcrafting trigger. There are no syntax errors etc. but at the moment, regardless of whether you have the correct components, "ERROR: Missing Requirements!" Is displayed whenever you try to make something.

JASS:
scope CraftTrigger
//==========================================================================
globals
    
    // Toolcraft Abilities
    private constant integer SID_BUILDARROW = 'A00E'
    private constant integer SID_BUILDAWARD = 'A00J'
    private constant integer SID_BUILDFIREKIT = 'A005'
    private constant integer SID_BUILDFBLADE = 'A00F'
    private constant integer SID_BUILDHSTONE = 'A00K'
    private constant integer SID_BUILDKNIFE = 'A00G'
    private constant integer SID_BUILDSWARD = 'A00H'
    private constant integer SID_BUILDSHARPSTONE = 'A007'
    private constant integer SID_BUILDSFBLADE = 'A00I'   
    // Toolcraft Items
    private constant integer IID_ARROW = 'I00D'
    private constant integer IID_AWARD = 'I00E'
    private constant integer IID_FIREKIT = 'I00A'
    private constant integer IID_FBLADE = 'I007'
    private constant integer IID_HSTONE = 'I005'
    private constant integer IID_KNIFE = 'I006'
    private constant integer IID_SWARD = 'I00C'
    private constant integer IID_SHARPSTONE = 'I009'
    private constant integer IID_SFBLADE = 'I008'
    
    
    
endglobals
//==========================================================================
private function Actions takes nothing returns nothing

local integer array RawItem
local integer array RawItemIID
local integer array RawItemNeeded
                       
local unit C = GetSpellAbilityUnit()
local integer I
local integer c = 0                
local integer t = 0
local integer i = 0
local integer j = 0
      
local integer stones = 0                  
local integer vines = 0                   
local integer flint = 0                   
local integer largebones = 0              
local integer shells = 0                  
local integer smallbones = 0              
local integer soulstones = 0              
local integer sticks = 0                  
local integer flintblades = 0             
local integer strongflintblades = 0       
local integer merrentill = 0              
local integer sungrass = 0                
local integer gnollsleaf = 0              
local integer avantoe = 0                 
local integer gnomeswood = 0
local integer knifereq = 0                 
local integer hammerreq = 0

if GetSpellAbilityId() == SID_BUILDARROW then
    set sticks = 1
    set shells = 1
    set knifereq = 1
    set I = IID_ARROW
    set t = 3
endif 
if GetSpellAbilityId() == SID_BUILDAWARD then 
    set sticks = 1
    set stones = 1
    set vines = 1
    set flint = 1
    set soulstones = 1
    set knifereq = 1
    set I = IID_AWARD
    set t = 6
endif 
if GetSpellAbilityId() == SID_BUILDFIREKIT then 
    set sticks = 1
    set stones = 2
    set knifereq = 1
    set I = IID_FIREKIT
    set t = 4
endif 
if GetSpellAbilityId() == SID_BUILDFBLADE then 
    set flint = 1
    set hammerreq = 1
    set I = IID_FBLADE
    set t = 2
endif 
if GetSpellAbilityId() == SID_BUILDHSTONE then 
    set stones = 2
    set I = IID_HSTONE
    set t = 2
endif 
if GetSpellAbilityId() == SID_BUILDKNIFE then 
    set flintblades = 1
    set vines = 1
    set I = IID_KNIFE
    set t = 2
endif 
if GetSpellAbilityId() == SID_BUILDSWARD then 
    set sticks = 1
    set stones = 1
    set vines = 1
    set flint = 1
    set soulstones = 1
    set knifereq = 1
    set I = IID_SWARD
    set t = 6
endif 
if GetSpellAbilityId() == SID_BUILDSHARPSTONE then 
    set stones = 1
    set knifereq = 1
    set I = IID_SHARPSTONE
    set t = 2
endif 
if GetSpellAbilityId() == SID_BUILDSFBLADE then 
    set flint = 1
    set hammerreq = 1
    set I = IID_SFBLADE
    set t = 2    
endif

set RawItemIID[0]  = 'I002' //Stone                   
set RawItemIID[1]  = 'I000' //Vine                    
set RawItemIID[2]  = 'I00B' //Flint                    
set RawItemIID[3]  = 'I00G' //LargeBone               
set RawItemIID[4]  = 'I003' //Shell                   
set RawItemIID[5]  = 'I00F' //SmallBone               
set RawItemIID[6]  = 'I004' //SoulStone               
set RawItemIID[7]  = 'I001' //Stick                   
set RawItemIID[8]  = 'I007' //FlintBlade              
set RawItemIID[9]  = 'I008' //StrongFlintBlade        
set RawItemIID[10] = 'I00J' //Merrentill     
set RawItemIID[11] = 'I00K' //Sungrass       
set RawItemIID[12] = 'I00L' //Gnollsleaf     
set RawItemIID[13] = 'I00M' //Avantoe        
set RawItemIID[14] = 'I00N' //Gnomeswood
set RawItemIID[15] = 'I006' //Knife        
set RawItemIID[16] = 'I005' //Hammerstone      
                           
set RawItemNeeded[0]  = stones
set RawItemNeeded[1]  = vines
set RawItemNeeded[2]  = flint
set RawItemNeeded[3]  = largebones
set RawItemNeeded[4]  = shells
set RawItemNeeded[5]  = smallbones
set RawItemNeeded[6]  = soulstones
set RawItemNeeded[7]  = sticks
set RawItemNeeded[8]  = flintblades
set RawItemNeeded[9]  = strongflintblades
set RawItemNeeded[10] = merrentill
set RawItemNeeded[11] = sungrass
set RawItemNeeded[12] = gnollsleaf
set RawItemNeeded[13] = avantoe
set RawItemNeeded[14] = gnomeswood
set RawItemNeeded[15] = knifereq
set RawItemNeeded[16] = hammerreq

loop
exitwhen i >= 5   //loops inventory slots     
    loop
        exitwhen j >= 16  //loops all raw item types  
        if GetItemTypeId(UnitItemInSlot(C, i)) == RawItemIID[j] then  
            set RawItem[j] = RawItem[j] + 1 
        endif  
        if RawItem[j] == RawItemNeeded[j] and RawItemNeeded[j] != 0 then  //checks if there is enough of that item
            set c = c + 1 
        endif
        set j = j + 1     
    endloop        
set i = i + 1
endloop

set i = 0
set j = 0

if c == t then    
    loop
    exitwhen i >= 14 //note: this loop only removes up to knife/hammerstone and not including
        loop
            exitwhen j &gt;= RawItemNeeded<i>
            call UnitRemoveItem(C, GetItemOfTypeFromUnitBJ(C, RawItem<i>))
            set j = j + 1
        endloop
    set i = i + 1
    endloop
    
    call UnitAddItem(C, CreateItem(I, GetUnitX(C), GetUnitY(C)))
else
    call DisplayTimedTextToPlayer(GetOwningPlayer(C), 0, 0, 10, &quot;ERROR: Missing requirements!&quot;)
endif

endfunction

//==========================================================================
private function Conditions takes nothing returns boolean
    return GetSpellAbilityId() == SID_BUILDARROW or GetSpellAbilityId() ==  SID_BUILDAWARD or GetSpellAbilityId() ==  SID_BUILDFIREKIT or GetSpellAbilityId() ==  SID_BUILDFBLADE or GetSpellAbilityId() ==  SID_BUILDHSTONE or GetSpellAbilityId() == SID_BUILDKNIFE or GetSpellAbilityId() == SID_BUILDSWARD or GetSpellAbilityId() == SID_BUILDSHARPSTONE or GetSpellAbilityId() == SID_BUILDSFBLADE
endfunction

public function InitTrig takes nothing returns nothing
local trigger trigg = CreateTrigger()
local integer i = 0
loop
    exitwhen i &gt;= 11
        call TriggerRegisterPlayerUnitEvent(trigg, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
        set i = i + 1
    endloop
    call TriggerAddCondition(trigg, Condition(function Conditions ) )
    call TriggerAddAction(trigg, function Actions )
endfunction
//==========================================================================
endscope</i></i>


Any help appreciated :)
 
Viikuna

Viikuna

No Marlo no game.
Reaction score
265
If you get that 'false components' -message every time, then
JASS:
if c == t then
this returns false. Use
JASS:
BJDebugMsg(I2S(c)) and BJDebugMsg(I2S(t))
and check those variables. Allways use BJDebugMsg its really usefull and one of those BJ -functions you should not try to avoid.

I hope you can fix it.
 
H

Heavy-Gear

New Member
Reaction score
7
Hmm.. for the life of me, I can't see what's wrong with it. The total number of components seems to be working fine but the nested loops are going haywire :p

Has anyone had a chance to have a look at it?
 
Tukki

Tukki

is Skeleton Pirate.
Reaction score
29
Okey, so I took a look at the code and most of it was correct - but the things that were wrong screwed the whole code.
Some notes;

1: The variable "j" is used by the loop which is looped 6 times - but it was not reset - therefor only 1 item was checked.
JASS:
loop
exitwhen i &gt;= 5   //loops inventory slots
    loop
        exitwhen j &gt;= 16  //loops all raw item types
        if GetItemTypeId(UnitItemInSlot(C, i)) == RawItemIID[j] then  
            set RawItem[j] = RawItem[j] + 1 
        endif  
        if RawItem[j] == RawItemNeeded[j] and RawItemNeeded[j] != 0 then  //checks if there is enough of that item
            set c = c + 1 
        endif
        set j = j + 1     
    endloop   
set j = 0 // this was forgotten
set i = i + 1
endloop

2: And some of your "if/then/else" conditions were scary..
JASS:
        if GetItemTypeId(UnitItemInSlot(C, i)) == RawItemIID[j] then  
            set RawItem[j] = RawItem[j] + 1 
        endif  
        if RawItem[j] == RawItemNeeded[j] and RawItemNeeded[j] != 0 then  //checks if there is enough of that item
            set c = c + 1 
        endif
so I replaced them with another one (2)
JASS:
        if GetItemTypeId(UnitItemInSlot(C, i)) == RawItemIID[j] then  
            set Item =  UnitItemInSlot(C, i)
            if RawItemNeeded[j] &gt; 0 and GetItemTypeId(Item) == RawItemIID[j] then
                set DestroyItems<i> = Item
                set RawItemNeeded[j] = RawItemNeeded[j] - 1
                set c = c + 1
            endif
        endif</i>


3 and 4: Your "Remove Item" loop didn't work correctly - so it has also been fixed. And there are actually 6 item slots not 5.
But everything else was okey - only a small effiency (I hope) improvement by using textmacros to set your variables so you don't do it every time to run the trigger.

Here's the trigger script if you would like to have it.

JASS:
//! textmacro SetCraftTriggerData

set RawItemIID[0]  = &#039;I002&#039; //Stone                   
set RawItemIID[1]  = &#039;I000&#039; //Vine                    
set RawItemIID[2]  = &#039;I00B&#039; //Flint                    
set RawItemIID[3]  = &#039;I00G&#039; //LargeBone               
set RawItemIID[4]  = &#039;I003&#039; //Shell                   
set RawItemIID[5]  = &#039;I00F&#039; //SmallBone               
set RawItemIID[6]  = &#039;I004&#039; //SoulStone               
set RawItemIID[7]  = &#039;I001&#039; //Stick                   
set RawItemIID[8]  = &#039;I007&#039; //FlintBlade              
set RawItemIID[9]  = &#039;I008&#039; //StrongFlintBlade        
set RawItemIID[10] = &#039;I00J&#039; //Merrentill     
set RawItemIID[11] = &#039;I00K&#039; //Sungrass       
set RawItemIID[12] = &#039;I00L&#039; //Gnollsleaf     
set RawItemIID[13] = &#039;I00M&#039; //Avantoe        
set RawItemIID[14] = &#039;I00N&#039; //Gnomeswood
set RawItemIID[15] = &#039;I006&#039; //Knife        
set RawItemIID[16] = &#039;I005&#039; //Hammerstone   

//! endtextmacro

scope CraftTrigger
//==========================================================================
globals
    
    // Toolcraft Abilities
    private constant integer SID_BUILDARROW = &#039;A00E&#039;
    private constant integer SID_BUILDAWARD = &#039;A00J&#039;
    private constant integer SID_BUILDFIREKIT = &#039;A005&#039;
    private constant integer SID_BUILDFBLADE = &#039;A00F&#039;
    private constant integer SID_BUILDHSTONE = &#039;A00K&#039;
    private constant integer SID_BUILDKNIFE = &#039;A00G&#039;
    private constant integer SID_BUILDSWARD = &#039;A00H&#039;
    private constant integer SID_BUILDSHARPSTONE = &#039;A007&#039;
    private constant integer SID_BUILDSFBLADE = &#039;A00I&#039;   
    // Toolcraft Items
    private constant integer IID_ARROW = &#039;I00D&#039;
    private constant integer IID_AWARD = &#039;I00E&#039;
    private constant integer IID_FIREKIT = &#039;I00A&#039;
    private constant integer IID_FBLADE = &#039;I007&#039;
    private constant integer IID_HSTONE = &#039;I005&#039;
    private constant integer IID_KNIFE = &#039;I006&#039;
    private constant integer IID_SWARD = &#039;I00C&#039;
    private constant integer IID_SHARPSTONE = &#039;I009&#039;
    private constant integer IID_SFBLADE = &#039;I008&#039;
    
    private integer array RawItemIID
    
endglobals
//==========================================================================
private function Actions takes nothing returns nothing
local item Item 
local item    array DestroyItems

local integer array RawItem
local integer array RawItemNeeded
                       
local unit C = GetSpellAbilityUnit()

local integer I
local integer c = 0             
local integer t = 0    
local integer i = 0   
local integer j = 0    
      
local integer stones = 0                    
local integer vines = 0                     
local integer flint = 0                      
local integer largebones = 0              
local integer shells = 0                    
local integer smallbones = 0                
local integer soulstones = 0                
local integer sticks = 0                     
local integer flintblades = 0              
local integer strongflintblades = 0          
local integer merrentill = 0                 
local integer sungrass = 0                
local integer gnollsleaf = 0                 
local integer avantoe = 0                   
local integer gnomeswood = 0    
local integer knifereq = 0                     
local integer hammerreq = 0    

if GetSpellAbilityId() == SID_BUILDARROW then
    set sticks = 1
    set shells = 1
    set knifereq = 1
    set I = IID_ARROW
    set t = 3
endif 
if GetSpellAbilityId() == SID_BUILDAWARD then 
    set sticks = 1
    set stones = 1
    set vines = 1
    set flint = 1
    set soulstones = 1
    set knifereq = 1
    set I = IID_AWARD
    set t = 6
endif 
if GetSpellAbilityId() == SID_BUILDFIREKIT then 
    set sticks = 1
    set stones = 2
    set knifereq = 1
    set I = IID_FIREKIT
    set t = 4
endif 
if GetSpellAbilityId() == SID_BUILDFBLADE then 
    set flint = 1
    set hammerreq = 1
    set I = IID_FBLADE
    set t = 2
endif 
if GetSpellAbilityId() == SID_BUILDHSTONE then 
    set stones = 2
    set I = IID_HSTONE
    set t = 2
endif 
if GetSpellAbilityId() == SID_BUILDKNIFE then 
    set flintblades = 1
    set vines = 1
    set I = IID_KNIFE
    set t = 2
endif 
if GetSpellAbilityId() == SID_BUILDSWARD then 
    set sticks = 1
    set stones = 1
    set vines = 1
    set flint = 1
    set soulstones = 1
    set knifereq = 1
    set I = IID_SWARD
    set t = 6
endif 
if GetSpellAbilityId() == SID_BUILDSHARPSTONE then 
    set stones = 1
    set knifereq = 1
    set I = IID_SHARPSTONE
    set t = 2
endif 
if GetSpellAbilityId() == SID_BUILDSFBLADE then 
    set flint = 1
    set hammerreq = 1
    set I = IID_SFBLADE
    set t = 2    
endif   
                           
set RawItemNeeded[0]  = stones
set RawItemNeeded[1]  = vines
set RawItemNeeded[2]  = flint
set RawItemNeeded[3]  = largebones
set RawItemNeeded[4]  = shells
set RawItemNeeded[5]  = smallbones
set RawItemNeeded[6]  = soulstones
set RawItemNeeded[7]  = sticks
set RawItemNeeded[8]  = flintblades
set RawItemNeeded[9]  = strongflintblades
set RawItemNeeded[10] = merrentill
set RawItemNeeded[11] = sungrass
set RawItemNeeded[12] = gnollsleaf
set RawItemNeeded[13] = avantoe
set RawItemNeeded[14] = gnomeswood
set RawItemNeeded[15] = knifereq
set RawItemNeeded[16] = hammerreq

loop
exitwhen i &gt; 5   //loops inventory slots (there are actually 6 of them <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite7" alt=":p" title="Stick Out Tongue    :p" loading="lazy" data-shortname=":p" />)   
  
    loop
        exitwhen j &gt;= 16  //loops all raw item types (with the correct conditions)
        if GetItemTypeId(UnitItemInSlot(C, i)) == RawItemIID[j] then  
            set Item =  UnitItemInSlot(C, i)
            if RawItemNeeded[j] &gt; 0 and GetItemTypeId(Item) == RawItemIID[j] then
                set DestroyItems<i> = Item
                set RawItemNeeded[j] = RawItemNeeded[j] - 1
                set c = c + 1
            endif
        endif
        set j = j + 1     
    endloop
set j = 0
set i = i + 1
endloop

set i = 0
set j = 0

if c == t then    
    loop
    exitwhen i &gt; 5 // destroys all items in the DestroyItems array
        call RemoveItem(DestroyItems<i>)
    set i = i + 1
    endloop
    
    call UnitAddItem(C, CreateItem(I, GetUnitX(C), GetUnitY(C)))
else
    call DisplayTimedTextToPlayer(GetOwningPlayer(C), 0.52, -1, 10, &quot;|CFFFF0000ERROR: Missing requirements!|r&quot;) // replaced X/Y values and added |CFFFF0000 &lt;- red to the string
endif

endfunction

//==========================================================================
private function Conditions takes nothing returns boolean
    return GetSpellAbilityId() == SID_BUILDARROW or GetSpellAbilityId() ==  SID_BUILDAWARD or GetSpellAbilityId() ==  SID_BUILDFIREKIT or GetSpellAbilityId() ==  SID_BUILDFBLADE or GetSpellAbilityId() ==  SID_BUILDHSTONE or GetSpellAbilityId() == SID_BUILDKNIFE or GetSpellAbilityId() == SID_BUILDSWARD or GetSpellAbilityId() == SID_BUILDSHARPSTONE or GetSpellAbilityId() == SID_BUILDSFBLADE
endfunction

public function InitTrig takes nothing returns nothing
local trigger trigg = CreateTrigger()
local integer i = 0
loop
    exitwhen i &gt;= 11
        call TriggerRegisterPlayerUnitEvent(trigg, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
        set i = i + 1
    endloop
    call TriggerAddCondition(trigg, Condition(function Conditions ) )
    call TriggerAddAction(trigg, function Actions )
    //! runtextmacro SetCraftTriggerData()
endfunction
//==========================================================================
endscope</i></i>


Hope it helped :)
 
H

Heavy-Gear

New Member
Reaction score
7
Yay!

Not reseting the 'j' looked like the major error. Thanks for all your help, it works great! The only thing I had to change was that it shouldn't remove knives/hammerstones but other than that it's perfect.
 
You must log in or register to reply here.
General chit-chat
Help Users

      The Helper Discord

      Members online

      Online now:
      202 (members: 3, guests: 199)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top