JASS dash spell Inifinite Loops?

W

wraithseeker

Tired.
Reaction score
122
Now the problem is , when the caster is charging to the target , units don't get knocked back but the rest of the spell is fine.

EDIT: Code Indented

JASS:
scope Dash initializer Init

globals
    private constant integer SPELL = 'A003'
    private constant real TIME = 0.03
    private constant real SPEED = 800
    private constant real KnockDistance = 400
    private boolexpr Check
endglobals

private function DISTANCE takes integer level returns integer
    return level * 250
endfunction

private struct data
    unit caster
    unit target
    real cos
    real sin
    real angle
    real distance
    timer t
    timer h
    group g
    real CreepDistance

static method create takes nothing returns data
    local data d = data.allocate()
    set d.caster = GetTriggerUnit()
    set d.target = GetSpellTargetUnit()
    set d.t = NewTimer()
    set d.h = NewTimer()
    set d.distance = DISTANCE(GetUnitAbilityLevel(d.caster,SPELL))
    set d.g = CreateGroup()
    set d.CreepDistance = KnockDistance
    return d
endmethod

method onDestroy takes nothing returns nothing
    call ReleaseTimer(.h)
endmethod
endstruct

private function Conditions takes nothing returns boolean
    return GetSpellAbilityId() == SPELL
endfunction

private function KnockCheck takes nothing returns boolean
local data d
    return GetFilterUnit() != d.caster and GetFilterUnit() != d.target
endfunction

private function Knock takes nothing returns nothing
    local data d = data(GetTimerData(GetExpiredTimer()))
    local real cx = GetUnitX(d.caster)
    local real cy = GetUnitY(d.caster)
    local real tx = GetUnitX(d.target)
    local real ty = GetUnitY(d.target)
    local real angle = Atan2(ty-cy,tx-cx)
    local real sin = Sin(angle)
    local real cos = Cos(angle)
    set tx = tx + cos * TIME * SPEED
    set ty = ty + sin * TIME * SPEED
    call SetUnitX(d.target,tx)
    call SetUnitY(d.target,ty)
    set d.distance = d.distance - TIME * SPEED
    if d.distance <= 0 then
        call d.destroy()
    endif
endfunction

private function Move takes nothing returns nothing
    local data d = data(GetTimerData(GetExpiredTimer()))
    local real cx = GetUnitX(d.caster)
    local real cy = GetUnitY(d.caster)
    local real tx = GetUnitX(d.target)
    local real ty = GetUnitY(d.target)
    local real angle = Atan2(ty-cy,tx-cx)
    local real sin = Sin(angle)
    local real cos = Cos(angle)
    local unit u
    local real x
    local real y
    local real angles
    local real sins
    local real coss
    set cx = cx + cos * TIME * SPEED
    set cy = cy + sin * TIME * SPEED
    call SetUnitX(d.caster,cx)
    call SetUnitY(d.caster,cy)
    call GroupEnumUnitsInRange(d.g,cx,cy,180,Check)
    loop
        set u = FirstOfGroup(d.g)
    exitwhen u == null
        set x = GetUnitX(u)
        set y = GetUnitY(u)
        set angles = Atan2(y-cy,x-cx)
        set sins = Sin(angles)
        set coss = Cos(angles)
        set x = x + coss * TIME * SPEED
        set y = y + sins * TIME * SPEED
        call SetUnitX(u,x)
        call SetUnitY(u,y)
        set d.CreepDistance = d.CreepDistance - TIME * SPEED
        if d.CreepDistance <= 0 then
            call GroupRemoveUnit(d.g,u)
            call BJDebugMsg("Removing Unit....")
        endif
    endloop
    if SquareRoot((cx - tx) * (cx - tx) + (cy - ty) * (cy - ty)) <= 128 then
        call SetUnitAnimation(d.caster, "attack slam alternate")
        call SetUnitAnimation(d.target, "DEATH")
        call ReleaseTimer(d.t)
        call SetTimerData(d.h,integer (d))
        call TimerStart(d.h,0.03,true,function Knock)
    endif
endfunction

private function Actions takes nothing returns nothing
        local data d = data.create()
    call SetTimerData(d.t,integer (d))
    call TimerStart(d.t,0.03,true,function Move)
endfunction

//===========================================================================
private function Init takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddAction( t, function Actions)
    call TriggerAddCondition(t,Condition(function Conditions))
    set Check = Condition(function KnockCheck)
endfunction

endscope
 
W

wraithseeker

Tired.
Reaction score
122
Ok, it works fine now , but can you explain to me actually how does the whole thing work? I don't really get what you are doing.

Right now I added a speed limit for the ajacent unit that get knocked back which is 400 but right now.. they seem to be teleporting instantly after 400 distance instead of "knocked backed" there.

Spell Code

JASS:
scope Dash initializer Init

globals
    private constant integer SPELL = 'A003'
    private constant real TIME = 0.03
    private constant real SPEED = 800
    private constant real KnockDistance = 400
    private boolexpr Check
    #private data Var#
endglobals

private function DISTANCE takes integer level returns integer
    return level * 250
endfunction

private struct data
    unit caster
    unit target
    real cos
    real sin
    real angle
    real distance
    timer t
    timer h
    group g
    real Distance

static method create takes nothing returns data
    local data d = data.allocate()
    set d.caster = GetTriggerUnit()
    set d.target = GetSpellTargetUnit()
    set d.t = NewTimer()
    set d.h = NewTimer()
    set d.distance = DISTANCE(GetUnitAbilityLevel(d.caster,SPELL))
    set d.g = CreateGroup()
    set d.Distance = 400
    return d
endmethod

method onDestroy takes nothing returns nothing
    call ReleaseTimer(.h)
endmethod
endstruct

private function Conditions takes nothing returns boolean
    return GetSpellAbilityId() == SPELL
endfunction

private function KnockCheck takes nothing returns boolean
local data d = Var
    return GetFilterUnit() != d.caster and GetFilterUnit() != d.target
endfunction

private function Knock takes nothing returns nothing
    local data d = data(GetTimerData(GetExpiredTimer()))
    local real cx = GetUnitX(d.caster)
    local real cy = GetUnitY(d.caster)
    local real tx = GetUnitX(d.target)
    local real ty = GetUnitY(d.target)
    local real angle = Atan2(ty-cy,tx-cx)
    local real sin = Sin(angle)
    local real cos = Cos(angle)
    set tx = tx + cos * TIME * SPEED
    set ty = ty + sin * TIME * SPEED
    call SetUnitX(d.target,tx)
    call SetUnitY(d.target,ty)
    set d.distance = d.distance - TIME * SPEED
    if d.distance <= 0 then
        call d.destroy()
    endif
endfunction

private function Move takes nothing returns nothing
    local data d = data(GetTimerData(GetExpiredTimer()))
    local real cx = GetUnitX(d.caster)
    local real cy = GetUnitY(d.caster)
    local real tx = GetUnitX(d.target)
    local real ty = GetUnitY(d.target)
    local real angle = Atan2(ty-cy,tx-cx)
    local real sin = Sin(angle)
    local real cos = Cos(angle)
    local unit u
    local real x
    local real y
    local real angles
    local real sins
    local real coss
    set cx = cx + cos * TIME * SPEED
    set cy = cy + sin * TIME * SPEED
    call SetUnitPosition(d.caster,cx,cy)
    set Var = d
    call GroupEnumUnitsInRange(d.g,cx,cy,180,Check)
    loop
        set u = FirstOfGroup(d.g)
    exitwhen u == null
        set x = GetUnitX(u)
        set y = GetUnitY(u)
        set angles = Atan2(y-cy,x-cx)
        set sins = Sin(angles)
        set coss = Cos(angles)
        set x = x + coss * TIME * SPEED
        set y = y + sins * TIME * SPEED
        call SetUnitX(u,x)
        call SetUnitY(u,y)
      #  set d.Distance = d.Distance - TIME * SPEED#
      #  if d.Distance <= 0 then
        call BJDebugMsg("removing!")
        call GroupRemoveUnit(d.g,u)
        endif#
    endloop
    if SquareRoot((cx - tx) * (cx - tx) + (cy - ty) * (cy - ty)) <= 128 then
        call SetUnitAnimation(d.caster, "attack slam alternate")
        call SetUnitAnimation(d.target, "DEATH")
        call ReleaseTimer(d.t)
        call SetTimerData(d.h,integer (d))
        call TimerStart(d.h,0.03,true,function Knock)
    endif
endfunction

private function Actions takes nothing returns nothing
        local data d = data.create()
    call SetTimerData(d.t,integer (d))
    call TimerStart(d.t,0.03,true,function Move)
endfunction

//===========================================================================
private function Init takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_SPELL_EFFECT)
    call TriggerAddAction( t, function Actions)
    call TriggerAddCondition(t,Condition(function Conditions))
    set Check = Condition(function KnockCheck)
endfunction

endscope
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though

      The Helper Discord

      Members online

      No members online now.
      Online now:
      94 (members: 3, guests: 91)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top