Leak Variable Conflict?

bumbaclo

New Member
Reaction score
3
So I recently discovered the method of removing leaks from actions and such, but I have a question that I want to ask the more experienced JASSers:

I have this leak-fixed trigger:

Trigger:
  • Trapping
    • Events
      • Time - Every 5.00 seconds of game time
    • Conditions
    • Actions
      • Set Temp_Group = (Units owned by Player 1 (Red) of type Unfathomable Trap)
      • Unit Group - Pick every unit in Temp_Group and do (Actions)
        • Loop - Actions
          • Unit - Cause (Picked unit) to damage (Random unit from (Units within 800.00 of (Position of (Picked unit)) matching (((Owner of (Matching unit)) is in GoodForce) Equal to True))), dealing 1000000000.00 damage of attack type Chaos and damage type Normal
      • Custom script: call DestroyGroup( udg_Temp_Group)


What I'm wondering is suppose I have many other similar triggers, but running on a different periodic timer - say one every 1, 5, and 10 seconds. At every 10 seconds of game time they are all going to fire at exactly the same moment. If thats the case, wouldnt using a global variable (Temp_Group) malfunction in some way since it can't be a temporary group for all the periodic events at the same time?
 

Komaqtion

You can change this now in User CP.
Reaction score
469
Well, all of the triggers fire on a different "thread", and the processor only works on a single thread at a time, meaning that it'll execute the triggers one by one so nothing will get overwritten unless you use a wait somewhere in the trigger ;) (There is a VERY small chance, but it's close to none :p)

And, just for your information, that trigger still leaks 2 handles...
One unit-group and a location ;)
 

bumbaclo

New Member
Reaction score
3
Lol, thanks for telling me, forgot about groups in groups. Is this fixed:

Edit: realized it was completely off, will continue to work on it =p

Also, would it be possible to convert those global variables into local ones to prevent the chance of overlap from happening?
 

jig7c

Stop reading me...-statement
Reaction score
123
the above trigger will not work because
Trigger:
  • Unit Group - Pick every unit in Temp_GroupArray[(Integer A)] and do (Actions)
    • Loop - Actions
      • Unit - Cause (Picked unit) to damage (Random unit from Temp_GroupArray[(Integer A)]), dealing 1000000000.00 damage of attack type Chaos and damage type Normal
      • Custom script: call DestroyGroup( udg_Temp_GroupArray[GetForLoopIndexA()])

is outside of the integer A loop..
 

jig7c

Stop reading me...-statement
Reaction score
123
Also, would it be possible to convert those global variables into local ones to prevent the chance of overlap from happening?

yes

JASS:
private function $name$ takes nothing returns nothing
local group temp_group
local group array temp_grouparray


sorry for double posting
got so caught up in helping the fellow, forgot i was dp (double posting)
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Monovertex Monovertex:
    How are you all? :D
    +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top