Leaking and knockback issues

Karst

Karst

Member
Reaction score
4
Hello everyone, old time World Editor, new poster here.

After years of editing I started reaching the limits of what GUI can do more and more often, so I started to learn JASS.

Now my first JASS spell is nearing completion but there are problems.
The spell will be used by a unit in a game mode I've been working on for about a year. One-on-one games usually last no more than about 10-15 minutes, army sizes are quite small, usually around 4-10 units per player.

1) It leaks. I don't expect it to really cause problems in an actual game since it'll have cooldown, mana cost, and will require two upgrades, but right now it starts to seriously lag after about 25 uses or so.

2) I haven't found a good way of applying a knockback effect to every unit of a unit group at once. Apparently it's impossible to start a timer function within a loop.

Oh yeah, and I'm using KaTTaNa's Handler function system.

These are the two relevant triggers:

JASS:
function Trig_PulseBeam_Conditions takes nothing returns boolean
    return ( GetSpellAbilityId() == 'A082')
endfunction

function targetcond takes nothing returns boolean
    if ( IsUnitType(GetFilterUnit(), UNIT_TYPE_MECHANICAL) == true ) then
        return false
    endif
    if ( IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) == true ) then
        return false
    endif
    if ( IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(GetTriggerUnit())) == false ) then
        return false
    endif
    if ( IsUnitAliveBJ(GetFilterUnit()) == false) then
        return false
    endif
    return true
endfunction


function flight takes nothing returns nothing
    local timer t = GetExpiredTimer ()
    local unit u = GetHandleUnit(t,"v")
    local group g
    call SetUnitPositionLoc (u, PolarProjectionBJ ( GetUnitLoc (u), 20, GetUnitFacing (u)))
    set g = GetUnitsInRangeOfLocMatching(100, GetUnitLoc(u), Condition(function targetcond))
    if (CountUnitsInGroup (g) != 0) then
    call KillUnit (u)
    endif
endfunction

function create takes nothing returns nothing
    local timer ti = GetExpiredTimer ()
    local timer t = CreateTimer ()
    local unit proj
    local unit c = GetHandleUnit(ti, "c")
    call CreateNUnitsAtLoc( 1, 'u00O', GetOwningPlayer(c), GetUnitLoc(c), GetUnitFacing(c))
    set proj = GetLastCreatedUnit()
    call UnitApplyTimedLifeBJ( 1.70, 'BTLF', proj )
    call SetHandleHandle(t,"v",proj)
    call TimerStart (t, 0.035, true, function flight)
    call TriggerSleepAction (1.70)
    call RemoveUnit(proj)
    call PauseTimer (t)
    call FlushHandleLocals (t)
    call DestroyTimer (t)
    set proj = null
    set c = null
    set ti = null
    set t = null    
endfunction

function Trig_PulseBeam_Actions takes nothing returns nothing
    local unit cast = GetTriggerUnit ()
    local timer ti = CreateTimer ()
    call SetHandleHandle (ti, "c", cast)
    call TimerStart (ti, 0.16, true, function create)
    call TriggerSleepAction (1.60)
    call PauseTimer (ti)
    call DestroyTimer (ti)
    set ti = null
    set cast = null
endfunction

//===========================================================================
function InitTrig_PulseBeam takes nothing returns nothing
    set gg_trg_PulseBeam = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_PulseBeam, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_PulseBeam, Condition( function Trig_PulseBeam_Conditions ) )
    call TriggerAddAction( gg_trg_PulseBeam, function Trig_PulseBeam_Actions )
endfunction


JASS:
function Trig_PulseBeamEffect_Conditions takes nothing returns boolean
    if (GetUnitTypeId(GetDyingUnit()) == 'u00O') then
        return true
    endif
    return false
endfunction

function Trig_PulseBeamEffect_Func001001003 takes nothing returns boolean
    return ( IsUnitType(GetTriggerUnit(), UNIT_TYPE_STRUCTURE) == true )
endfunction

//function knock takes nothing returns nothing
//    local timer k = GetExpiredTimer ()
//    local unit u = GetHandleUnit (k, "ku")
//    local real x = GetHandleReal (k, "xd")
//    local real y = GetHandleReal (k, "yd")
//    local location l = Location (x, y)
//    call SetUnitPositionLoc(u, PolarProjectionBJ(GetUnitLoc(u), 10, AngleBetweenPoints (l, GetUnitLoc(u))))
//endfunction

// I hope all the //-disabled actions aren't too annoying.

function Trig_PulseBeamEffect_Actions takes nothing returns nothing
    local unit d = GetDyingUnit ()
    local group g = GetUnitsInRangeOfLocMatching(120.00, GetUnitLoc(d), Condition(function targetcond))
//    local real x = GetLocationX (GetUnitLoc (d))
//    local real y = GetLocationY (GetUnitLoc (d))
//    local unit u
//    local timer k = CreateTimer ()
    call AddSpecialEffectLocBJ( GetUnitLoc(GetDyingUnit()), "Units\\NightElf\\Wisp\\WispExplode.mdl" )
    call DestroyEffectBJ( GetLastCreatedEffectBJ() )    
//    call SetHandleHandle (k, "ta", g)
//    call SetHandleReal (k, "xd", x)
//    call SetHandleReal (k, "yd", y)
//    loop
//        set u = FirstOfGroup (g)
//        exitwhen u == null
//        call GroupRemoveUnit (g, u)
//        call SetHandleHandle (k, "ku", u)     
//    endloop
    call TriggerSleepAction (0.24)
//    call PauseTimer (k)
//    call FlushHandleLocals (k)
//    call DestroyTimer (k)
    call RemoveUnit (d)
//    set k = null
    set g = null
    set d = null
//    set u = null   
endfunction

//===========================================================================
function InitTrig_PulseBeamEffect takes nothing returns nothing
    set gg_trg_PulseBeamEffect = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_PulseBeamEffect, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddCondition( gg_trg_PulseBeamEffect, Condition( function Trig_PulseBeamEffect_Conditions ) )
    call TriggerAddAction( gg_trg_PulseBeamEffect, function Trig_PulseBeamEffect_Actions )
endfunction
 
Viikuna

Viikuna

No Marlo no game.
Reaction score
265
Kattanas Handle Vars is kinda old & slow system and it can be pretty dangerous too. In these days Jassers have much more powerful recources to deploy. vJass is a nice extension to normal Jass, and it provides some pretty cool new features to ease our coding.

First you should get NewGen, in case you dont have it yet. Its something must have. Also you should update to newest version of JassHelper.

Some useful links:
JassHelper manual ( List of all vJass features )
How use NewGen after 1.22 patch.

About the knockback.
You should use structs ( vJass feature ) for your knockback. There is pretty good knockback tutorial by Silvennon, here and it requires some struct knowledge.

I can write you some really simple example later, unless some other guy manages to do it first.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Staff online

      Members online

      Online now:
      373 (members: 2, guests: 371)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top