Problem with UAC trigger

Terrabull

Terrabull

Veteran Member (Done that)
Reaction score
38
I posted this in the thread for UAC, but apparently no one looks at that, so I decided to ask for help here.
I am using Romek's UAC system but it's not working any better than the Warcraft Engine, which is highly disappointing.

Summary:
There are three units, three auras, and one ability with three levels each level corresponding to one unit.
When a unit is damaged by one of the units, the aura that is associated with that unit is added to the damaged unit.
Using the periodic trigger the aura checks to see if the unit already has the ability or a higher level of the ability on it, if so, it does nothing. If it has a lower level ability, it raises the level of the ability.

Expected Results:
The damaged unit should get the proper aura from the attacking unit. This aura should never be duplicated, even if two different units w/ the aura-making ability are attacking the same unit.

Actual Results:
The damaged unit gets one buff for each unit attacking him.

JASS:
scope Bal
    private struct Ballista extends UAC
        integer level
        effect e = AddSpecialEffectTarget("Abilities\\Spells\\Orc\\EarthQuake\\EarthQuakeTarget.mdl", .main, "origin")
        
        method unitPeriodic takes unit u returns nothing
            if GetUnitAbilityLevel(u,'A010') < 1 then
                call UnitAddAbility(u,'A010')
                call SetUnitAbilityLevel(u,'A010',1)
            endif
        endmethod
        
        method unitLeave takes unit u returns nothing
            // Reset the unit
            if GetUnitAbilityLevel(u,'B001') > 0 then
                call UnitRemoveAbility(u,'A010')
            endif
        endmethod
        
        method mainDeath takes nothing returns nothing
            call DestroyEffect(.e)
        endmethod
        
        method andFilterA takes unit whichUnit returns boolean
            return IsUnitType(whichUnit,UNIT_TYPE_STRUCTURE) == false and IsUnitType(whichUnit,UNIT_TYPE_PEON) == false
        endmethod
        
        method andFilterB takes unit whichUnit returns boolean
            return GetUnitAbilityLevel(whichUnit,'A02R') < 1
        endmethod
        method onDestroy takes nothing returns nothing
            call DestroyEffect(.e)
        endmethod
    endstruct
    private struct Field extends UAC
        integer level
        effect e = AddSpecialEffectTarget("Abilities\\Spells\\Orc\\EarthQuake\\EarthQuakeTarget.mdl", .main, "origin")
        
        method unitPeriodic takes unit u returns nothing
            if GetUnitAbilityLevel(u,'A010') < 1 then
                call UnitAddAbility(u,'A010')
                call SetUnitAbilityLevel(u,'A010',2)
            elseif GetUnitAbilityLevel(u,'A010') == 1 then
                call SetUnitAbilityLevel(u,'A010',2)
            endif
        endmethod
        
        method unitLeave takes unit u returns nothing
            // Reset the unit
            if GetUnitAbilityLevel(u,'B00F') > 0 then
                call UnitRemoveAbility(u,'A010')
            endif
        endmethod
        
        method mainDeath takes nothing returns nothing
            call DestroyEffect(.e)
        endmethod
        
        method andFilterA takes unit whichUnit returns boolean
            return IsUnitType(whichUnit,UNIT_TYPE_STRUCTURE) == false and IsUnitType(whichUnit,UNIT_TYPE_PEON) == false
        endmethod
        
        method andFilterB takes unit whichUnit returns boolean
            return GetUnitAbilityLevel(whichUnit,'A02R') < 1
        endmethod
        method onDestroy takes nothing returns nothing
            call DestroyEffect(.e)
        endmethod
    endstruct
    private struct Mortar extends UAC
        integer level
        effect e = AddSpecialEffectTarget("Abilities\\Spells\\Orc\\EarthQuake\\EarthQuakeTarget.mdl", .main, "origin")
        
        method unitPeriodic takes unit u returns nothing
            if GetUnitAbilityLevel(u,'A010') < 1 then
                call UnitAddAbility(u,'A010')
                call SetUnitAbilityLevel(u,'A010',3)
            elseif GetUnitAbilityLevel(u,'A010') < 3 then
                call SetUnitAbilityLevel(u,'A010',3)
            endif
        endmethod
        
        method unitLeave takes unit u returns nothing
            // Reset the unit
            if GetUnitAbilityLevel(u,'B00G') > 0 then
                call UnitRemoveAbility(u,'A010')
            endif
        endmethod
        
        method mainDeath takes nothing returns nothing
            call DestroyEffect(.e)
        endmethod
        
        method andFilterA takes unit whichUnit returns boolean
            return IsUnitType(whichUnit,UNIT_TYPE_STRUCTURE) == false and IsUnitType(whichUnit,UNIT_TYPE_PEON) == false
        endmethod
        
        method andFilterB takes unit whichUnit returns boolean
            return GetUnitAbilityLevel(whichUnit,'A02R') < 1
        endmethod
        method onDestroy takes nothing returns nothing
            call DestroyEffect(.e)
        endmethod
    endstruct
    
    function Cond_Bal takes nothing returns boolean
    //    call DisplayTextToPlayer(GetLocalPlayer(),0,0,"Testing target.")
        return (GetUnitTypeId(GetAttacker()) == 'h01C' or GetUnitTypeId(GetAttacker()) == 'h02J' or GetUnitTypeId(GetAttacker()) == 'h069') and IsUnitType(GetTriggerUnit(),UNIT_TYPE_STRUCTURE) == false and IsUnitType(GetTriggerUnit(),UNIT_TYPE_PEON) == false and GetUnitAbilityLevel(GetTriggerUnit(),'A02R') < 1
    endfunction

    function Trig_Bal takes nothing returns nothing
            local unit tu = GetTriggerUnit()
            
            // Retrieve the struct (if any) attached to the unit, for this aura.
            local UAC d 
            
            set d = Ballista.get(tu)
            if GetUnitTypeId(GetAttacker()) == 'h02J' then
                set d = Field.get(tu)
            elseif GetUnitTypeId(GetAttacker()) == 'h069' then
                set d = Mortar.get(tu)
            endif
            
            if d == 0 then // Non existant
                // Creating it.
                if GetUnitTypeId(GetAttacker()) == 'h02J' then
                    set d = Field.create(tu,400.00)
                elseif GetUnitTypeId(GetAttacker()) == 'h069' then
                    set d = Mortar.create(tu,400.00)
                elseif GetUnitTypeId(GetAttacker()) == 'h01C' then
                    set d = Ballista.create(tu, 400.00)
                endif
                // Target stuff:
                set d.allies = true
                set d.enemies = false
                set d.neutral = true
                set d.visible = true
                set d.requirement = null
                set d.exception = UNIT_TYPE_STRUCTURE
                
                call PolledWait(3.00)
                if GetUnitState(tu,UNIT_STATE_LIFE) > 0 then
                    call d.destroy()
                endif
            endif
    endfunction

    //===========================================================================
    function InitTrig_Ballista_Debuff takes nothing returns nothing
        set gg_trg_Ballista_Debuff = CreateTrigger()
        call TriggerRegisterComputerUnitEventDK(gg_trg_Ballista_Debuff,EVENT_PLAYER_UNIT_ATTACKED)
        call TriggerAddCondition(gg_trg_Ballista_Debuff,Condition(function Cond_Bal))
        call TriggerAddAction(gg_trg_Ballista_Debuff,function Trig_Bal)
    endfunction
endscope


Any help would be appreciated and +rep'd.
 
Tyrulan

Tyrulan

Ultra Cool Member
Reaction score
37
Look up Jesus4Lyf's Damage (and Event) system and replace your original event. EVENT_PLAYER_UNIT_ATTACKED will throw the wrong (unwanted) flags.
 
Terrabull

Terrabull

Veteran Member (Done that)
Reaction score
38
What? Why?
I customized the event as you can tell so that it only works for certain units.
 
Tyrulan

Tyrulan

Ultra Cool Member
Reaction score
37
Add condition to check if the unit already has one of the three buffs. If so, d.destroy() and move on.\

ALSO: I meant with the EVENT. Attacked is thrown when:

A buff ticks (like faeirie fire. Yeah, who knew?)
An attack order is issued (before back swing and missile speed is applied
a spell is cast

and more....

my point is you're better with the Damage,Event system.
 
Terrabull

Terrabull

Veteran Member (Done that)
Reaction score
38
It can check for lower ability levels, but it should already be doing that, and that is exactly what is malfunctioning.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Staff online

      Members online

      Online now:
      110 (members: 3, guests: 107)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top