Question about these actions

[BRUTAL]

these two actions are BJ's but the fix for them is confusing

call SelectUnitForPlayerSingle (u, GetEnumPlayer())
        call PanCameraToTimedForPlayer (GetEnumPlayer(), x, y, 0)

now the fixed way for the Select action is;

if (GetLocalPlayer() == whichPlayer) then
        // Use only local code (no net traffic) within this block to avoid desyncs.
        call ClearSelection()
        call SelectUnit(whichUnit, true)
    endif

and i dont get it, the action 'SelectUnit(whichUnit, true)' doesnt have a agruement for a player, so do i have to put that 'if (GetLocalPlayer..' for each player? : s

same with the camera action;

if (GetLocalPlayer() == whichPlayer) then
        // Use only local code (no net traffic) within this block to avoid desyncs.
        call PanCameraToTimed(x, y, duration)
    endif

thanks in advance

 

[Romek]

For the select one:
SelectUnit(..) selects the unit for all players by default.
GetLocalPlayer() is used to only select it for a single player.

So, if you want all players to select a unit, just use SelectUnit(u, true).

 

[BRUTAL]

ah i should have said this earlier
but i want one player to select the unit, and the camera to move for only one player,
the select and camera actions are part of my all random trigger
which picks every player in all players, and makes a hero for them, then i want that unit to be select for that player, and that players camera moved to a spot depending if its in teamwest or teameast

 

[BRUTAL]

bump

 

[Tom Jones]

function ...
    if GetLocalPlayer() == SomePlayer then
        call PanCameraTo(x,y)
        call SelectUnit(u,true)
    endif
endfunction

 

[BRUTAL]

how does that select a unit/pan camera for just one player if theres no player agruements in those actions

 

[Romek]

GetLocalPlayer() checks the current player running the trigger, so if compared to a player, you can force a certain set of actions to only be run for one player. Obviously this can have pretty bad effects if used incorrectly. However, doing those 2 will be fine.


More Information on GetLocalPlayer()

 

[BRUTAL]

well
what would i do if i wanted it to work for all players? put it in a loop or something?

 

[Romek]

Well, if you want it to work for all players, why would you use a check to limit it to certain players in the first place?
In that case, you would just remove the entire if/endif.

 

[Tom Jones]

Indeed.

function ...
    local unit u
    local integer i = 0
    local integer a = GetPlayers()
    local real x
    local real y

    ...
    loop
        exitwhen i == a
        set x = somewhere
        set y = somewhere
        set u = CreateUnit(Player(i),someid,x,y,0)
        if GetLocalPlayer() == Player(i) then
            call PanCameraTo(x,y)
            call SelectUnit(u,true)
        endif
        set i = i+1
    endloop
    set u = null
endfunction

 

[BRUTAL]

i'll just post part of the code so its easier to understand

private function f takes nothing returns nothing
    if GetPlayerSlotState (owner) == PLAYER_SLOT_STATE_PLAYING then
        set ranunit = GroupPickRandomUnit (ARG)
        call GroupRemoveUnit (ARG, ranunit)
        call GroupAddUnit (ARG, ranunit)
        set u = CreateUnit (owner, GetUnitTypeId(ranunit), 0.00, 0.00, 0)
        set PlayerHero[pn] = u
        if IsPlayerInForce (owner, TeamWest) then
            set r = gg_rct_West_Spawn
            set x = GetRectCenterX(r)
            set y = GetRectCenterY(r)
            set r = null
            call GroupAddUnit (TeamWestHeroes, u)
        elseif IsPlayerInForce (owner, TeamEast) then
            set r = gg_rct_East_Spawn
            set x = GetRectCenterX(r)
            set y = GetRectCenterY(r)
            set r = null
            call GroupAddUnit (TeamEastHeroes, u)
        elseif IsPlayerInForce (owner, TeamSolo) then
            set r = gg_rct_Mid_Tp
            set x = GetRectCenterX(r)
            set y = GetRectCenterY(r)
            set r = null
            call GroupAddUnit (TeamSoloHeroes, u)
        endif
        call SetUnitPosition (u, x, y)
        call ForGroup (ARG, function g3)
        if GetLocalPlayer() == Player(GetPlayerId(GetEnumPlayer())) then
            call PanCameraToTimed (x, y, 0)
            call SelectUnit (u, true)
        endif

see how theres if/thens to see if the picked player is in West, East or Solo, then sets x and y to something, so depending on who the player is, it will be different for some players
so like, if i just put

call PanCameraToTimed (x, y, 0)
            call SelectUnit (u, true)

without the if/then to check the localplayer it wouldnt work right? or would it? did i do it correctly

 

[Tom Jones]

That'll do it for all players, not a specific player. So all players will have their camera panned and unit selected to the last x, y, and unit created. You need the if statement.

 

[BRUTAL]

That'll do it for all players,

by that do you mean becaues its a playergroup loop, or doing

if GetLocalPlayer() == Player(GetPlayerId(GetEnumPlayer())) then

will happen for all players being checked just once as if it wasnt a playergroup loop?

i want it to work for all players, just not..like at the exact same time if you get what i mean, like say red is on team 1 and pink is on team 2, i dont want pink to have reds unit selected and pinks camera panned to reds area

oh i didnt see what you said at the end