Regarding custom scripts

[snowyowl]

Hi

So I'm having some great fun toying around with the custom script feature, as I find it way too tedious to input all I want into the interface of the editor. I tend to create testtriggers within the interface and then open View Script just to get the hang of how one are to type the triggers.
I have, however, run into some difficulties.

When I test my map, the custom scripted triggers won't run, even though I find them identical to the ones created by the interface. Of course I have to put the initializations of each trigger within each custom script, but there must be something I've missed.

trigger gt_TestDisplay;
 
bool gt_TestDisplay_Func (bool testConds, bool runActions) {
 
    // Actions
    if (!runActions) {
        return true;
    }
 
    gv_randQue = RandomInt(0, 5);
 
    UIDisplayMessage(PlayerGroupAll(), c_messageAreaChat, StringExternal(gv_Questions[0][gv_randQue].lv_Question));
 
    UIDisplayMessage(PlayerGroupAll(), c_messageAreaChat, StringExternal(gv_Questions[0][gv_randQue].lv_Alternative[0]));
 
    UIDisplayMessage(PlayerGroupAll(), c_messageAreaChat, StringExternal(gv_Questions[0][gv_randQue].lv_Alternative[1]));
 
    UIDisplayMessage(PlayerGroupAll(), c_messageAreaChat, StringExternal(gv_Questions[0][gv_randQue].lv_Alternative[2]));
 
    UIDisplayMessage(PlayerGroupAll(), c_messageAreaChat, StringExternal(gv_Questions[0][gv_randQue].lv_Alternative[3]));
 
 
    returntrue;
}
 
//--------------------------------------------------------------------------------------------------
void gt_TestDisplay_Init () {
 
    gt_TestDisplay = TriggerCreate("gt_TestDisplay_Func");
 
    TriggerAddEventTimeElapsed(gt_TestDisplay, 5.0, c_timeGame);
 
}

Here is a screenshot from when I test my map, clearly showing that the trigger TestDisplay isn't running.

Edit: I've seemed to localized the problem. In the View Script view there's a Trigger Initialization which contains all the triggers implemented through the UI, it looks like this:

//--------------------------------------------------------------------------------------------------
// Trigger Initialization
//--------------------------------------------------------------------------------------------------
void InitTriggers () {
    gt_Round1_Init();
    gt_Bepa_Init();
}

I guess I need to have a gt_TestDisplay_Init(); inside that void InitTriggers () aswell, but since that cannot be altered in the custom script, well that's when I don't know how to proceed.

So basically, my query is how to get a gt_TestDisplay_Init(); inside the InitTriggers () using script, as TestDisplay is based on a custom script.

 

[Juggie]

There are couple of ways to run the initialization function. The simplest one is to type the name of the initialization function into the "Initialization Function (Optional)" box that's located below the custom script edit field when you view the custom script in trigger editor. That will add the function you entered there into the map's InitCustomScript() function that's run at map's initialization stage.

There are also other ways, for example creating a trigger that runs on map's initialization and calling the custom script's initialization function from that trigger, but that's kind of crude.

You can also do edit the map's initialization manually. This can be done by going to import manager and checking the box "Show Reserved" and then exporting file named MapScript.galaxy. This will export the map's script as text file, which you can edit with any external text editing tool. You can then import it back, but this is slightly tricky. You cannot import a file that has the same name as a reserved file. You have to rename the file, for example to Map.galaxy, import it, save the map and then while having the "Show Reserved" option unchecked (in import manager) rename the file to MapScript.galaxy and save the map again. Note that if you edit anything through trigger editor and then save the map, the MapScript.galaxy file will be generated from scratch and your imported file will be overwritten, so this is not particularly efficient if you use trigger editor for writing scripts. If you want to use scripts only though, I find a way similar to the one described here http://www.thehelper.net/threads/galaxy-how-to-script-in-galaxy-easily.139895/ to be quite efficient.

 

[snowyowl]

Thanks, that was some really useful information Juggie! I'll try to code as much as possible outside the Galaxy Editor and use the Editor to see how certain triggers are converted to script using the View Script. Hopefully I'll have better luck with this, as I weren't able to copy text from outside the Editor to it.

 

[snowyowl]

As for now, I receive a Syntax Error whenever I try to test my map. I put the Inits of my custom script in the code like this:

//--------------------------------------------------------------------------------------------------
// Custom Script Initialization
//--------------------------------------------------------------------------------------------------
void InitCustomScript () {
    gt_TestDisplay_Init();
    gt_SetQuestions_Init();
}

Note, I didn't put it in here along with the GUI generated scripts:

//--------------------------------------------------------------------------------------------------
// Trigger Initialization
//--------------------------------------------------------------------------------------------------
void InitTriggers () {
    gt_Round1_Init();
    gt_Bepa_Init();
}

I tried putting them there but it didn't solve the issue. Looking for bugs sure is tedious when you can't compile the file until you run the Test Map :/
I searched the Internet for a good Galaxy script editor, sadly the ones I found were for Windows only.

 

[Juggie]

I'm not quite sure what's the source of the syntax errors. Maybe if you posted the whole map script or attach it as a file.

//--------------------------------------------------------------------------------------------------
// Custom Script Initialization
//--------------------------------------------------------------------------------------------------
void InitCustomScript () {
    gt_TestDisplay_Init();
    gt_SetQuestions_Init();
}

This shouldn't give a syntax error as long as you defined functions with such names above those calls. Maybe the function definitions are missing? Or perhaps there is another source of syntax errors?

For clarification: When you create triggers through trigger editor, the editor will automatically generate initialization functions that look like: void gt_NameOfTrigger_Init(), where NameOfTrigger is replaced by a the name of the trigger, obviously. It will also put a call to these functions into the Trigger Initialization block so that they get called at the map's initialization stage. If you create a Custom Script instead of a trigger then nothing is generated for you automatically. You can put the name of a function that you use as an initializer into the "Initialization Function (Optional)" box, which will add the call to that function into the Custom Script Initialization block and the function will get called at map's initialization stage as well. There must be a function with such name, otherwise the editor will give you errors. If you create custom scripts instead of triggers then the editor won't generate any functions for you, so make sure you define them. You don't need to name them in the same way as the editor does, but make sure their names are unique and that you use the same name when trying to call those functions.

P.S. I'm sorry if I'm explaining the obvious, but I can only guess what went wrong. As I said posting the whole map script or at least all map's initialization functions (InitCustomScript(), InitTriggers(), InitGlobals() and InitMap()) and the custom scripts would be much helpful in identifying the problem.