Removing preexisting units via Triggers

L

Lumograph090

New Member
Reaction score
22
Generally I would just base my summoning abilities off of Feral Spirit as this removes any previously summoned companion. However, I am using Triggers to summon with my current ability based off of Channel.

Trigger:
  • Raise Ghoul Rank 1
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • (Ability being cast) Equal to (==) Raise Ghoul
    • Actions
      • Set RandomName = (Random integer number between 1 and 3)
        • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • RandomName Equal to (==) 1
          • Then - Actions
            • Set L = (Position of (Triggering unit))
            • Unit - Create 1 Horgus (Level 1) for (Owner of (Triggering unit)) at L facing L
            • Custom script: call RemoveLocation(udg_L)
          • Else - Actions
            • Do nothing
              • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • RandomName Equal to (==) 2
                • Then - Actions
                  • Set L = (Position of (Triggering unit))
                  • Unit - Create 1 Braintheif (Level 1) for (Owner of (Triggering unit)) at L facing L
                  • Custom script: call RemoveLocation(udg_L)
                • Else - Actions
                  • Do nothing
                    • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • RandomName Equal to (==) 3
                      • Then - Actions
                        • Set L = (Position of (Triggering unit))
                        • Unit - Create 1 Corpsegrinder (Level 1) for (Owner of (Triggering unit)) at L facing L
                        • Custom script: call RemoveLocation(udg_L)
                      • Else - Actions
                        • Do nothing


This spell has 5 levels, lets say I cast the level one version twice as it is currently I would have two Ghouls. Is there a way to remove my previous Ghoul via Triggers if I use the spell a second time, and consequently for any other levels of my spell.
 
S

Saldu

New Member
Reaction score
1
You could remove every existing Unit which could be spawned by the spell when you cast the spell by doing this:
You need to add 1 condition for every new unit you would add, and you could even add every unit for every level of the spell to the conditions.

Temp_Group is a unit group global variable
Trigger:
  • Set Temp_Group = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) == Horgus) or (((Unit-type of (Matching unit)) == Corpsegrinder) or ((Unit-type of (Matching unit)) == Brainthief))))
    • Unit Group - Pick every unit in Temp_Group and do (Actions)
      • Loop - Actions
        • Unit - Remove (Picked unit) from the game
    • Custom script: call DestroyGroup(udg_Temp_Group)
 
L

Lumograph090

New Member
Reaction score
22
Saldu said:
You could remove every existing Unit which could be spawned by the spell when you cast the spell by doing this:
You need to add 1 condition for every new unit you would add, and you could even add every unit for every level of the spell to the conditions.

Temp_Group is a unit group global variable
Trigger:
  • Set Temp_Group = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) == Horgus) or (((Unit-type of (Matching unit)) == Corpsegrinder) or ((Unit-type of (Matching unit)) == Brainthief))))
    • Unit Group - Pick every unit in Temp_Group and do (Actions)
      • Loop - Actions
        • Unit - Remove (Picked unit) from the game
    • Custom script: call DestroyGroup(udg_Temp_Group)
Click to expand...

Just outta curiosity would I place that line at the start of my "Then Actions"?
 
L

Lumograph090

New Member
Reaction score
22
Trigger:
  • Raise Ghoul Rank 1
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • (Ability being cast) Equal to (==) Raise Ghoul
    • Actions
      • Set RandomName = (Random integer number between 1 and 3)
        • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • RandomName Equal to (==) 1
          • Then - Actions
            • Set Group1 = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Equal to (==) Braintheif (Level 1)) or (((Unit-type of (Matching unit)) Equal to (==) Corpsegrinder (Level 1)) or ((Unit-type of (Matching unit)) Equal to (==) Horgus (Leve
            • Unit Group - Pick every unit in Group1 and do (Actions)
              • Loop - Actions
                • Unit - Explode (Picked unit)
                • Custom script: call RemoveLocation(udg_Temp_Group)
            • Set L = (Position of (Triggering unit))
            • Unit - Create 1 Horgus (Level 1) for (Owner of (Triggering unit)) at L facing L
            • Custom script: call RemoveLocation(udg_L)
          • Else - Actions
            • Do nothing
              • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • RandomName Equal to (==) 2
                • Then - Actions
                  • Set Group1 = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Equal to (==) Braintheif (Level 1)) or (((Unit-type of (Matching unit)) Equal to (==) Corpsegrinder (Level 1)) or ((Unit-type of (Matching unit)) Equal to (==) Horgus (Leve
                  • Unit Group - Pick every unit in Group1 and do (Actions)
                    • Loop - Actions
                      • Unit - Explode (Picked unit)
                      • Custom script: call RemoveLocation(udg_Temp_Group)
                  • Set L = (Position of (Triggering unit))
                  • Unit - Create 1 Braintheif (Level 1) for (Owner of (Triggering unit)) at L facing L
                  • Custom script: call RemoveLocation(udg_L)
                • Else - Actions
                  • Do nothing
                    • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • RandomName Equal to (==) 3
                      • Then - Actions
                        • Set Group1 = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Equal to (==) Braintheif (Level 1)) or (((Unit-type of (Matching unit)) Equal to (==) Corpsegrinder (Level 1)) or ((Unit-type of (Matching unit)) Equal to (==) Horgus (Leve
                        • Unit Group - Pick every unit in Group1 and do (Actions)
                          • Loop - Actions
                            • Unit - Explode (Picked unit)
                            • Custom script: call RemoveLocation(udg_Temp_Group)
                        • Set L = (Position of (Triggering unit))
                        • Unit - Create 1 Corpsegrinder (Level 1) for (Owner of (Triggering unit)) at L facing L
                        • Custom script: call RemoveLocation(udg_L)
                      • Else - Actions
                        • Do nothing


:D Should be correct, if you're willing mind looking over it? :)
 
Gtam

Gtam

Lerning how to write and read!! Yeah.
Reaction score
164
Yep yep yep all good but you know that he can have 3 units summoned if the random integer is diffrent each time. If you want the every thing is fine
 
L

Lumograph090

New Member
Reaction score
22
SharkBait87 said:
Yep yep yep all good but you know that he can have 3 units summoned if the random integer is diffrent each time. If you want the every thing is fine
Click to expand...

Really? why is that? How would I go about fixing this issue?

What I was attempting to do from the start is have a summoning ability that will generate different names for the same summoned creature. In terms of what I want it to generally do it works great, I was just looking for a way to prevent him from having more than one Ghoul up at a time, no matter the levels.
 
Gtam

Gtam

Lerning how to write and read!! Yeah.
Reaction score
164
O wait sory no misread its fine that way.
 
L

Lumograph090

New Member
Reaction score
22
SharkBait87 said:
O wait sory no misread its fine that way.
Click to expand...

Alright, I've ran into an issue when I go to save I get an error "Cannot convert group into position"

Trigger:
  • Raise Ghoul Rank 1
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • (Ability being cast) Equal to (==) Raise Ghoul
    • Actions
      • Set RandomName = (Random integer number between 1 and 3)
        • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • RandomName Equal to (==) 1
          • Then - Actions
            • Set Group1 = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Equal to (==) Braintheif (Level 1)) or (((Unit-type of (Matching unit)) Equal to (==) Corpsegrinder (Level 1)) or ((Unit-type of (Matching unit)) Equal to (==) Horgus (Leve
            • Unit Group - Pick every unit in Group1 and do (Actions)
              • Loop - Actions
                • Unit - Explode (Matching unit)
                • Custom script: call RemoveLocation(udg_Group1)
            • Set L = (Position of (Triggering unit))
            • Unit - Create 1 Horgus (Level 1) for (Owner of (Triggering unit)) at L facing L
            • Custom script: call RemoveLocation(udg_L)
          • Else - Actions
            • Do nothing
              • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • RandomName Equal to (==) 2
                • Then - Actions
                  • Set Group1 = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Equal to (==) Braintheif (Level 1)) or (((Unit-type of (Matching unit)) Equal to (==) Corpsegrinder (Level 1)) or ((Unit-type of (Matching unit)) Equal to (==) Horgus (Leve
                  • Unit Group - Pick every unit in Group1 and do (Actions)
                    • Loop - Actions
                      • Unit - Explode (Matching unit)
                      • Custom script: call RemoveLocation(udg_Group1)
                  • Set L = (Position of (Triggering unit))
                  • Unit - Create 1 Braintheif (Level 1) for (Owner of (Triggering unit)) at L facing L
                  • Custom script: call RemoveLocation(udg_L)
                • Else - Actions
                  • Do nothing
                    • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • RandomName Equal to (==) 3
                      • Then - Actions
                        • Set Group1 = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Equal to (==) Braintheif (Level 1)) or (((Unit-type of (Matching unit)) Equal to (==) Corpsegrinder (Level 1)) or ((Unit-type of (Matching unit)) Equal to (==) Horgus (Leve
                        • Unit Group - Pick every unit in Group1 and do (Actions)
                          • Loop - Actions
                            • Unit - Explode (Matching unit)
                            • Custom script: call RemoveLocation(udg_Group1)
                        • Set L = (Position of (Triggering unit))
                        • Unit - Create 1 Corpsegrinder (Level 1) for (Owner of (Triggering unit)) at L facing L
                        • Custom script: call RemoveLocation(udg_L)
                      • Else - Actions
                        • Do nothing


Seems to be that the issue is with this...

Trigger:
  • Loop - Actions
    • Unit - Explode (Matching unit)
    • Custom script: call RemoveLocation(udg_Group1)


Anyone with a little more knowledge than me have any ideas as to why this isn't correct?
 
Gtam

Gtam

Lerning how to write and read!! Yeah.
Reaction score
164
Call DestroyGroup(udg_group1) not removelocation
 
L

Lumograph090

New Member
Reaction score
22
SharkBait87 said:
So it works now and your ok
Click to expand...

Well, not exactly.. here is the Syntax Error.

Code: 
function Trig_Raise_Ghoul_Rank_1_Actions takes nothing returns nothing
    set udg_RandomName = GetRandomInt(1, 3)
    if ( Trig_Raise_Ghoul_Rank_1_Func002C() ) then
        set udg_Group1 = GetUnitsOfPlayerMatching(GetOwningPlayer(GetTriggerUnit()), Condition(function Trig_Raise_Ghoul_Rank_1_Func002Func001002002))
        call ForGroupBJ( udg_Group1, function Trig_Raise_Ghoul_Rank_1_Func002Func002A )
        set udg_L = GetUnitLoc(GetTriggerUnit())
        call CreateNUnitsAtLocFacingLocBJ( 1, 'u001', GetOwningPlayer(GetTriggerUnit()), udg_L, udg_L )
        call RemoveLocation(udg_L)
        [B]Call DestroyGroup(udg_Group1)[/B]

Here is my Trigger...

Trigger:
  • Raise Ghoul Rank 1
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • (Ability being cast) Equal to (==) Raise Ghoul
    • Actions
      • Set RandomName = (Random integer number between 1 and 3)
        • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • RandomName Equal to (==) 1
          • Then - Actions
            • Set Group1 = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Equal to (==) Braintheif (Level 1)) or (((Unit-type of (Matching unit)) Equal to (==) Corpsegrinder (Level 1)) or ((Unit-type of (Matching unit)) Equal to (==) Horgus (Leve
            • Unit Group - Pick every unit in Group1 and do (Actions)
              • Loop - Actions
                • Unit - Explode (Picked unit)
            • Set L = (Position of (Triggering unit))
            • Unit - Create 1 Horgus (Level 1) for (Owner of (Triggering unit)) at L facing L
            • Custom script: call RemoveLocation(udg_L)
            • Custom script: Call DestroyGroup(udg_Group1)
          • Else - Actions
            • Do nothing
              • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
                • If - Conditions
                  • RandomName Equal to (==) 2
                • Then - Actions
                  • Set Group1 = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Equal to (==) Braintheif (Level 1)) or (((Unit-type of (Matching unit)) Equal to (==) Corpsegrinder (Level 1)) or ((Unit-type of (Matching unit)) Equal to (==) Horgus (Leve
                  • Unit Group - Pick every unit in Group1 and do (Actions)
                    • Loop - Actions
                      • Unit - Explode (Picked unit)
                  • Set L = (Position of (Triggering unit))
                  • Unit - Create 1 Braintheif (Level 1) for (Owner of (Triggering unit)) at L facing L
                  • Custom script: Call RemoveLocation(udg_L)
                  • Custom script: Call DestroyGroup(udg_Group1)
                • Else - Actions
                  • Do nothing
                    • Multiple FunctionsIf (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • RandomName Equal to (==) 3
                      • Then - Actions
                        • Set Group1 = (Units owned by (Owner of (Triggering unit)) matching (((Unit-type of (Matching unit)) Equal to (==) Braintheif (Level 1)) or (((Unit-type of (Matching unit)) Equal to (==) Corpsegrinder (Level 1)) or ((Unit-type of (Matching unit)) Equal to (==) Horgus (Leve
                        • Unit Group - Pick every unit in Group1 and do (Actions)
                          • Loop - Actions
                            • Unit - Explode (Picked unit)
                        • Set L = (Position of (Triggering unit))
                        • Unit - Create 1 Corpsegrinder (Level 1) for (Owner of (Triggering unit)) at L facing L
                        • Custom script: call RemoveLocation(udg_L)
                        • Custom script: Call DestroyGroup(udg_group1)
                      • Else - Actions
                        • Do nothing


*Edit* Apparently custom scripts do NOT like you using capital letters :p
 
Gtam

Gtam

Lerning how to write and read!! Yeah.
Reaction score
164
Yes i didnt mean to have a capital so is everything ok now anymore help need coz i gtg.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • WildTurkey WildTurkey:
    is there a stephen green in the house?
     +1
  • The Helper The Helper:
    What is up WildTurkey?
  • The Helper The Helper:
    Looks like Google fixed whatever mistake that made the recipes on the site go crazy and we are no longer trending towards a recipe site lol - I don't care though because it motivated me to spend alot of time on the site improving it and at least now the content people are looking at is not stupid and embarrassing like it was when I first got back into this like 5 years ago.
  • The Helper The Helper:
    Plus - I have a pretty bad ass recipe collection now! That section of the site is 10 thousand times better than it was before
  • The Helper The Helper:
    We now have a web designer at my job. A legit talented professional! I am going to get him to redesign the site theme. It is time.
  • Varine Varine:
    I got one more day of community service and then I'm free from this nonsense! I polished a cop car today for a funeral or something I guess
  • Varine Varine:
    They also were digging threw old shit at the sheriff's office and I tried to get them to give me the old electronic stuff, but they said no. They can't give it to people because they might use it to impersonate a cop or break into their network or some shit? idk but it was a shame to see them take a whole bunch of radios and shit to get shredded and landfilled
  • The Helper The Helper:
    whatever at least you are free
  • The Helper The Helper:
    Here is a cool dessert recipe I found https://www.thehelper.net/threads/recipe-cherry-cheesecake-brownie.194048/
  • The Helper The Helper:
    Found a cool easy Chicken Pot Pie recipe! https://www.thehelper.net/threads/recipe-chicken-pot-pie.194064/
  • Monovertex Monovertex:
    How are you all? :D
     +1
  • Ghan Ghan:
    Howdy
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?

      The Helper Discord

      Members online

      No members online now.
      Online now:
      327 (members: 0, guests: 327)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top