Req Trigger: Income (LoE, EBR etc.)

[snowyowl]

Hi everyone, I'm new to this forum, but not too new to the World Editor. I don't do JASS or such, I just try to come up with a map every once in a while without having the Editor crash all too often (Which sadly is very often since I'm on a Mac).

Anyways, I need some help with a trigger that I can't get to work properly.
It's supposed to count the number of buildings owned by each player and give resources according to following number:

Building 1: # * 50 gold, # * 50/2 lumber
Building 2: # * 75 gold, # * 75/2 lumber
Building 3: # * 100 gold, # * 100/2 lumber
Building 4: # * 125 gold, # * 125/2 lumber
Building 5: # * 150 gold, # * 150/2 lumber

The trigger I'm trying to create is to be similar to the one used in Lords of Europe to calculate income.
Currently my trigger looks like following (Yeah, I know it's crap, that's why I need help):

Events
[INDENT]Time - IncomeTimer expires
[/INDENT]
Conditions
Actions
[INDENT]Set IncomeRealVariable[1] = (((((((((Real((Number of living Tent units owned by Players[(Integer A)]))) x 50.00) + ((Real((Number of living Lodge units owned by Players[(Integer A)]))) x 75.00)) + ((Real((Number of living Hut units owned by Players[(Integer A)]))) x 100.00)) + ((Real((N
[/INDENT]
[INDENT]Set IncomeRealVariable[2] = (((((((((Real((Number of living Tent units owned by Players[(Integer A)]))) x 50.00) + ((Real((Number of living Lodge units owned by Players[(Integer A)]))) x 75.00)) + ((Real((Number of living Hut units owned by Players[(Integer A)]))) x 100.00)) + ((Real((N
[/INDENT]
[INDENT]Set IncomeRealVariable[3] = (((((((((Real((Number of living Tent units owned by Players[(Integer A)]))) x 50.00) + ((Real((Number of living Lodge units owned by Players[(Integer A)]))) x 75.00)) + ((Real((Number of living Hut units owned by Players[(Integer A)]))) x 100.00)) + ((Real((N
[/INDENT]
[INDENT]Set IncomeRealVariable[4] = (((((((((Real((Number of living Tent units owned by Players[(Integer A)]))) x 50.00) + ((Real((Number of living Lodge units owned by Players[(Integer A)]))) x 75.00)) + ((Real((Number of living Hut units owned by Players[(Integer A)]))) x 100.00)) + ((Real((N
[/INDENT]
[INDENT]Set IncomeRealVariable[5] = (((((((((Real((Number of living Tent units owned by Players[(Integer A)]))) x 50.00) + ((Real((Number of living Lodge units owned by Players[(Integer A)]))) x 75.00)) + ((Real((Number of living Hut units owned by Players[(Integer A)]))) x 100.00)) + ((Real((N
[/INDENT]
.... And so on, one of those for each players ....
[INDENT]Player - Add (Integer(IncomeRealVariable[(Integer A)])) to Players[(Integer A)] Current gold[/INDENT]
[INDENT]Player - Add (Integer((IncomeRealVariable[(Integer B)] / 2.00))) to Players[(Integer B)] Current lumber
Game - Display to Player Group - Player 1 (Red) the text: ((You've recieved  + ((String(IncomeRealVariable[1])) + ( gold and  + ((String((IncomeRealVariable[1] / 2.00))) +  lumber during this income period.)))) +  )
Sound - Play Income <gen>
[/INDENT]

With this trigger, I just recieve the game message (When playing as Player 1 Red, ofcourse) saying I've recieved 0.000 gold and 0.000 lumber.
So basically, I need a fully functional trigger which works for all players.

Thank you for any help!

Note: The Set IncomeRealVariable above is not complete because it's too long (it seems) but it just continues in the same pattern for the 5 diffrent buildings.

 

[Baltazhar]

Okay, had some trouble in wrapping my mind around it, but here's what I did. Note that I haven't tested it, but I'm almost 100% that it will work.

Testing
    Events
        Time - TimerVariable expires
    Conditions
    Actions
        Set BuildingsIncome[1] = 50
        Set BuildingsIncome[2] = 75
        Set BuildingsIncome[3] = 100
        Set BuildingsIncome[4] = 125
        Set BuildingsIncome[5] = 150
        Player Group - Pick every player in (All players) and do (Actions)
            Loop - Actions
                For each (Integer A) from 1 to 5, do (Actions)
                    Loop - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Number of units in (Units owned by (Picked player) of type Farm)) Equal to (Integer A)
                            Then - Actions
                                Player - Add BuildingsIncome[(Integer A)] to (Picked player) Current gold
                                Player - Add (BuildingsIncome[(Integer A)] / 2) to (Picked player) Current lumber
                            Else - Actions
                                Do nothing

EDIT: In the event I made a TimerVariable, just to make it look more like ur trigger - So that one is purely for looks, I know u have ur own variable.
The other Variable i used is the on set here, BuildingsIncome.

Btw, you don't need to make ur variables 'real', just use integer. You only need real for something like time, distance, angles and such.. For counting things, money and lumber, u can use integer.

 

[snowyowl]

Thanks for the help, I'll try this right away. Meanwhile, does this include all 5 buildings, considering (Number of units in (Units owned by (Picked player) of type Farm)) Equal to (Integer A) ?
And what about the game message, any clue on how that should be triggered?

Edit: Ran some tests, gold was recieved but not in the amounts I was hoping for. For having 2 [1] and 2 [2] I just recieved 75 gold, and no lumber...

 

[Baltazhar]

Oooooh... Then I have misunderstood ur question completely.
I thought it was like this:

There are 1 income building-type. Let's call it "Farm". If u have 1 Farm u get 50, if u have 2 Farms u get 75 etc...

But there are 5 different building-types? Cuz then we'll need another trigger

EDIT: Just to be clear, the trigger I made check if u have 1, 2, 3, 4 or 5 IncomeBuildings.

 

[snowyowl]

Ahh yeah that was clearly a misunderstanding. As in Lords of Europe and similar maps, where you claim more and more cities (income buildings) I wish that certain buildings give 50 gold, others give 75 gold and so on. Sorry if I wrote confusing in this and earlier posts.

 

[Baltazhar]

I can see in the Topic of the thread u wrote LoE and EBR... Unfortunately, I don't know any of these maps xD

Hang on and i'll make the trigger work as intended

 

[Baltazhar]

Okay, here it is.

Testing
    Events
        Time - TimerVariable expires
    Conditions
    Actions
        Set BuildingsIncome[1] = 50
        Set BuildingsIncome[2] = 75
        Set BuildingsIncome[3] = 100
        Set BuildingsIncome[4] = 125
        Set BuildingsIncome[5] = 150
        Player Group - Pick every player in (All players) and do (Actions)
            Loop - Actions
                -------- Building 1 --------
                Player - Add ((Number of units in (Units owned by (Picked player) of type Farm)) x BuildingsIncome[1]) to (Picked player) Current gold
                Player - Add ((Number of units in (Units owned by (Picked player) of type Farm)) x (BuildingsIncome[1] / 2)) to (Picked player) Current lumber
                -------- Building 2 --------
                Player - Add ((Number of units in (Units owned by (Picked player) of type Farm)) x BuildingsIncome[2]) to (Picked player) Current gold
                Player - Add ((Number of units in (Units owned by (Picked player) of type Farm)) x (BuildingsIncome[2] / 2)) to (Picked player) Current lumber
                -------- Building 3 --------
                Player - Add ((Number of units in (Units owned by (Picked player) of type Farm)) x BuildingsIncome[3]) to (Picked player) Current gold
                Player - Add ((Number of units in (Units owned by (Picked player) of type Farm)) x (BuildingsIncome[3] / 2)) to (Picked player) Current lumber
                -------- Building 4 --------
                Player - Add ((Number of units in (Units owned by (Picked player) of type Farm)) x BuildingsIncome[4]) to (Picked player) Current gold
                Player - Add ((Number of units in (Units owned by (Picked player) of type Farm)) x (BuildingsIncome[4] / 2)) to (Picked player) Current lumber
                -------- Building 5 --------
                Player - Add ((Number of units in (Units owned by (Picked player) of type Farm)) x BuildingsIncome[5]) to (Picked player) Current gold
                Player - Add ((Number of units in (Units owned by (Picked player) of type Farm)) x (BuildingsIncome[5] / 2)) to (Picked player) Current lumber

As u can see all unit types are set to Farm, but ofc, they have to be each City level 1-5 respectively. Other than that, this should work perfect

 

[snowyowl]

Thanks alot. I'm going to try this out once I've recovered from the WJC in hockey where Sweden just beat Russia in sudden death in the semifinals.
What d'you think regarding the text message which is to be announced individually to each player? Should I link the BuildsIncome variable into one which is to be displayed? What do I have to do to make it display correct income to correct player?