Simple Trigger/Leak Question

M

MorbazanRhot

New Member
Reaction score
7
I have a pretty simple question regarding where to remove a variable within multiple instances of it in a single trigger.

Example:

Code: 
Defenses
    Events
        Time - Elapsed game time is 0.50 seconds
    Conditions
    Actions
        Set unitgroup = (Units in Pink Army 1 <gen>)
        Unit Group - Pick every unit in unitgroup and do (Actions)
            Loop - Actions
                Unit - Order (Picked unit) to Hold Position
        Set unitgroup = (Units in Pink Army 2 <gen>)
        Unit Group - Pick every unit in unitgroup and do (Actions)
            Loop - Actions
                Unit - Order (Picked unit) to Hold Position
        Set unitgroup = (Units in Pink Army 3 <gen>)
        Unit Group - Pick every unit in unitgroup and do (Actions)
            Loop - Actions
                Unit - Order (Picked unit) to Hold Position
        Set unitgroup = (Units in Pink Army 4 <gen>)
        Unit Group - Pick every unit in unitgroup and do (Actions)
            Loop - Actions
                Unit - Order (Picked unit) to Hold Position
        Custom script: call DestroyGroup (udg_unitgroup)

Is that fine? Or would it be better like this:

Code: 
Defenses
    Events
        Time - Elapsed game time is 0.50 seconds
    Conditions
    Actions
        Set unitgroup = (Units in Pink Army 1 <gen>)
        Unit Group - Pick every unit in unitgroup and do (Actions)
            Loop - Actions
                Unit - Order (Picked unit) to Hold Position
        Custom script: call DestroyGroup (udg_unitgroup)
        Set unitgroup = (Units in Pink Army 2 <gen>)
        Unit Group - Pick every unit in unitgroup and do (Actions)
            Loop - Actions
                Unit - Order (Picked unit) to Hold Position
        Custom script: call DestroyGroup (udg_unitgroup)
        Set unitgroup = (Units in Pink Army 3 <gen>)
        Unit Group - Pick every unit in unitgroup and do (Actions)
            Loop - Actions
                Unit - Order (Picked unit) to Hold Position
        Custom script: call DestroyGroup (udg_unitgroup)
        Set unitgroup = (Units in Pink Army 4 <gen>)
        Unit Group - Pick every unit in unitgroup and do (Actions)
            Loop - Actions
                Unit - Order (Picked unit) to Hold Position
        Custom script: call DestroyGroup (udg_unitgroup)


I'd just like to know which of these would be more efficient? I assumed the first just because it has less lines, but would it be worse for some reason because it's not removed before being assigned a new value? Or maybe neither of these are any good? And would the same go for points, like setting TempPoint1=center of rect, then spawning units there, setting TempPoint1=center of a different rect, then spawning units there, etc. and removing TempPoint1 at the end? Thanks, and +rep for help.

edit: And yes, I know that if there's a wait it needs to be removed before the wait. I'm asking for situations where there are no waits in between.
 
E

Emu.Man00

New Member
Reaction score
41
Code: 
custom script : local unit group tempGroup
unit group- add pink army 1 to tempGroup
unit group- add pink army 2 to tempGroup
unit group- add pink army 3 to tempGroup
unit group- add pink army 4 to tempGroup
unit group - pick every unit in tempgroup and do (actions)
   loop actions
      unit - order (picked unit) to hold position
custom script: call DestroyGroup (tempGroup)

I think that would work best :)
 
bOb666777

bOb666777

Stand against the ugly world domination face!
Reaction score
117
Emu.Man00 said:
Code: 
custom script : local unit group tempGroup
unit group- add pink army 1 to tempGroup
unit group- add pink army 2 to tempGroup
unit group- add pink army 3 to tempGroup
unit group- add pink army 4 to tempGroup
unit group - pick every unit in tempgroup and do (actions)
   loop actions
      unit - order (picked unit) to hold position
custom script: call DestroyGroup (tempGroup)

I think that would work best :)
Click to expand...

Yeah, just one thing: udg_tempGroup*
 
M

MorbazanRhot

New Member
Reaction score
7
The thing is, Pink Army x is a rect, and that I know of, there's not any way to add units to a unit group from a rect without making them into a unit group in the first place, which is what I'm already doing here.

I could add unitgroup to tempgroup after each rect group assignment, but I'd still need to remove unitgroup and tempgroup, which doesn't answer my initial question and doesn't really make the trigger any more efficient either.
 
CaptDeath

CaptDeath

New Member
Reaction score
103
the latter is better
@emu you cant use locals in a GUI trigger so the loop would have to be a custom script as well
 
AceHart

AceHart

Your Friendly Neighborhood Admin
Reaction score
1,495
Leaks a unit group:
- Set unitgroup = (Units in Pink Army 1 <gen>)
- Set unitgroup = (Units in Pink Army 2 <gen>)
- Custom script: call DestroyGroup (udg_unitgroup)

No problem here:
- Set unitgroup = (Units in Pink Army 1 <gen>)
- Custom script: call DestroyGroup (udg_unitgroup)
- Set unitgroup = (Units in Pink Army 2 <gen>)
- Custom script: call DestroyGroup (udg_unitgroup)
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
     +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
     +1
  • The Helper The Helper:
    Here is a great appetizer recipe Texas style! https://www.thehelper.net/threads/recipe-chicken-stuffed-poblano-peppers.194086/
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
     +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    New dessert for Summer - https://www.thehelper.net/threads/recipe-lemon-blueberry-layer-cheesecake.194113/
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
     +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
     +2
  • V-SNES V-SNES:
    Happy Friday!
     +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      Online now:
      393 (members: 2, guests: 391)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top