Special Hero Skill related problems

[SkyXyden]

Q1) Something is wrong with the code below. The dummy unit is not casting the correct level spell.

Holy Rain
    Events
        Unit - A unit Begins casting an ability
    Conditions
        (Ability being cast) Equal to ELEN 4 Holy Rain (Cast Point)
    Actions
        Unit - Create 1 Dummy Unit for (Owner of (Triggering unit)) at (Position of (Triggering unit)) facing (Position of (Triggering unit))
        Animation - Change (Last created unit)'s size to (100.00%, 100.00%, 100.00%) of its original size
        Unit - Add ELEN 4 Holy Rain (Damage Point) to (Last created unit)
        If ((Level of ELEN 4 Holy Rain (Cast Point) for (Triggering unit)) Equal to 1) then do (Unit - Set level of ELEN 4 Holy Rain (Damage Point) for (Last created unit) to 1) else do (Do nothing)
        If ((Level of ELEN 4 Holy Rain (Cast Point) for (Triggering unit)) Equal to 2) then do (Unit - Set level of ELEN 4 Holy Rain (Damage Point) for (Last created unit) to 2) else do (Do nothing)
        If ((Level of ELEN 4 Holy Rain (Cast Point) for (Triggering unit)) Equal to 3) then do (Unit - Set level of ELEN 4 Holy Rain (Damage Point) for (Last created unit) to 3) else do (Do nothing)
        If ((Level of ELEN 4 Holy Rain (Cast Point) for (Triggering unit)) Equal to 4) then do (Unit - Set level of ELEN 4 Holy Rain (Damage Point) for (Last created unit) to 4) else do (Do nothing)
        If ((Level of ELEN 4 Holy Rain (Cast Point) for (Triggering unit)) Equal to 5) then do (Unit - Set level of ELEN 4 Holy Rain (Damage Point) for (Last created unit) to 5) else do (Do nothing)
        If ((Level of ELEN 4 Holy Rain (Cast Point) for (Triggering unit)) Equal to 6) then do (Unit - Set level of ELEN 4 Holy Rain (Damage Point) for (Last created unit) to 6) else do (Do nothing)
        Unit - Order (Last created unit) to Night Elf Priestess Of The Moon - Starfall
        Sound - Play MalfurionWarcry1 <gen> at 100.00% volume, located at (Position of (Last created unit)) with Z offset 0.00
        Unit - Add a 17.00 second Generic expiration timer to (Last created unit)

Thanks in advance.

 

[darkbeer]

simply:

Holy Rain
    Events
        Unit - A unit Begins casting an ability
    Conditions
        (Ability being cast) Equal to ELEN 4 Holy Rain (Cast Point)
    Actions
        Unit - Create 1 Dummy Unit for (Owner of (Triggering unit)) at (Position of (Triggering unit)) facing (Position of (Triggering unit))
        Animation - Change (Last created unit)'s size to (100.00%, 100.00%, 100.00%) of its original size
        Unit - Add ELEN 4 Holy Rain (Damage Point) to (Last created unit)
[COLOR="Red"]        Unit - Set level of ELEN 4 Holy Rain (Damage Point) for (Last created unit) to ((Level of ELEN 4 Holy Rain (Cast Point) for (Triggering unit))[/COLOR]
        Unit - Order (Last created unit) to Night Elf Priestess Of The Moon - Starfall
        Sound - Play MalfurionWarcry1 <gen> at 100.00% volume, located at (Position of (Last created unit)) with Z offset 0.00
        Unit - Add a 17.00 second Generic expiration timer to (Last created unit)

btw. you leak a location here

 

[SkyXyden]

simply:

btw. you leak a location here

Location leak?

Does the dummy need to be a Hero? Damage point skill is normal though.

 

[Weyrling]

Recommendation: Use the event 'Starts the effect of ability' instead of 'begins casting ability'.

 

[darkbeer]

fully optimized:

Holy Rain
    Events
        Unit - A starts the effect of an ability
    Conditions
        (Ability being cast) Equal to ELEN 4 Holy Rain (Cast Point)
    Actions
        General - Set TempLoc = Position of (Triggering unit)
        Unit - Create 1 Dummy Unit for (Owner of (Triggering unit)) at TempLpc facing (Position of (Triggering unit))
        Animation - Change (Last created unit)'s size to (100.00%, 100.00%, 100.00%) of its original size
        Unit - Add ELEN 4 Holy Rain (Damage Point) to (Last created unit)
        Unit - Set level of ELEN 4 Holy Rain (Damage Point) for (Last created unit) to ((Level of ELEN 4 Holy Rain (Cast Point) for (Triggering unit))
        Unit - Order (Last created unit) to Night Elf Priestess Of The Moon - Starfall
        Sound - Play MalfurionWarcry1 <gen> at 100.00% volume, located at TempLoc with Z offset 0.00
        Unit - Add a 17.00 second Generic expiration timer to (Last created unit)
        CustomScript: call RemoveLocation(udg_TempLoc)

should work for sure if the order and abilities are right and its leakless

 

[SkyXyden]

Thanks but 'begin casting ability' works rather than 'starting effect of an ability'.

Heres another problem, the shockwave casted did not go by intended level.

Assault Blast

Description - Blink towards the target and smashes it. Dealing <A05K:AHtb,DataA1> damage and stuns for <A05K:AHtb,Dur1> second. The impact cause powerful shockwave to be launced at 5 different direction from the target. Each dealing <A05J:AHsh,DataA1> damage. |n|n<A05K:AHtb,Cool1> seconds cooldown.

Assault Blast Point
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to TENY 2 Assault Blast (Cast Point)
    Actions
        Custom script:   call SetUnitX(GetTriggerUnit(), GetLocationX(GetSpellTargetLoc()))
        Custom script:   call SetUnitY(GetTriggerUnit(), GetLocationY(GetSpellTargetLoc()))
        Set temp_point[1] = ((Position of (Triggering unit)) offset by 300.00 towards ((Facing of (Triggering unit)) + 72.00) degrees)
        Unit - Create 1 Dummy Unit for (Triggering player) at (Position of (Triggering unit)) facing ((Facing of (Triggering unit)) + 72.00) degrees
        Animation - Change (Last created unit)'s size to (150.00%, 150.00%, 150.00%) of its original size
        Unit - Add TENY 2 Assault Blast (Blast Point) to (Last created unit)
        Unit - Set level of TENY 2 Assault Blast (Blast Point) for (Last created unit) to (Level of TENY 2 Assault Blast (Cast Point) for (Triggering unit))
        Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave temp_point[1]
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
--------------------------------------------------------------------------
        Set temp_point[2] = ((Position of (Triggering unit)) offset by 300.00 towards ((Facing of (Triggering unit)) + 144.00) degrees)
        Unit - Create 1 Dummy Unit for (Triggering player) at (Position of (Triggering unit)) facing ((Facing of (Triggering unit)) + 144.00) degrees
        Animation - Change (Last created unit)'s size to (150.00%, 150.00%, 150.00%) of its original size
        Unit - Add TENY 2 Assault Blast (Blast Point) to (Last created unit)
        Unit - Set level of TENY 2 Assault Blast (Blast Point) for (Last created unit) to (Level of TENY 2 Assault Blast (Cast Point) for (Triggering unit))
        Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave temp_point[2]
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
--------------------------------------------------------------------------
        Set temp_point[3] = ((Position of (Triggering unit)) offset by 300.00 towards (Facing of (Triggering unit)) degrees)
        Unit - Create 1 Dummy Unit for (Triggering player) at (Position of (Triggering unit)) facing (Facing of (Triggering unit)) degrees
        Animation - Change (Last created unit)'s size to (150.00%, 150.00%, 150.00%) of its original size
        Unit - Add TENY 2 Assault Blast (Blast Point) to (Last created unit)
        Unit - Set level of TENY 2 Assault Blast (Blast Point) for (Last created unit) to (Level of TENY 2 Assault Blast (Cast Point) for (Triggering unit))
        Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave temp_point[3]
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
--------------------------------------------------------------------------
        Set temp_point[4] = ((Position of (Triggering unit)) offset by 300.00 towards ((Facing of (Triggering unit)) + 216.00) degrees)
        Unit - Create 1 Dummy Unit for (Triggering player) at (Position of (Triggering unit)) facing ((Facing of (Triggering unit)) + 216.00) degrees
        Animation - Change (Last created unit)'s size to (150.00%, 150.00%, 150.00%) of its original size
        Unit - Add TENY 2 Assault Blast (Blast Point) to (Last created unit)
        Unit - Set level of TENY 2 Assault Blast (Blast Point) for (Last created unit) to (Level of TENY 2 Assault Blast (Cast Point) for (Triggering unit))
        Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave temp_point[4]
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
--------------------------------------------------------------------------
        Set temp_point[5] = ((Position of (Triggering unit)) offset by 300.00 towards ((Facing of (Triggering unit)) + 288.00) degrees)
        Unit - Create 1 Dummy Unit for (Triggering player) at (Position of (Triggering unit)) facing ((Facing of (Triggering unit)) + 288.00) degrees
        Animation - Change (Last created unit)'s size to (150.00%, 150.00%, 150.00%) of its original size
        Unit - Add TENY 2 Assault Blast (Blast Point) to (Last created unit)
        Unit - Set level of TENY 2 Assault Blast (Blast Point) for (Last created unit) to (Level of TENY 2 Assault Blast (Cast Point) for (Triggering unit))
        Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave temp_point[5]
        Unit - Add a 2.00 second Generic expiration timer to (Last created unit)