Trigger won't create units

[Angrypuffin]

I'm having trouble getting a trigger to remove units of a certain type, and then create more units of different types. I'm not sure why.

The trigger:

• Start Progression
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Unit-type of (Casting unit)) Equal to Genesis Tower
    • (Ability being cast) Equal to Summon New Hero
  • Actions
    • Set TempUnit = (Casting unit)
    • Set TempPlayer = (Owner of TempUnit)
    • Set TempPlayerInt = (Player number of TempPlayer)
    • Set TempUnitInt = (TempPlayerInt + HeroesOwned[TempPlayerInt])
    • Set ProgAgility[TempUnitInt] = 1.00
    • Set ProgIntelligence[TempUnitInt] = 1.00
    • Set ProgStrength[TempUnitInt] = 1.00
    • Set ProgSpeed[TempUnitInt] = 220.00
    • Floating Text - Create floating text that reads Hello! at (TempPlayer start location) with Z offset 0.00, using font size 10.00, color (100.00%, 100.00%, 100.00%), and 0.00% transparency
    • Set ProgText[TempUnitInt] = (Last created floating text)
    • Trigger - Run Progress Text Update <gen> (ignoring conditions)
    • Unit - Set mana of TempUnit to 100.00
    • Game - Display to (Player group(TempPlayer)) the text: Spend the |cff6666f...
    • Game - Display to (All players) the text: (Name of TempPlayer)
    • Unit - Remove Summon New Hero from TempUnit
    • Unit - Add (Range) A-Melee to TempUnit
    • Unit - Add (Range) B-Short to TempUnit
    • Unit - Add (Range) C-Medium to TempUnit
    • Unit - Add (Range) D-Long to TempUnit
    • Unit - Add (Pro) Add Agility to TempUnit
    • Unit - Add (Pro) Add Intelligence to TempUnit
    • Unit - Add (Pro) Add Strength to TempUnit
    • Unit - Add (Pro) Add Speed to TempUnit
    • Unit - Add Finish New Hero to TempUnit
    • Unit - Create 1 Enable Short for TempPlayer at (TempPlayer start location) facing Default building facing degrees
    • Unit - Create 1 Enable Medium for TempPlayer at (TempPlayer start location) facing Default building facing degrees
    • Unit - Create 1 Enable Long for TempPlayer at (TempPlayer start location) facing Default building facing degrees
    • -------- Reset Variables --------
    • Set TempUnit = No unit
    • Set TempPlayerInt = 0
    • Set TempUnitInt = 0

The end is key there. "Enable Short", "Enable Medium", and "Enable Long" are custom units used for tech dependencies (based off peasants, but with Locust). Why aren't they getting created?

 

[Happysmiley]

Does the trigger fire at all? I keep thinking that it might be your conditions that is the problem. Also, does the created units have invisibility?

 

[Angrypuffin]

The trigger definitely fires. The other variables are set correctly, and the floating text is created and updates correctly. Mana is set correctly, and abilities are added and removed correctly.

 

[SwedishChef]

Why do you have the waits there? It makes the trigger non-mui. If more than one unit cast the spell at the same time only the units in the last trigger will be created at the right spot, the first will be created in center of playable map.

Also change model, remove the invisibility or both so you can see where the unit or if it is created.

 

[Happysmiley]

This might also seem like a dumb question, but have you also placed start locations? Otherwise, well I think you know what would happen

 

[SwedishChef]

This might also seem like a dumb question, but have you also placed start locations? Otherwise, well I think you know what would happen

You can't even test the map if you haven't set start locations so dump question yes .

 

[Angrypuffin]

Removed the waits.
I can still see units with Locust.

Strange thing- when I put in some debug code to tell me the name of the player of "TempPlayer", it says "Player 16"- isn't that Neutral Hostile? What's going on here?

Edit: I made some more debug code, and it tells me that the Genesis Tower is owned by [my player name], not player 16.

 

[SwedishChef]

Okey now enable visability for you across the whole map and see if you find the units.

 

[Happysmiley]

You can't even test the map if you haven't set start locations so dump question yes .

What I meant was, has he placed them where they should be and not where the editor randomly places it

 

[SwedishChef]

What I meant was, has he placed them where they should be and not where the editor randomly places it

Ah ok. Well we will see when he enables visibility across the whole map and we see where the units are placed .

 

[Happysmiley]

Ah yeah

 

[Angrypuffin]

Haha, I found out the error. The trigger it called, Progress Text Update, reset TempPlayer to Neutral Hostile. Removed the line, and it works fine.