"Typing" terrain...

[mini.dude_22]

Hello again, i am still working on the same map.
This time the problem is with SubString's. ( yes, i have looked at other posts )
So in my map i want to expand on the terrain types you can use, so i am adding a command in which you can enter the raw code for the terrain you would like to use. Anyways, here is the trigger's.
Doh, i hate substrings :banghead:

Spoiler

function CheckTerrainType takes integer terraintype returns boolean
    local boolean b
    set i = 0
    loop
        exitwhen i > 177 //yes, i have an array with 177 value's for the different types of terrain lol
        if terraintype == terrain<i> then
            set b = true
        else
            set b = false
        endif
        set i = i + 1
    endloop
    return b
endfunction</i>

Spoiler

scope ChangeTerrainVar

private function conditions takes nothing returns boolean
    local integer stringlength = StringLength( GetEventPlayerChatString() )
    local string s = GetEventPlayerChatString()
    local boolean b = false
    if stringlength < 15 then
        if SubString ( s, 1, 9 ) == "-terrain " then
            if SubString ( s, 10, 10 ) == "'" then
                if SubString ( s, 15, 15 ) == "'" then
                set b = true
                else
                call BJDebugMsg ( "Missing the second '" )
                endif
            else
            call BJDebugMsg ( "Missing the first '" )
            endif
        else
        call BJDebugMsg ( "Missing -terrain." ) 
// This fails, if you have just '-terrain' it works, but does not say that i am
// missing either of the ', if i type it in like '-terrain ' it says that terrain failed
// i cant test either of the ', because i cant get past '-terrain ' the space is 
// failing even "-terrain '" with one of the ' says that it still is missing
// the '-terrain'
        endif
    else
    call BJDebugMsg ( "String is too long." ) // This Works
    endif
    return b
endfunction

private function actions takes nothing returns nothing
    local integer terrainrawname = S2I ( SubString ( GetEventPlayerChatString(), 10, 15 ) )
    if CheckTerrainType ( terrainrawname ) then
        set terrainid[GetPlayerId ( GetTriggerPlayer() )] = terrainrawname
        call DisplayTextToPlayer ( Player (GetPlayerId ( GetTriggerPlayer() ) ), 0, 0, "Terrain type changed." )
    else
        call DisplayTextToPlayer ( Player (GetPlayerId ( GetTriggerPlayer() ) ), 0, 0, "Not a valid terrain type, check your quest for all the valid ones. -3" )
    endif   
endfunction

//===========================================================================
function InitTrig_ChangeTerrainVar takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    set i = 0
    loop
        exitwhen i > 8
        call TriggerRegisterPlayerChatEvent( t, Player(i), "-" + "terrain" + " " + "", false )
        set i = i + 1
    endloop
    call TriggerAddCondition ( t, Condition (function conditions) )
    call TriggerAddAction( t, function actions )
endfunction

endscope

 

[Strilanc]

Character dividers start at 0, not 1. (Unless you're using GUI, where it's 1 for some weird reason).

 

[AceHart]

> else
> set b = false

Put the false on the local line.
Otherwise b will always be false unless the "terrain" was the very last one in your list.


> set i = 0

Hm... you have a global variable called i? ...

 

[mini.dude_22]

@Strilanc, Oh thanks.... thats weird. i will give that a try

@AceHart K thanks, and yea, i have a global

 

[mini.dude_22]

K i am still having problems with this trigger, can anyone help me out?

Here i set the String Array Terrain variables:

Spoiler

scope SetTerrainVariables

private function actions takes nothing returns nothing
	set terrain[1] = "Ldrt"
	set terrain[2] = "Ldro"
	set terrain[3] = "Ldrg"
	set terrain[4] = "Lrok"
	set terrain[5] = "Lgrs"
	set terrain[6] = "Lgrd"
	set terrain[7] = "Fdrt"
	set terrain[8] = "Fdro"
	set terrain[9] = "Fdrg"
	set terrain[10] = "Frok"
	set terrain[11] = "Fgrs"
	set terrain[12] = "Fgrd"
	set terrain[13] = "Wdrt"
	set terrain[14] = "Wdro"
	set terrain[15] = "Wsng"
	set terrain[16] = "Wrok"
	set terrain[17] = "Wgrs"
	set terrain[18] = "Wsnw"
	set terrain[19] = "Bdrt"
	set terrain[20] = "Bdrh"
	set terrain[21] = "Bdrr"
	set terrain[22] = "Bdrg"
	set terrain[23] = "Bdsr"
	set terrain[24] = "Bdsd"
	set terrain[25] = "Bflr"
	set terrain[26] = "Bgrr"
	set terrain[27] = "Adrt"
	set terrain[28] = "Adrd"
	set terrain[29] = "Agrs"
	set terrain[30] = "Arck"
	set terrain[31] = "Agrd"
	set terrain[32] = "Avin"
	set terrain[33] = "Adrg"
	set terrain[34] = "Alvd"
	set terrain[35] = "Cdrt"
	set terrain[36] = "Cdrd"
	set terrain[37] = "Cpos"
	set terrain[38] = "Crck"
	set terrain[39] = "Cvin"
	set terrain[40] = "Cgrs"
	set terrain[41] = "Clvg"
	set terrain[42] = "Ndrt"
	set terrain[43] = "Ndrd"
	set terrain[44] = "Nrck"
	set terrain[45] = "Ngrs"
	set terrain[46] = "Nice"
	set terrain[47] = "Nsnw"
	set terrain[48] = "Nsnr"
	set terrain[49] = "Ydrt"
	set terrain[50] = "Ydtr"
	set terrain[51] = "Yblm"
	set terrain[52] = "Ybtl"
	set terrain[53] = "Ysqd"
	set terrain[54] = "Yrtl"
	set terrain[55] = "Ygsb"
	set terrain[56] = "Yhdg"
	set terrain[57] = "Ywmb"
	set terrain[58] = "Vdrt"
	set terrain[59] = "Vdrr"
	set terrain[60] = "Vcrp"
	set terrain[61] = "Vcbp"
	set terrain[62] = "Vstp"
	set terrain[63] = "Vgrs"
	set terrain[64] = "Vrck"
	set terrain[65] = "Vgrt"
	set terrain[66] = "Qdrt"
	set terrain[67] = "Qdrr"
	set terrain[68] = "Qcrp"
	set terrain[69] = "Qcbp"
	set terrain[70] = "Qstp"
	set terrain[71] = "Qgrs"
	set terrain[72] = "Qrck"
	set terrain[73] = "Qgrt"
	set terrain[74] = "Xdrt"
	set terrain[75] = "Xdtr"
	set terrain[76] = "Xblm"
	set terrain[77] = "Xbtl"
	set terrain[78] = "Xsqd"
	set terrain[79] = "Xrtl"
	set terrain[80] = "Xgsb"
	set terrain[81] = "Xhdg"
	set terrain[82] = "Xwmb"
	set terrain[83] = "Ddrt"
	set terrain[84] = "Dbrk"
	set terrain[85] = "Drds"
	set terrain[86] = "Dlvc"
	set terrain[87] = "Dlav"
	set terrain[88] = "Ddkr"
	set terrain[89] = "Dgrs"
	set terrain[90] = "Dsqd"
	set terrain[91] = "Gdrt"
	set terrain[92] = "Gbrk"
	set terrain[93] = "Grds"
	set terrain[94] = "Glvc"
	set terrain[95] = "Glav"
	set terrain[96] = "Gdkr"
	set terrain[97] = "Ggrs"
	set terrain[98] = "Gsqd"
	set terrain[99] = "Zdrt"
	set terrain[100] = "Zdtr"
	set terrain[101] = "Zdrg"
	set terrain[102] = "Zbks"
	set terrain[103] = "Zsan"
	set terrain[104] = "Zbkl"
	set terrain[105] = "Ztil"
	set terrain[106] = "Zgrs"
	set terrain[107] = "Zvin"
	set terrain[108] = "Idrt"
	set terrain[109] = "Idtr"
	set terrain[110] = "Idki"
	set terrain[111] = "Ibkb"
	set terrain[112] = "Irbk"
	set terrain[113] = "Itbk"
	set terrain[114] = "Iice"
	set terrain[115] = "Ibsq"
	set terrain[116] = "Isnw"
	set terrain[117] = "Odrt"
	set terrain[118] = "Odtr"
	set terrain[119] = "Osmb"
	set terrain[120] = "Ofst"
	set terrain[121] = "Olgb"
	set terrain[122] = "Orok"
	set terrain[123] = "Ofsl"
	set terrain[124] = "Oaby"
	set terrain[125] = "Kdrt"
	set terrain[126] = "Kfsl"
	set terrain[127] = "Kdtr"
	set terrain[128] = "Kfst"
	set terrain[129] = "Ksmb"
	set terrain[130] = "Klgb"
	set terrain[131] = "Ksqt"
	set terrain[132] = "Kdkt"
	set terrain[133] = "Jdrt"
	set terrain[134] = "Jdtr"
	set terrain[135] = "Jblm"
	set terrain[136] = "Jbtl"
	set terrain[137] = "Jsqd"
	set terrain[138] = "Jrtl"
	set terrain[139] = "Jgsb"
	set terrain[140] = "Jhdg"
	set terrain[141] = "Jwmb"
	set terrain[142] = "CAc2"
	set terrain[143] = "cAc1"
	set terrain[144] = "cBc2"
	set terrain[145] = "cBc1"
	set terrain[146] = "cKc1"
	set terrain[147] = "cKc2"
	set terrain[148] = "cYc2"
	set terrain[149] = "cYc1"
	set terrain[150] = "cXc2"
	set terrain[151] = "cXc1"
	set terrain[152] = "cJc2"
	set terrain[153] = "cJc1"
	set terrain[154] = "cDc2"
	set terrain[155] = "cDc1"
	set terrain[156] = "cCc2"
	set terrain[157] = "cCc1"
	set terrain[158] = "cIc2"
	set terrain[159] = "cIc1"
	set terrain[160] = "cFc2"
	set terrain[161] = "cFc1"
	set terrain[162] = "cLc2"
	set terrain[163] = "cLc1"
	set terrain[164] = "cWc2"
	set terrain[165] = "cWc1"
	set terrain[166] = "cNc2"
	set terrain[167] = "cNc1"
	set terrain[168] = "cOc1"
	set terrain[169] = "cOc2"
	set terrain[170] = "cZc2"
	set terrain[171] = "cZc1"
	set terrain[172] = "cGc2"
	set terrain[173] = "cGc1"
	set terrain[174] = "cVc2"
	set terrain[175] = "cVc1"
	set terrain[176] = "cQc2"
	set terrain[177] = "cQc1"
endfunction

//===========================================================================
function InitTrig_SetTerrainVariables takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerAddAction( t, function actions )
endfunction

endscope

Here Is the actual trigger. I have fixed it up a bit, It now rejects Many things:

Spoiler

scope ChangeTerrainVar

function CheckTerrainType takes string terraintype returns boolean
    local boolean b = false
    local integer i = 0
    loop
        exitwhen i > 177
        if terraintype == terrain<i> then
            set b = true
        endif
        set i = i + 1
    endloop
    return b
endfunction

private function conditions takes nothing returns boolean
    if SubStringBJ(GetEventPlayerChatString(), 1, 9) != &quot;-terrain &quot; then
        return false
        call DisplayTextToPlayer ( Player (GetPlayerId ( GetTriggerPlayer() ) ), 0, 0, &quot;condition problems&quot; )
    endif
    if StringLength ( GetEventPlayerChatString() ) &gt; 13 then
        return false
        call DisplayTextToPlayer ( Player (GetPlayerId ( GetTriggerPlayer() ) ), 0, 0, &quot;condition problems&quot; )
    endif
    return true
endfunction

private function actions takes nothing returns nothing
    local string terrainrawname = SubString ( GetEventPlayerChatString(), 10, 13 )
    local integer rawint = S2I(&quot;&#039;&quot;+terrainrawname+&quot;&#039;&quot;)
    if CheckTerrainType ( terrainrawname ) then
        set terrainid[GetPlayerId ( GetTriggerPlayer() )] = rawint
        call DisplayTextToPlayer ( Player (GetPlayerId ( GetTriggerPlayer() ) ), 0, 0, &quot;Terrain type changed.&quot; )
    else
        call DisplayTextToPlayer ( Player (GetPlayerId ( GetTriggerPlayer() ) ), 0, 0, &quot;Not a valid terrain type.&quot; )
    endif   
endfunction

//===========================================================================
function InitTrig_ChangeTerrainVar takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    local integer i = 0
    loop
        exitwhen i &gt; 8
        call TriggerRegisterPlayerChatEvent( t, Player(i), &quot;-&quot; + &quot;terrain&quot; + &quot; &quot;, false )
        set i = i + 1
    endloop
    call TriggerAddCondition ( t, Condition (function conditions) )
    call TriggerAddAction( t, function actions )
endfunction

endscope</i>

If you type in just '-terrain ' it says terrain was changed.
If you type in something like '-terrain Nice' It says it failed
?????????????

 

[AceHart]

S2I("'Abcd'") is 0.
Actually, any string starting with ' turns to 0.
Abcd is not an integer anyway, and S2I is of no use here.

If you want to type in raw codes, either add a second array with those names as strings and find the corresponding value,
or write a StringID2Integer function...

 

[mini.dude_22]

How would i do that?

Edit:
I mean the StringID2Integer func?

 

[AceHart]

function Char2Id takes string c returns integer
    local integer i = 0
    local string abc = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
    local string t

    loop
        set t = SubString(abc,i,i + 1)
        exitwhen t == null or t == c
        set i = i + 1
    endloop
    if i < 10 then
        return i + 48
    elseif i < 36 then
        return i + 65 - 10
    endif
    return i + 97 - 36
endfunction

function String2Id takes string s returns integer
    return ((Char2Id(SubString(s,0,1)) * 256 + Char2Id(SubString(s,1,2))) * 256 + Char2Id(SubString(s,2,3))) * 256 + Char2Id(SubString(s,3,4))
endfunction

 

[mini.dude_22]

wow, that doesn't make a ton of sense, but i think i see what its doing. I guess ill have to give it a try. Thanks =D

K just before i test, could you go over to see if it looks good, BTW i changed the terrain variables to integers

Spoiler

scope ChangeTerrainVar

// STRING CONVERSION

function Char2Id takes string c returns integer
    local integer i = 0
    local string abc = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
    local string t

    loop
        set t = SubString(abc,i,i + 1)
        exitwhen t == null or t == c
        set i = i + 1
    endloop
    if i < 10 then
        return i + 48
    elseif i < 36 then
        return i + 65 - 10
    endif
    return i + 97 - 36
endfunction

function String2Id takes string s returns integer
    return ((Char2Id(SubString(s,0,1)) * 256 + Char2Id(SubString(s,1,2))) * 256 + Char2Id(SubString(s,2,3))) * 256 + Char2Id(SubString(s,3,4))
endfunction

// STRING CONVERSION



// CHECK TYPE

function CheckTerrainType takes integer terraintype returns boolean
    local boolean b = false
    local integer i = 0
    loop
        exitwhen i > 177
        if terraintype == terrain<i> then
            set b = true
        endif
        set i = i + 1
    endloop
    return b
endfunction

// CHECK TYPE



// CONDITIONS AND ACTIONS

private function conditions takes nothing returns boolean
    if SubStringBJ(GetEventPlayerChatString(), 1, 9) != &quot;-terrain &quot; then
        return false
        call DisplayTextToPlayer ( Player (GetPlayerId ( GetTriggerPlayer() ) ), 0, 0, &quot;condition problems&quot; )
    endif
    return true
endfunction

private function actions takes nothing returns nothing
    local string terrains = SubString ( GetEventPlayerChatString(), 10, 14 )
    local integer rawint = String2Id ( terrains )
    if CheckTerrainType ( rawint ) then
        set terrainid[GetPlayerId ( GetTriggerPlayer() )] = rawint
        call DisplayTextToPlayer ( Player (GetPlayerId ( GetTriggerPlayer() ) ), 0, 0, &quot;Terrain type changed.&quot; )
    else
        call DisplayTextToPlayer ( Player (GetPlayerId ( GetTriggerPlayer() ) ), 0, 0, &quot;Not a valid terrain type.&quot; )
    endif   
endfunction

// CONDITIONS AND ACTIONS




//??
function InitTrig_ChangeTerrainVar takes nothing returns nothing
    local trigger t = CreateTrigger(  )
    local integer i = 0
    loop
        exitwhen i &gt; 8
        call TriggerRegisterPlayerChatEvent( t, Player(i), &quot;-&quot; + &quot;terrain&quot; + &quot; &quot;, false )
        set i = i + 1
    endloop
    call TriggerAddCondition ( t, Condition (function conditions) )
    call TriggerAddAction( t, function actions )
endfunction

endscope</i>

 

[AceHart]

A couple optimizations are possible.

Other than that, strings, in JASS, start at 0.

 

[mini.dude_22]

Thanks man, your the best!

 

[AceHart]

> set terrain[1] = "Ldrt"

If you edited that to
set terrain[1] = 'Ldrt'
You could compare them directly to String2Id(...)


And, well, it's probably not the best of ideas to try stuff out with terrain[0]... given that value isn't set to anything, chances are that'll crash and burn.


On a related note:

set b = false
loop
- if ... then set b = true
...
endloop
return b

could be:

loop
- if ... then return true
...
endloop
return false

 

[mini.dude_22]

Trigger Makes War 3 Crash - Help

Hi all im back again, This time, my trigger is causing warcraft 3 to crash, it says that it has something to do with the war3 memory in the error message it gives me. Here is the trigger, i know that all my variables work fine in the IF's but im not sure why its crashing can you see why?

Spoiler

scope ChangeTerrainP1

private function actions takes nothing returns nothing
    local location l
    local real x
    local real y
    local integer u
    call TriggerSleepAction ( 0.001 )
    if 'T1x1' == GetUnitTypeId ( GetTriggerUnit() ) then
        set u = 1
    else
        set u = 2
    endif
    set l = GetUnitRallyPoint ( GetTriggerUnit() )
    set x = GetLocationX ( l )
    set y = GetLocationY ( l )
    if IsPointInRegion( area[0], x, y ) then
        call SetTerrainType ( x, y, terrainid[0], -1, u, 1 )
    endif
    call RemoveLocation( l )
endfunction

//===========================================================================
function InitTrig_ChangeTerrainP1 takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterUnitEvent( t, gg_unit_T1x1_0010, EVENT_UNIT_ISSUED_POINT_ORDER )
    call TriggerRegisterUnitEvent( t, gg_unit_T3x3_0009, EVENT_UNIT_ISSUED_POINT_ORDER )
    call TriggerAddAction( t, function actions )
endfunction

endscope

 

[chobibo]

location l is in need of initialization.

local location l=GetSpellTargetLoc()

 

[mini.dude_22]

Hey, im not sure what you are saying, i have changed the line like you showed me, however warcraft 3 still crashes. This is what i have at the moment.

Spoiler

scope ChangeTerrainP1

private function actions takes nothing returns nothing
    local location l = GetSpellTargetLoc()
    local real x
    local real y
    local integer u
    call TriggerSleepAction ( 0.001 )
    if 'T1x1' == GetUnitTypeId ( GetTriggerUnit() ) then
        set u = 1
    else
        set u = 2
    endif
    set l = GetUnitRallyPoint ( GetTriggerUnit() )
    set x = GetLocationX ( l )  // I cant set this untill after the wait, because it wont work. 
//If i dont, it set the location to where the point was previousley. And i am not sure how to 
//inialize the location
    set y = GetLocationY ( l )
    if IsPointInRegion( area[0], x, y ) then
        call SetTerrainType ( x, y, terrainid[0], -1, u, 1 )
    endif
    call RemoveLocation( l )
endfunction

//===========================================================================
function InitTrig_ChangeTerrainP1 takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterUnitEvent( t, gg_unit_T1x1_0010, EVENT_UNIT_ISSUED_POINT_ORDER )
    call TriggerRegisterUnitEvent( t, gg_unit_T3x3_0009, EVENT_UNIT_ISSUED_POINT_ORDER )
    call TriggerAddAction( t, function actions )
endfunction

endscope

 

[AceHart]

> I know that all my variables work fine

Well, if you posted that in the thread where that info is instead of here, people would be able to see that no, actually they aren't.
Unless you edited something since then, in which case you will have to repost that part anyway.

 

[mini.dude_22]

I don't know if this matters, but here is the error that i am getting.

@ AceHart
K sorry

 

[TriggerHappy]

I always get that error


sry i cant help u

 

[mini.dude_22]

oh, thanks I did realize my problem with the terrain not starting at 0 lol and have fixed that.

 

[mini.dude_22]

Someone has to know what it means, jeez... Isn't there anyone that kan figure out how to fix it?