Well seems that I have serious Problems...

[0zaru]

function Trig_Death_Conditions takes nothing returns boolean
	return(GetUnitTypeId(GetTriggerUnit())=='ngzc'or GetUnitTypeId(GetTriggerUnit())=='ngzd'or GetUnitTypeId(GetTriggerUnit())=='ngza'or GetUnitTypeId(GetTriggerUnit())=='ngz4')and IsUnitIllusion(GetTriggerUnit())==false
endfunction

function Death_SafeItems takes nothing returns nothing
	local string lf5=H2Tx(GetOwningPlayer(GetTriggerUnit()))
	local unit lHy=GetUnit(lf5,"ItemHolder")
	local unit lqL=GetUnit(lf5,"Unitr")
	local integer lxx
	local integer lyy
         if lHy==null then
		if PlayerIsSentinel(GetOwningPlayer(lqL))then
			set lxx=-3213
			set lyy=3392
		else
			set lxx=3164
			set lyy=-3275
		endif
		set lHy=CreateUnit(GetOwningPlayer(GetTriggerUnit()),'e000',lxx,lyy,0)
		call SetHandle(lf5,"ItemHolder",lHy)
        endif
        call UnitAddItem(lHy,GetEnumItem())
	call ShowUnit(lHy,true)
endfunction
function Trig_Death_Actions takes nothing returns nothing
	local location liD=GetUnitLoc(GetTriggerUnit())
	local rect lMx=RectFromCenterSizeBJ(liD,300.,150.)
	call EnumItemsInRectBJ(lMx,function Death_SafeItems)
	call RemoveLocation(liD)
	call RemoveRect(lMx)
endfunction
function InitTrig_Death takes nothing returns nothing
	set gg_trg_Death=CreateTrigger()
	call TriggerRegisterAnyUnitEventBJ(gg_trg_Death,EVENT_PLAYER_UNIT_DEATH)
	call TriggerAddCondition(gg_trg_Death,Condition(function Trig_Death_Conditions))
	call TriggerAddAction(gg_trg_Death,function Trig_Death_Actions)
endfunction

Already checked anything that seems bad.. but i can't find anything.. maybe it's something weird but i can't finde anything

 

[Kerberos]

What is it doing and what do you want it to do?

 

[Tom Jones]

As far as I can see, your using the wrong function for your callback function. Shouldn't it be:

	call EnumItemsInRectBJ(lMx,function Death_SafeItems)

If not, please post the SpiritBearDeath_SafeItems function.

 

[PurgeandFire]

Wtf is H2Tx, GetUnit, and PlayerIsSentinel? Please explain, unless you put those functions in the map's header, but I don't think such as system exists except if it is used in your own or one I don't know of/have.

 

[Duwenbasden]

You see why I stress so much on style and comments?

--------------

I am sorry, but without comments or anything to start with, I have no idea what you are trying to do (and to hell I am not going to guess neither). When you want help, you should make sure the helpers can understand your code.

 

[0zaru]

Sorry for no comment about the trigger, but i haved no time..

Well actually all i want for that trigger, is that when a unit Dies (GetUnit (Is a custom function that stores a unit) (Like in handle Variables) Unitr), it stores all items that the unit Owned (It's a custom unit and when it dies, all items go to ground) in another unit that is an item Holder, BUT The items actually don't go to the Item Holder.

For Tom Jones, actually that was and error, of copy, i copied the wrong name (Because i copied the wrong func)

All of them (Is Player in Force 1, etc) are in custom header that i do.

 

[0zaru]

Please any help ? I am really confused

 

[Arkan]

How about some variable names that make sense? Or did you got that code after some optimization? Anyway it's just hard and frustrating to look at the code when the variable names are like that.