Why does this scope kill my map?

Terrabull

Veteran Member (Done that)
Reaction score
38
As the topic says, when I have this enabled no triggers in my map work, as if I had given it an infinite loop in an initializer.

JASS:
scope Forfeit initializer InitForfeit
globals
    integer gWestGive = 0
    integer gEastGive = 0
    boolean array gHasVoted
    timer gFFTimer1
    timer gFFTimer2
endglobals

function ActForfeit2 takes nothing returns nothing
    if gWestGive > 1 and GetExpiredTimer() == gFFTimer1 then
        set udg_Defeated[0] = true
        set udg_Defeated[1] = true
        set udg_Defeated[2] = true
        call DispTxt(gWestName + "has given up!")
    elseif gEastGive > 1 and GetExpiredTimer() == gFFTimer2 then
        set udg_Defeated[3] = true
        set udg_Defeated[4] = true
        set udg_Defeated[5] = true
        call DispTxt(gEastName + "has given up!")
    endif
    if GetExpiredTimer() == gFFTimer1 then
        set gWestGive = 0
        set gHasVoted[0] = false
        set gHasVoted[1] = false
        set gHasVoted[2] = false
    else
        set gEastGive = 0
        set gHasVoted[3] = false
        set gHasVoted[4] = false
        set gHasVoted[5] = false
    endif
endfunction

function ActForfeit takes nothing returns nothing
    local integer PID = GetPlayerId(GetTriggerPlayer())
    local boolean bool = false
    if gHasVoted[PID] == false then
        if GetPlayerId(GetTriggerPlayer()) < 3 then
            set gWestGive = gWestGive + 1
        else
            set gEastGive = gEastGive + 1
        endif
        set gHasVoted[PID] = true
    endif
    if gWestGive == 1 and PID < 3 then
        set bool = GetPlayerId(GetLocalPlayer()) < 3
        call TimerStart(gFFTimer1,30.00,false,function ActForfeit2)
    elseif gEastGive == 1 and PID > 2 then
        set bool = GetPlayerId(GetLocalPlayer()) > 2
        call TimerStart(gFFTimer2,30.00,false,function ActForfeit2)
    endif
    if bool then
        call DispTxt(GetPlayerName(GetTriggerPlayer())+" wants to forfeit.  Type -FF within 30 secnds if you wish to give up.")
    endif
endfunction

//===========================================================================
function InitForfeit takes nothing returns nothing
    local trigger gg_trg_Forfeit2 = CreateTrigger()
    set gg_trg_Forfeit = CreateTrigger()
    call TriggerRegisterAnyPlayerChatEventDK( gg_trg_Forfeit, "-ff", true )
    call TriggerRegisterAnyPlayerChatEventDK( gg_trg_Forfeit, "ff", true )
    call TriggerRegisterAnyPlayerChatEventDK( gg_trg_Forfeit, "FF", true )
    call TriggerRegisterAnyPlayerChatEventDk( gg_trg_Forfeit, "-FF", true )
    call TriggerRegisterAnyPlayerChatEventDK( gg_trg_Forfeit, "-forfeit", true )
    call TriggerRegisterAnyPlayerChatEventDK( gg_trg_Forfeit, "-giveup", true )
    call TriggerAddAction(gg_trg_Forfeit, function ActForfeit)
//    call TriggerRegisterTimerExpireEvent(gg_trg_Forfeit2,gFFTimer1)
//    call TriggerRegisterTimerExpireEvent(gg_trg_Forfeit2,gFFTimer2)
//    call TriggerAddAction(gg_trg_Forfeit2, function ActForfeit2)
endfunction
endscope


EDIT: Okay, now it no longer crashes the map, but it doesn't do anything at all.
 

WolfieeifloW

WEHZ Helper
Reaction score
372
Comment out:
JASS:
local trigger gg_trg_Forfeit2 = CreateTrigger()

---------------
Change this:
JASS:
set gg_trg_Forfeit = CreateTrigger()

To:
JASS:
local trigger gg_trg_Forfeit = CreateTrigger()

---------------
You create a local then don't use it :p .
This:
JASS:
if GetPlayerId(GetTriggerPlayer()) < 3 then

Can be:
JASS:
if PID < 3 then

---------------
You're setting a boolean to an integer:
JASS:
set bool = GetPlayerId(GetLocalPlayer()) < 3

:confused: ?
---------------
AFAIK:
JASS:
if gWestGive > 1

Can never occur.
You only run the timer if it's equal to 1.
Same for "gEastGive".
 

Terrabull

Veteran Member (Done that)
Reaction score
38
You create a local then don't use it :p .
Originally it was two triggers, then I removed one of them and just used a timer when I thought of it.

You're setting a boolean to an integer:
JASS:
set bool = GetPlayerId(GetLocalPlayer()) < 3


GetPlayerId(GetLocalPlayer()) < 3 should be a statement. It will evaluate to true or false. Why it doesn't assign that value to a variable I don't know.

AFAIK:
JASS:
if gWestGive &gt; 1

Can never occur.
You only run the timer if it's equal to 1.
Same for "gEastGive".

If a second player types the trigger it will run a second time, that will set the variable to 2.
 

WolfieeifloW

WEHZ Helper
Reaction score
372
Ah shit yeah.
30 second timer.

And why not do an if for that bool statement?
"if GPI(GLP) < 3 then ___ set bool = true
elseif >3 false"
 

Terrabull

Veteran Member (Done that)
Reaction score
38
I needed it to be a Conditional for a local player, it was more efficient to store the evaluation than to make another if statement that is just the comparisons.
I figured out the problem. The timers weren't Created, and so the rest of the trigger failed after it tried to start them.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Still lurking
    +3
  • The Helper The Helper:
    I am great and it is fantastic to see you my friend!
    +1
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top