A question on Trigger Creation

[CaptainJack]

I'm not particularly sure if what I am trying to do is legal within JASS, but the compiler and any syntax checker I am using is basically saying there is an error without describing it.

The basic questions is it possible to pass parameters for the Condition and Action portion of a trigger, and if so how is this achieved?

function TestFunction1_Conditions takes nothing returns nothing

    // Some Condition

endfunction

function TestFunction1_Actions takes string a returns nothing

    call BJDebugMsg(a)

endfunction 
 
function TestFunction1 takes string a returns nothing
    local trigger test = CreateTrigger()
    
    call TriggerRegisterAnyUnitEventBJ(test, EVENT_PLAYER_UNIT_PICKUP_ITEM)
    call TriggerAddCondition(test, Condition(function TestFunction1_Conditions))
    call TriggerAddAction(test, function TestFunction1_Actions(a))  

endfunction 
 
//==========
function CustomTrigger takes nothing returns nothing

    call TestFunction1("Testing")

endfunction

 

[Laiev]

call TriggerAddAction(test, function TestFunction1_Actions(a))

you can't pass parameters in this way

 

[CaptainJack]

Well then has a workaround been implemented?

 

[Bribe]

Not only, but you just wrote a instead of [ljass]"a"[/ljass].

There are ways to achieve faux-parameters in actions. Realistically, what are you trying to do?

 

[CaptainJack]

Realistically it will end up as a custom system for my map, based around item recipes. And I have no desire to use any that are already on here.

 

[Laiev]

what do you wanna pass to argument for the trigger action?

some example really help to show you others ways

 

[CaptainJack]

I just gave you an example of what I wanted to do, create a trigger that will display the text of that function when an item is acquired. All I want to know is the syntactically correct way to pass that argument because the compiler doesn't give any useful feedback on the issue, and things like JASSCraft don't even see a problem with what is being done, other than that there is a syntax error.

 

[kingkingyyk3]

Use Getxxx() then.

 

[CaptainJack]

Using Get***() still won't fix the fact that I want to pass parameters to the Action section of the trigger.

 

[kingkingyyk3]

GetManipulatedItem()
GetTriggerUnit()
Can't help? I don't think these natives can't help you.

You are in wrong concept, anyway.
Try to look at people's code, you will learn from there.

 

[CaptainJack]

Passing a parameter really isn't the wrong concept for what I want to do here. I want a trigger that is created based off those parameters.

 

[kingkingyyk3]

Attach to trigger.

 

[Bribe]

Passing a parameter really isn't the wrong concept for what I want to do here.

The only way to do exactly this is to use a different programming language. If you want to simply achieve the same thing, you have to do it through attachment methods, not by parameters. Code values can not have parameters in JASS.

A good language that gives you more flexibility in this field is something like JavaScript.

 

[the Immortal]

globals
    hashtable ht      //created in the GUI variable editor if you aren't using vJASS, or even substituted by Table by Vexorian if you do
endglobals

function TestFunction1_Conditions takes string a returns nothing
    local string a
    if GetUnitTypeId(GetTriggerUnit()) == 'hfoo' then               //some condition
        set a = LoadStr(ht, GetHandleId(GetTriggeringTrigger()), 0) //load data
        
        call BJDebugMsg(a)                                          //do smth with it
        
        //call DestroyTrigger(GetTriggeringTrigger())               //eventually clean-up
        //call FlushChildHashtable(ht, GetTriggeringTrigger())
    endif
    return false
endfunction
 
function TestFunction1 takes string a returns nothing
    local trigger test = CreateTrigger()
    
    call TriggerRegisterAnyUnitEventBJ(test, EVENT_PLAYER_UNIT_PICKUP_ITEM)
    call TriggerAddCondition(test, Condition(function TestFunction1_Conditions))
    call SaveStr(ht, GetHandleId(GetTriggeringTrigger()), 0, a)
    
    set test = null
endfunction 
 
//==========
function CustomTrigger takes nothing returns nothing

    call TestFunction1("Testing")

endfunction

Dynamic triggers, as rumors say, mustn't have actions (I've used actions w/ em with no problems, but if you do, you gotta remove them plus the risk of everything crashing and burning). I can't imagine why this would be needed for an item recipe system, as instead of multiple dynamic triggers for i.e. every unit/player you can make one and do checks when the trigger fires.

PS. Freehanded

 

[CaptainJack]

Thanks, all I needed to know is that it was not possible to pass a parameter via the TriggerAdd*() set of functions.