does this leak?

[INCINERATE]

hey can you guys please tell me if this leak

• pigward
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Healing Ward (Pig)
  • Actions
    • Set pigward = (Target point of ability being cast)
    • Unit - Create 1 Pigward for (Triggering player) at pigward facing Default building facing degrees
    • Unit - Add a 25.00 second Generic expiration timer to (Last created unit)
    • Unit - Set level of Healing Ward Aura (Healing Ward piggy) for (Last created unit) to (Level of Healing Ward (Pig) for (Triggering unit))
    • Custom script: call RemoveLocation(udg_pigward)

 

[Accname]

not at all.

 

[Azeroc]

Your eyes aren't so sharp. It does leak - can't you spot (Triggering unit) ? =P

Anyway, you need to set that (Triggering Unit) in variable.

 

[Romek]

> Your eyes aren't so sharp. It does leak - can't you spot (Triggering unit) ? =P
Triggering Unit doesn't leak.

> Anyway, you need to set that (Triggering Unit) in variable.
No, you don't. Just storing something into a variable isn't doing anything anyway. In fact, it could break MUI spells and systems.

 

[Tru_Power22]

Your eyes aren't so sharp. It does leak - can't you spot (Triggering unit) ? =P

Anyway, you need to set that (Triggering Unit) in variable.

Units don't leak. Your wrong.

No the trigger doesn't leak.

 

[Accname]

Your eyes aren't so sharp. It does leak - can't you spot (Triggering unit) ? =P

Anyway, you need to set that (Triggering Unit) in variable.

its only a few variables which leak.
points,
unitgroups,
playergroups,
special effects and such

are the most common. better read through one of the memory leak turtorials again if you are not sure.

 

[Azeroc]

Right... I have read few tutorials. And I see pretty lots of people using stuff like TempUnit for triggering unit...
Anyway sorry if I messed up someone's mind.

 

[Avaleirra]

Then you misread it. Units leak but the leaking unit in this one is removed by the expiration timer. The triggering unit does not leak.

 

[Accname]

the unit is "leaking" because it exists. to remove a "unit leak" you would have to remove that unit and thats no option.

 

[INCINERATE]

somewhere in it is leaking, i am 100% sure, just finished testing with a pal and the frame rate never recoverd after mass casting this spell like 30 times


it just stuck, then i tested my other spells and the frame rates always climbed back up after the spell effects,


if it doesnt leak, what else can it be ? is the set level of ability leaking? does that store on the ram for enternity each time i cast the ward?

 

[Romek]

For the frame rate to drop so suddenly, you'd need to be leaking constantly in a trigger that's run very often, usually with a periodic event.

One leak won't affect the frame rate. I doubt even 10,000 would affect it drastically.

 

[Azeroc]

I once had this problem with one very simple spell, problem actually was in dummy what casted sub-spells. Maybe try to change your ward unit. By the way, what unit ward uses?

And yes, Romek might be right. Do you use any other triggers which events are periodic or same as this?

 

[Accname]

Each time you run this trigger it will create a unit and alot of Units will indeed cause lag. If you keep in mind they are killed merely after 25 seconds it might take a while until your framerate "recovers"

 

[INCINERATE]

im using a rifleman as the ward unit, with his fields set to be targted as a "ward" and model file of the unit is a heal ward and i put the heal ward aura ability on the unit, then i removed his attack / sounds.

i made it like this , so i can make the healing ward move around.. instead of creating 6 heal ward abilities with 6 heal ward units , i figured triggering the level of it on just 1 ward would be easier

 

[Azeroc]

Well, wards doesn't walk, cause their movement is set to NONE or speed to 0...

 

[INCINERATE]

exactly why i used a rifle man . the heal ward is mobile the way i did it

 

[INCINERATE]

yea i have periodics running all game, but i know its either this code or the other code and not my other triggers

cause i just put him into my map today, and none of this lag was present before, and seeing that i only got 2 triggered spells for this guy, it has to be this or the code i posted in the jass section.


but from hardcore testing, i can claim with assurancey the lag comes from this stupid spell . i think im just going to take the long way out, and create 6 abilities with 6 separate units for each heal ward ability and base it off serpent ward or something

 

[Nenad]

Did you put the dummy unit to Can't raise does not decay? x)