Handle > Player

[AdamGriffith]

Does 'player' leak?

Do I have to do this:

    local player p = GetTriggerPlayer()
    ...
    ...
    ...
    set p = null

 

[Vestras]

Everything that extends a handle leaks.
So yes, you'll have to null it.

 

[T.s.e]

You don't need to null players. Players can't be destroyed or created, only defeated or victorized.

 

[Trollvottel]

Cohadar talked about something like this before. Wc3 has a handle recycler which recycles data which dont exist anymore if there is no reference to them. so handles like locations would cause handle leaks if destroyed but not nulled. but player variables will exist the whole game because you cant destroy them so you dont have to null them.

 

[AdamGriffith]

I see
So you only have to null handles which you can destroy?

 

[Flare]

I see
So you only have to null handles which you can destroy?

Not necessarily 'can destroy', but are capable of being/likely to be destroyed in one way or another (e.g. units can die and decay naturally)

 

[AdamGriffith]

Ah okay

 

[T.s.e]

If you destroy a handle, so it must be nulled too.

call DestroyGroup(g)

Must be nulled.

call RemoveLocation(l)

Must be nulled.

call DefeatPlayer(p)

Must not be nulled, since the player still exists in the memory.

-Beaten.

 

[AdamGriffith]

Thanks guys

+repped you all

 

[SFilip]

> Must not be nulled
"Must not" isn't the right thing, "doesn't have to" fits better.

To sum it all up, things that won't be destroyed through the whole game (players, boolexprs, heroes, global locations/rects/regions...) never have to be nulled.