Math Optimization

~GaLs~

† Ғσſ ŧħə ѕαĸε Φƒ ~Ğ䣚~ †
Reaction score
180
I'm bad in math, how should I optimize this code?

JASS:
private function GetDumLvlFrmDist takes real dist return integer
if dist <= 200 then
    return 1
elseif dist >200 and dist <= 400 then
    return 2
elseif dist >400 and dist <= 600 then
    return 3
elseif dist >600 and dist <= 800 then
    return 4
elseif dist >800 and dist <= 1000 then
    return 5
elseif dist >1000 and dist <= 1200 then
    return 6
elseif dist >1200 and dist <= 1400 then
    return 7
elseif dist >1400 and dist <= 1600 then
    return 8
elseif dist >1600 and dist <= 1800 then
    return 9
elseif dist >1800 and dist <= 2000 then
    return 10
endif
endfunction
 
return 1 + R2I(distance) / 200

Not exactly the same though, it excludes the next upper limit.
Though I guess that's not needed anyway.
 
Ace, sorry but I can't use yours.

Lets start with an example.
If the dist is 1000.

It should return 5 as shown in my code.
But if it is in your equation, it would return 6.

1 + R2I(1000) / 200
= 1 + 1000 / 200
= 1 +5
= (6)

*Hope I didn't left out something ;)
 
return 1 + R2I(distance - 1) / 200

Problem solved.
 
> It should return 5 as shown in my code.

No, it shouldn't.
If it did, the distribution wouldn't be uniform anymore as the lowest interval has one more choice than the others.


Though, if you insist:
return (R2I(distance) + 199) / 200
 
>>If it did, the distribution wouldn't be uniform anymore as the lowest interval has one more choice than the others.
What does this means?
 
Well, range 0-200 has 201 members, 201-400 has 200, 401-600 had 200, etc.
 
>>Well, range 0-200 has 201 members, 201-400 has 200, 401-600 had 200, etc.
Hmm, ok, thanks for the point. I get it now.

But it is impossible for a player to cast spell target with 0 dist from the caster, right?
So, I should put it as, 1 - 200, and not 0 - 200.

For this reason, I simply put if dist <= 200 then without specified the smallest value. ;)
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    News portal has been retired. Main page of site goes to Headline News forum now
  • The Helper The Helper:
    I am working on getting access to the old news portal under a different URL for those that would rather use that for news before we get a different news view.
  • Ghan Ghan:
    Easily done
    +1
  • The Helper The Helper:
    https://www.thehelper.net/pages/news/ is a link to the old news portal - i will integrate it into the interface somewhere when i figure it out
  • Ghan Ghan:
    Need to try something
  • Ghan Ghan:
    Hopefully this won't cause problems.
  • Ghan Ghan:
    Hmm
  • Ghan Ghan:
    I have converted the Headline News forum to an Article type forum. It will now show the top 20 threads with more detail of each thread.
  • Ghan Ghan:
    See how we like that.
  • The Helper The Helper:
    I do not see a way to go past the 1st page of posts on the forum though
  • The Helper The Helper:
    It is OK though for the main page to open up on the forum in the view it was before. As long as the portal has its own URL so it can be viewed that way I do want to try it as a regular forum view for a while
  • Ghan Ghan:
    Yeah I'm not sure what the deal is with the pagination.
  • Ghan Ghan:
    It SHOULD be there so I think it might just be an artifact of having an older style.
  • Ghan Ghan:
    I switched it to a "Standard" article forum. This will show the thread list like normal, but the threads themselves will have the first post set up above the rest of the "comments"
  • The Helper The Helper:
    I don't really get that article forum but I think it is because I have never really seen it used on a multi post thread
  • Ghan Ghan:
    RpNation makes more use of it right now as an example: https://www.rpnation.com/news/
  • The Helper The Helper:
  • The Helper The Helper:
    What do you think Tom?
  • tom_mai78101 tom_mai78101:
    I will have to get used to this.
  • tom_mai78101 tom_mai78101:
    The latest news feed looks good

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top