Why wont this run on init?

[AdamGriffith]

scope Trees initializer Init

globals
    private real X
endglobals

public function Loop takes nothing returns nothing
    local destructable d
    local real MaxY = GetRectMaxY(bj_mapInitialPlayableArea)
    local real y = GetRectMinY(bj_mapInitialPlayableArea)
    loop
        exitwhen y > MaxY
        set d = CreateDestructable('LTlt', X, y, GetRandomReal(0.0, 360.0), 1.0, -1)
        set d = null
        set y = y + 128.0
    endloop
endfunction

private function Actions takes nothing returns nothing
    local real MaxX = GetRectMaxX(bj_mapInitialPlayableArea)
    set X = GetRectMinX(bj_mapInitialPlayableArea)
    loop
        exitwhen X > MaxX
        call ExecuteFunc("Trees_Loop")
        set X = X + 128.0
    endloop            
endfunction

//===========================================================================
private function Init takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterTimerEvent(t, 0.0, false)
    call TriggerAddAction(t, function Actions)
endfunction

endscope

Thanks,
Adam

+rep to helpers

 

[TheDamien]

It doesn't? It works fine for me.

By the way, you don't need to make loop public:

scope Trees
    private function Loop takes nothing returns nothing
        // ...
    endfunction

    private function Actions takes nothing returns nothing
        call ExecuteFunc(SCOPE_PRIVATE+"Loop")           
    endfunction
endscope

 

[AdamGriffith]

I added in that event because it wouldnt work at Init.
When you tested did it have the event in it?

I was wondering if it was possible to have all the trees there as soon as the map loads.
So the minimap displays them.

 

[TheDamien]

I basically just copy pasted your code into a test map. Maybe the initialization thread is crashing?

 

[Romek]

You're probably hitting the OP limit with loops like that.
Split the loops into even smaller functions, and use funcname.execute(arg1, arg2) to call them where necessary.

 

[AdamGriffith]

Could you show me an example?

 

[Romek]

Could you show me an example?

Terrain Replacement

It's a very short code (It used to be much, much longer). And it uses function.execute to avoid the OP limit.

 

[Sooda]

I guess you have to make sure in Trigger Editor boxes 'Run At Map Initialization' and 'Enable This Trigger' are checked. Then you even don't need Action function nor local trigger created and can do all actions in Init function.

 

[AdamGriffith]

I will do what you have suggested