simple Equipment System trigger not working

B

Bogomil16

New Member
Reaction score
1
Im jst making it so a hero can only have one of each item class(permanent,campaign,artifact...) but it doesnt work properly at all.Here is the code I added a debugmsg to see whats going on:

JASS:
function ItemCheckWeaponPermanent_Conditions takes nothing returns boolean
    if ( not ( GetItemType(GetManipulatedItem()) == ITEM_TYPE_PERMANENT ) ) then
        return false
    endif
    return true
endfunction

function ItemCheckWeaponPermanent_Actions takes nothing returns nothing

local integer i = 1
local integer count = 0

loop
exitwhen( i == 6 )

if ( GetItemType(UnitItemInSlot(GetManipulatingUnit(), i )) == ITEM_TYPE_PERMANENT ) then

set count = count + 1

endif

set i = i + 1

endloop

if( count == 1 ) then

call UnitDropItemPoint( GetTriggerUnit(), GetManipulatedItem(), GetUnitX( GetTriggerUnit() ), GetUnitY( GetTriggerUnit() ) )

endif

call BJDebugMsg( I2S( count ) )

endfunction

function InitTrig_ItemCheckWeaponPermanent takes nothing returns nothing

set gg_trg_ItemCheckWeaponPermanent = CreateTrigger(  )

call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(0), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(1), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(2), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(3), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(4), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(5), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(6), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(7), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(8), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(9), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(10), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(11), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )

call TriggerAddCondition( gg_trg_ItemCheckWeaponPermanent, Condition( function ItemCheckWeaponPermanent_Conditions ) )
call TriggerAddAction( gg_trg_ItemCheckWeaponPermanent, function ItemCheckWeaponPermanent_Actions )

endfunction


I made one of these triggers for each item class and when i test the map nothing works like i want it to :confused:
 
_whelp said:
What doesn't work properly? Can you please clarify?
Click to expand...

Well first off the loop that increases count is supposed to increase it to 2 if the hero has 2 items of the type PERMANENT i mean if it has one and picks up a second one,the trigger should detect that when count becomes 2,yet it always becomes 1,i don't know why,so I set the condition for dropping the item to be count == 1 instead of 2,because it doesn't work.The other problem is when i made the same trigger for the item classes.Then it doesnt even make a difference between them(it only lets you have only 1 item).I'm confused :banghead:
 
JASS:

//this whole function could be shortened to return (GetItemType(GetManipulatedItem()) == ITEM_TYPE_PERMANENT ))
function ItemCheckWeaponPermanent_Conditions takes nothing returns boolean
    if ( not ( GetItemType(GetManipulatedItem()) == ITEM_TYPE_PERMANENT ) ) then
        return false
    endif
    return true
endfunction

function ItemCheckWeaponPermanent_Actions takes nothing returns nothing

//if I'm not mistaken the first slot is indexed with 0, not 1, but I'm not sure
local integer i = 1
local integer count = 0

loop
exitwhen( i == 6 )

//shouldn't you check if there is actually an item in the slot? (not equal to null)
if ( GetItemType(UnitItemInSlot(GetManipulatingUnit(), i )) == ITEM_TYPE_PERMANENT ) then

set count = count + 1

endif

set i = i + 1

endloop

if( count == 1 ) then

call UnitDropItemPoint( GetTriggerUnit(), GetManipulatedItem(), GetUnitX( GetTriggerUnit() ), GetUnitY( GetTriggerUnit() ) )

endif

call BJDebugMsg( I2S( count ) )

endfunction

function InitTrig_ItemCheckWeaponPermanent takes nothing returns nothing

set gg_trg_ItemCheckWeaponPermanent = CreateTrigger(  )

//all of this should be done with a loop
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(0), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(1), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(2), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(3), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(4), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(5), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(6), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(7), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(8), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(9), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(10), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(11), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )

call TriggerAddCondition( gg_trg_ItemCheckWeaponPermanent, Condition( function ItemCheckWeaponPermanent_Conditions ) )
call TriggerAddAction( gg_trg_ItemCheckWeaponPermanent, function ItemCheckWeaponPermanent_Actions )

endfunction


I wrote comments on your code. Hope I helped :)
 
Bogomil16 said:
Im jst making it so a hero can only have one of each item class(permanent,campaign,artifact...) but it doesnt work properly at all.Here is the code I added a debugmsg to see whats going on:

JASS:
function ItemCheckWeaponPermanent_Actions takes nothing returns nothing

local integer i = 1
local integer count = 0

loop
    exitwhen( i == 6 )
    if ( GetItemType(UnitItemInSlot(GetManipulatingUnit(), i )) == GetItemType(GetManipulatedItem()) ) then
        set count = count + 1
    endif
    set i = i + 1
endloop

if ( count > 1 ) then
    call UnitDropItemPoint( GetTriggerUnit(), GetManipulatedItem(), GetUnitX( GetTriggerUnit() ), GetUnitY( GetTriggerUnit() ) )
endif

call BJDebugMsg( I2S( count ) )

endfunction

function InitTrig_ItemCheckWeaponPermanent takes nothing returns nothing

set gg_trg_ItemCheckWeaponPermanent = CreateTrigger(  )

call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(0), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(1), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(2), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(3), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(4), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(5), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(6), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(7), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(8), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(9), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(10), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )
call TriggerRegisterPlayerUnitEvent( gg_trg_ItemCheckWeaponPermanent, Player(11), EVENT_PLAYER_UNIT_PICKUP_ITEM, null )

call TriggerAddAction( gg_trg_ItemCheckWeaponPermanent, function ItemCheckWeaponPermanent_Actions )

endfunction


I made one of these triggers for each item class and when i test the map nothing works like i want it to :confused:
Click to expand...

Made some changes, removed the condition. Changed to check if itemtype in inventory is = to itemtype of manipulated item. And corrected the count. Try and see if it works.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    Cool Chicken Pasta recipe - Rattlesnake Pasta https://www.thehelper.net/threads/recipe-rattlesnake-pasta.194694/
  • The Helper The Helper:
    News portal has been retired. Main page of site goes to Headline News forum now
  • The Helper The Helper:
    Added the visually stunning Galaxy Cocktail https://www.thehelper.net/threads/cocktail-galaxy-cocktail.194703/
  • The Helper The Helper:
    I am working on getting access to the old news portal under a different URL for those that would rather use that for news before we get a different news view.
  • Ghan Ghan:
    Easily done
     +1
  • The Helper The Helper:
    https://www.thehelper.net/pages/news/ is a link to the old news portal - i will integrate it into the interface somewhere when i figure it out
  • Ghan Ghan:
    Need to try something
  • Ghan Ghan:
    Hopefully this won't cause problems.
  • Ghan Ghan:
    Hmm
  • Ghan Ghan:
    I have converted the Headline News forum to an Article type forum. It will now show the top 20 threads with more detail of each thread.
  • Ghan Ghan:
    See how we like that.
  • The Helper The Helper:
    I do not see a way to go past the 1st page of posts on the forum though
  • The Helper The Helper:
    It is OK though for the main page to open up on the forum in the view it was before. As long as the portal has its own URL so it can be viewed that way I do want to try it as a regular forum view for a while
  • Ghan Ghan:
    Yeah I'm not sure what the deal is with the pagination.
  • Ghan Ghan:
    It SHOULD be there so I think it might just be an artifact of having an older style.
  • Ghan Ghan:
    I switched it to a "Standard" article forum. This will show the thread list like normal, but the threads themselves will have the first post set up above the rest of the "comments"
  • The Helper The Helper:
    I don't really get that article forum but I think it is because I have never really seen it used on a multi post thread
  • Ghan Ghan:
    RpNation makes more use of it right now as an example: https://www.rpnation.com/news/
  • The Helper The Helper:
    Ok
  • The Helper The Helper:
    www.thehelper.net

    Latest News

    The Helper News Feed
    www.thehelper.net www.thehelper.net
  • The Helper The Helper:
    What do you think Tom?
  • tom_mai78101 tom_mai78101:
    I will have to get used to this.
  • tom_mai78101 tom_mai78101:
    The latest news feed looks good
  • The Helper The Helper:
    I would like to see it again like Ghan had it the first time with pagination though - without the pagination that view will not work but with pagination it just might...
  • The Helper The Helper:
    This drink recipe I have had more than a few times back in the day! Mind Eraser https://www.thehelper.net/threads/cocktail-mind-eraser.194720/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      172 (members: 0, guests: 172)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top