Custom script: set bj_wantDestroyGroup = true

jig7c

jig7c

Stop reading me...-statement
Reaction score
123
Custom script: set bj_wantDestroyGroup = true

what does it do? how does it work?

i seen people use this in GUI triggers and then the next action line would be creating a group
Unit Group - All units matching....

but then at the end, there is no group variable to destroy..

explain...
 
It is used by the GUI ForGroup() counterparts. Basically, when you use the BJ's and set it to true, it will [ljass]call DestroyGroup()[/ljass] after enumeration and ForGroup or whatever.

These are the functions that use it, however you are better off using natives if you use JASS, but I'll show you the functions that use it anyway:
JASS:
function IsUnitGroupDeadBJ takes group g returns boolean
function IsUnitGroupEmptyBJ takes group g returns boolean
function ForGroupBJ takes group whichGroup, code callback returns nothing
function GroupAddGroup takes group sourceGroup, group destGroup returns nothing
function GroupRemoveGroup takes group sourceGroup, group destGroup returns nothing
function GroupPickRandomUnit takes group whichGroup returns unit
function CountUnitsInGroup takes group g returns integer

JASS:
function IsUnitGroupDeadBJ takes group g returns boolean
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    set bj_isUnitGroupDeadResult = true
    call ForGroup(g, function IsUnitGroupDeadBJEnum)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(g)
    endif
    return bj_isUnitGroupDeadResult
endfunction
function IsUnitGroupEmptyBJ takes group g returns boolean
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    set bj_isUnitGroupEmptyResult = true
    call ForGroup(g, function IsUnitGroupEmptyBJEnum)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(g)
    endif
    return bj_isUnitGroupEmptyResult
endfunction
function ForGroupBJ takes group whichGroup, code callback returns nothing
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    call ForGroup(whichGroup, callback)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(whichGroup)
    endif
endfunction
function GroupAddGroup takes group sourceGroup, group destGroup returns nothing
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    set bj_groupAddGroupDest = destGroup
    call ForGroup(sourceGroup, function GroupAddGroupEnum)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(sourceGroup)
    endif
endfunction
function GroupRemoveGroup takes group sourceGroup, group destGroup returns nothing
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    set bj_groupRemoveGroupDest = destGroup
    call ForGroup(sourceGroup, function GroupRemoveGroupEnum)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(sourceGroup)
    endif
endfunction
function GroupPickRandomUnit takes group whichGroup returns unit
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    set bj_groupRandomConsidered = 0
    set bj_groupRandomCurrentPick = null
    call ForGroup(whichGroup, function GroupPickRandomUnitEnum)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(whichGroup)
    endif
    return bj_groupRandomCurrentPick
endfunction
function CountUnitsInGroup takes group g returns integer
    // If the user wants the group destroyed, remember that fact and clear
    // the flag, in case it is used again in the callback.
    local boolean wantDestroy = bj_wantDestroyGroup
    set bj_wantDestroyGroup = false

    set bj_groupCountUnits = 0
    call ForGroup(g, function CountUnitsInGroupEnum)

    // If the user wants the group destroyed, do so now.
    if (wantDestroy) then
        call DestroyGroup(g)
    endif
    return bj_groupCountUnits
endfunction
 
sorry to say this, but it doesn't make sense to me..

so instead of setting a group into a variable, you can use that BJ and you do'nt have to destroy the variable then? it automatically destroys it?
 
Yes. Since all the group functions in GUI are BJ's, blizzard added the check to allow for easy group destroying. It checks if the bj_ is true, and if so, it will destroy the group after performing the actions it needs to. This way, the only real time you need to set a variable for groups is if you need to reference it later or you basically don't want to destroy it immediately.
 
ha-
i didn't know that
very interesting...
now you seem to an expert on this matter purge, so i'll ask you this..

which one is more efficient/quicker/better???
Trigger:
  • Sample I
    • Set UnitGroup = All units within 500 range of Point
    • Unit Group - Pick every unit in UnitGroup and do
      • Loop
        • Unit - Kill (Picked Unit)
    • Custom script: call DestroyGroup (udg_UnitGroup)

or

Trigger:
  • Sample II
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 500 range of Point)
      • Loop
        • Unit - Kill (Picked Unit)
 
PurgeandFire I saw your work at Photobucket. I must say dude it's awesome :D which platform you used ?
 
jig7c said:
ha-
i didn't know that
very interesting...
now you seem to an expert on this matter purge, so i'll ask you this..

which one is more efficient/quicker/better???
Trigger:
  • Sample I
    • Set UnitGroup = All units within 500 range of Point
    • Unit Group - Pick every unit in UnitGroup and do
      • Loop
        • Unit - Kill (Picked Unit)
    • Custom script: call DestroyGroup (udg_UnitGroup)

or

Trigger:
  • Sample II
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units within 500 range of Point)
      • Loop
        • Unit - Kill (Picked Unit)
Click to expand...

Efficiency-wise there isn't really a difference. But in terms of implementation (the fact that a custom global variable is needed) makes the set bj_wantDestroyGroup "easier". :p Besides, one less global needed then. It is basically your choice, since they both require a variable setting and both call the same function ( DestroyGroup ).

shazada said:
PurgeandFire I saw your work at Photobucket. I must say dude it's awesome :D which platform you used ?
Click to expand...

Hehe thanks, I used Photoshop CS2 for some and CS3 for the later ones. But I haven't done that in a while and I haven't bothered to install it D=
 
Don't use it with "Enum units of type", because GUI fails, it will enum only units of Player(0) (red), and the group will be destroyed after this first enumeration.
And probably some other fancy stuff like leaking a group (didn't investigate this GUI code so much, a fail is a fail)
So i suggest to always use the custom script DestroyGroup instead.

Also if you really care about efficiency, learn jass.
GUI is all but not efficient.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Varine Varine:
    I don't think he ever figured out how to do the calamari in a pan though, like idk how to do that either. He was afraid of the at home deep fryers though and it's like yeah, that's fair, I am too
  • Varine Varine:
    He was just such a sweet old man, we had two servers pregnant and they held a baby shower together, he was soooooo fucking excited to get to see a baby. Unfortunately he died a month or so before they were born
  • The Helper The Helper:
    So I decided to Google some people that I had not seen or heard from in a while and sure enough one of my old best friends, we had a falling out years ago but whatever, find out he died of Pancreatic Cancer in January. I have also lost a few of my closer acquaintances from growing up the last year. Getting old - people die - I kinda thought it was going to be this way a few years ago....
     +2
  • The Helper The Helper:
    Forum running super slow again
  • Ghan Ghan:
    Not really clear from the stats as to what is causing the slowness.
  • Ghan Ghan:
    We get a lot of guest traffic so it may just be the load is getting too high and not from any particular source.
  • Ghan Ghan:
    Looks like the server is maxed out on CPU.
  • Ghan Ghan:
    Oh it looks like a lot of the traffic is Silkroad Forums. That domain isn't protected by Cloudflare.
  • Ghan Ghan:
    But the old Silkroad site is still on its own server. I just had a test site set up on this server for it.
  • Ghan Ghan:
    I just disabled that test site. Let's see if that helps the load.
  • Ghan Ghan:
    Looks much better already.
  • The Helper The Helper:
    I had actually forgot about the Silkroad site. I had asked
  • The Helper The Helper:
    SD Ryoko about it and he said the couple of people left on there really like it, that was a few years ago, maybe I should check back
  • jonas jonas:
    I guess when you're getting old, and the last day of soup season draws near, you start wondering
  • jonas jonas:
    will I make it to the start of the next season? or was this the last time I'll ever have my favorite dish?
  • The Helper The Helper:
    I am doing my first Vibe Coding project. In installed the environment and tools according to instructions but it is all chat doing this for me at my direction. It is fun really and holy shit I might finish in 2 hours what it would have taken a day to in my Access and this would be an electron app complete new
  • Ghan Ghan:
    Good stuff.
  • Ghan Ghan:
    Just make sure it is secure. :)
     +1
  • The Helper The Helper:
    It will only be on internal network
  • jonas jonas:
    Man the AI is good about gaslighting about security though. I've had several times where I pointed out security problems and it tried to convince me that with a tiny tweak it suddenly becomes secure
  • jonas jonas:
    Like using a distrobox as a "secure" container, and when I point out that's not secure at all, it claimed that specifying home will make it secure
  • The Helper The Helper:
    Yeah I finished the app today and it is bad ass. Like ChatGPT codes way better and faster than me that is for sure. The app is unsecure AF though and I would never put it anywhere it was obvious. I did not even show it today, the boss never made it in, but I showed the office and they liked it and frankly, I do software for a living and I am qualified to judge this kind of stuff and... Holy Shit this is a game changer. It took me around 4 hours to finish the app from design to end and that is much faster than I could have done it in the outdated MS Access the thing it replaced was in. Good Stuff! Had tons of fun doing it too! Work has not been fun in a while - today was fun!
     +1
  • The Helper The Helper:
    And really, I did not do it, chat wrote all the code I just pasted it in, tested it, acted like Chats eyes on it and just learned. I learned VS Code, how to use the Terminal and a bunch of Powershell and Command stuff, I used Git for the first time and learned how to save, search, start my server, stop it, run the tests, do some debugging - all the freaking fun stuff - chat wrote all the code
     +1
  • The Helper The Helper:
    I think the key was the 40 minutes of that 4 hours that went into the design of it. The thing was fully specced out before we started and the only reason it took so long was I had never done any of it and had to get used to the navigation and workflow.
     +1
  • The Helper The Helper:
    React, JS and AG Grid are the tools that I know i used along with git. I learned alot but it will be a minute before I fully understand everything I am doing in these environments because I am really just following instructions.
     +1

      The Helper Discord

      Members online

      No members online now.
      Online now:
      352 (members: 0, guests: 352)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials
      Top