Gui --> jass

[MasterRofl]

Map on second page

Why does this work

• Revive Hero
  • Events
    • Time - Map_Revive_Timers[1] expires
    • Time - Map_Revive_Timers[2] expires
    • Time - Map_Revive_Timers[3] expires
    • Time - Map_Revive_Timers[4] expires
    • Time - Map_Revive_Timers[6] expires
    • Time - Map_Revive_Timers[7] expires
    • Time - Map_Revive_Timers[8] expires
    • Time - Map_Revive_Timers[9] expires
  • Conditions
  • Actions
    • Unit Group - Pick every unit in Map_Revivable_Heroes and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Remaining time for Map_Revive_Timers[((Player number of (Owner of (Picked unit))) - 1)]) Less than 1.00
          • Then - Actions
            • Hero - Instantly revive (Picked unit) at (Center of Hero Spawn <gen>), Show revival graphics
            • Countdown Timer - Destroy Map_Revive_Timer_Windows[((Player number of (Owner of (Picked unit))) - 1)]
            • Unit Group - Remove (Picked unit) from Map_Revivable_Heroes
          • Else - Actions

and this not work?

scope ReviveHero initializer Init

private function Callback takes nothing returns nothing
    local location HeroSpawnCenter = GetRectCenter(gg_rct_Hero_Spawn)
    if ( TimerGetRemaining(udg_Map_Revive_Timers[GetPlayerId(GetOwningPlayer(GetEnumUnit()))]) < 1.00 ) then
        call ReviveHeroLoc( GetEnumUnit(), HeroSpawnCenter, true )
        call DestroyTimerDialog( udg_Map_Revive_Timer_Windows[GetPlayerId(GetOwningPlayer(GetEnumUnit()))] )
        call GroupRemoveUnit( udg_Map_Revivable_Heroes, GetEnumUnit() )
    endif
    call RemoveLocation(HeroSpawnCenter)
    set HeroSpawnCenter = null
endfunction

private function Actions takes nothing returns nothing
    call ForGroup( udg_Map_Revivable_Heroes, function Callback )
endfunction

private function Init takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterTimerExpireEvent( t, udg_Map_Revive_Timers[1] )
    call TriggerRegisterTimerExpireEvent( t, udg_Map_Revive_Timers[2] )
    call TriggerRegisterTimerExpireEvent( t, udg_Map_Revive_Timers[3] )
    call TriggerRegisterTimerExpireEvent( t, udg_Map_Revive_Timers[4] )
    call TriggerRegisterTimerExpireEvent( t, udg_Map_Revive_Timers[6] )
    call TriggerRegisterTimerExpireEvent( t, udg_Map_Revive_Timers[7] )
    call TriggerRegisterTimerExpireEvent( t, udg_Map_Revive_Timers[8] )
    call TriggerRegisterTimerExpireEvent( t, udg_Map_Revive_Timers[9] )
    call TriggerAddAction( t, function Actions )
endfunction

endscope

 

[Troll-Brain]

What the vJass version does it exactly ?
Also try to put DebugMsg

 

[MasterRofl]

The vJass one is supposed to do the same thing. However, it does not work.

 

[Troll-Brain]

I mean the function CallBack is called correctly and all ?
What is working in the jass trigger ?
Put some BJDebugMsg.

 

[MasterRofl]

When I use a trigger to kill my hero, it's added to the group "udg_Map_Revivable_Heroes" and udg_Map_Revive_Timers is started (i = player number of owner of hero). Right now (and I have no idea why), the vJass trigger's Actions aren't even being triggered.

Edit: Included timer-creating trigger

scope ReviveHeroTimer initializer Init

private function Conditions takes nothing returns boolean
    return ( IsUnitType(GetDyingUnit(), UNIT_TYPE_HERO) == true )
endfunction

private function Actions takes nothing returns nothing
    call GroupAddUnit( udg_Map_Revivable_Heroes, GetDyingUnit() )
    set udg_Map_Temp_Real = I2R(GetHeroLevel(GetDyingUnit())) * 3.00
    call TimerStart( udg_Map_Revive_Timers[GetPlayerId(GetOwningPlayer(GetDyingUnit()))], udg_Map_Temp_Real, false, null )
    call CreateTimerDialogBJ( udg_Map_Revive_Timers[GetPlayerId(GetOwningPlayer(GetDyingUnit()))], "Time until respawn:" )
    call TimerDialogDisplayForPlayerBJ( true, udg_Map_Revive_Timer_Windows[GetPlayerId(GetOwningPlayer(GetDyingUnit()))], GetOwningPlayer(GetDyingUnit()) )
    set udg_Map_Revive_Timer_Windows[GetPlayerId(GetOwningPlayer(GetDyingUnit()))] = bj_lastCreatedTimerDialog
endfunction

private function Init takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddCondition( t, Condition( function Conditions ) )
    call TriggerAddAction( t, function Actions )
endfunction

endscope

Also, how do you go about using BJDebugMsg? Is it like Game Text, but shows only when debug mode is turned on in your editor?

 

[Troll-Brain]

No it's not a native function, it's just fast to write and display the string for all players, say if the string is null, the strings are displayed during a very long time, perfect for debugging purpose.
It's a blizzard function, you can look how it is make, but you don't need it.

 

[MasterRofl]

call DisplayTimedTextToPlayer(Player(i),0,0,60,msg)

Just that? (where i is looping through all players)

 

[SerraAvenger]

call DisplayTimedTextToPlayer(Player(i),0,0,60,msg)

Just that? (where i is looping through all players)

yes.
I recommend using

call DisplayText( LOCAL_PLAYER, RED + msg )

or, if you're not using the Utilities library,

call DisplayTimedTextToPlayer( GetLocalPlayer(), 0, 0, 60, "|c802020" + msg )

 

[Troll-Brain]

call DisplayTimedTextToPlayer(Player(i),0,0,60,msg)

Just that? (where i is looping through all players)

Yes but it's easy and fast to write, only one argument, perfect for debugging purpose like i said.

@SerraAvenger : Wtf ?!
It's just for debugging his trigger, it's silly to don't use BJDebugMsg for this ...

 

[SerraAvenger]

Yes but it's easy and fast to write, only one argument, perfect for debugging purpose like i said.

Not always. It is friggin slow and when you're testing fast stuff, it can slow down your whole map enourmously.

 

[MasterRofl]

Link to Utilities lib please?

On-topic: What's making the trigger not fire? When I use the GUI trig, it works perfectly fine, and I don't really see a diff between them...

 

[Troll-Brain]

Well i dunno the period of his timers but maybe you're right if the period is short.

EDIT : But heh for testing he should increase the period anyway.

The trigger doesn't fire at all ?

 

[SerraAvenger]

Link to Utilities lib please?

http://www.hiveworkshop.com/forums/...ies-library-jass-97943-post812591/#post812591

I have a version uploaded on thelper too, but that one has less documentation.

 

[MasterRofl]

Nope, it doesn't fire. I just a

call DisplayTimedTextToForce(GetPlayersAll(),60,"Revive Hero Actions Function called!")

in the first line of the Actions function and there was no msg

 

[Troll-Brain]

attach your map.

 

[MasterRofl]

Hero Revive category; triggers in question are "Revive Hero" and "Working Revive Hero" (press Esc to kill heroes)

 

[Troll-Brain]

And when the timers are supposed to start ? You don't really let us to help you ...
But anyways my bed call me, gl.

 

[MasterRofl]

And when the timers are supposed to start ? You don't really let us to help you ...
But anyways my bed call me, gl.

When I use a trigger to kill my hero, it's added to the group "udg_Map_Revivable_Heroes" and udg_Map_Revive_Timers is started (i = player number of owner of hero). Right now (and I have no idea why), the vJass trigger's Actions aren't even being triggered.

Edit: Included timer-creating trigger

scope ReviveHeroTimer initializer Init

private function Conditions takes nothing returns boolean
    return ( IsUnitType(GetDyingUnit(), UNIT_TYPE_HERO) == true )
endfunction

private function Actions takes nothing returns nothing
    call GroupAddUnit( udg_Map_Revivable_Heroes, GetDyingUnit() )
    set udg_Map_Temp_Real = I2R(GetHeroLevel(GetDyingUnit())) * 3.00
    call TimerStart( udg_Map_Revive_Timers[GetPlayerId(GetOwningPlayer(GetDyingUnit()))], udg_Map_Temp_Real, false, null )
    call CreateTimerDialogBJ( udg_Map_Revive_Timers[GetPlayerId(GetOwningPlayer(GetDyingUnit()))], "Time until respawn:" )
    call TimerDialogDisplayForPlayerBJ( true, udg_Map_Revive_Timer_Windows[GetPlayerId(GetOwningPlayer(GetDyingUnit()))], GetOwningPlayer(GetDyingUnit()) )
    set udg_Map_Revive_Timer_Windows[GetPlayerId(GetOwningPlayer(GetDyingUnit()))] = bj_lastCreatedTimerDialog
endfunction

private function Init takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddCondition( t, Condition( function Conditions ) )
    call TriggerAddAction( t, function Actions )
endfunction

endscope

Also, how do you go about using BJDebugMsg? Is it like Game Text, but shows only when debug mode is turned on in your editor?

There