+1% mana per unit (make sense?)

[Epicurus]

I want the triggering unit to get +1 Percent mana per unit it saves, but I couldn't find a add mana. There was only a set mana, so I came up with this. Does it make sense?

• Unit Group - Pick every unit in (Units in secondary death 01 02 <gen> owned by Player 10 (Light Blue)) and do (Actions)
  • Loop - Actions
    • Unit - Create 1 Civilian (Male 2) for Player 10 (Light Blue) at (Random point in Civil creation 01 <gen>) facing Default building facing degrees
    • Unit - Set mana of (Triggering unit) to ((Percentage mana of (Triggering unit)) + 1.00)%
    • Unit - Remove (Picked unit) from the game

 

[Renendaru]

Unfortunately, to add 1% is a bit out there. You'd have to create abilities to add mana to the hero about as many as times as you think your heroes have mana. Say 1-2000?

 

[Exide]

What do you mean 'per unit it saves'?
Your trigger leaks.

You want to add 1% of maximum mana to a certain unit, when "A unit is saved"?

 

[Epicurus]

Well would +x mana rather than percent be easier?

And, what do you mean by leak?

Heres the full trigger, maybe that will make "Unit saved" more clear.

• Save01
  • Events
    • Unit - A unit enters secondary death 01 02 <gen>
  • Conditions
    • ((Item carried by (Triggering unit) of type Reanimation Device) is owned) Equal to True
    • ((Triggering unit) is A Hero) Equal to True
    • ((Owner of (Triggering unit)) controller) Equal to User
  • Actions
    • Item - Remove (Item carried by (Triggering unit) of type Reanimation Device)
    • Hero - Add ((Integer((Real((Number of units in (Units in secondary death 01 <gen> owned by Player 10 (Light Blue))))))) x 10) experience to (Triggering unit), Hide level-up graphics
    • Player - Add ((Integer((Real((Number of units in (Units in secondary death 01 <gen> owned by Player 10 (Light Blue))))))) x 10) to (Owner of (Triggering unit)) Current gold
    • Player - Add ((Integer((Real((Number of units in (Units in secondary death 01 <gen> owned by Player 10 (Light Blue))))))) x 1) to (Owner of (Triggering unit)) Current lumber
    • Unit Group - Pick every unit in (Units in secondary death 01 02 <gen> owned by Player 10 (Light Blue)) and do (Actions)
      • Loop - Actions
        • Unit - Create 1 Civilian (Male 2) for Player 10 (Light Blue) at (Random point in Civil creation 01 <gen>) facing Default building facing degrees
        • Unit - Set mana of (Triggering unit) to ((Percentage mana of (Triggering unit)) + 1.00)%
        • Unit - Remove (Picked unit) from the game

 

[Exide]

Leaks cause lag. We don't want that.
Your trigger leaks unit groups and point leaks.

You should rewrite your trigger like this:

Save01 
Events 
Unit - A unit enters secondary death 01 02 <gen> 
Conditions 
((Item carried by (Triggering unit) of type Reanimation Device) is owned) Equal to True 
((Triggering unit) is A Hero) Equal to True 
((Owner of (Triggering unit)) controller) Equal to User 
Actions
[B]set tempgroup = Units in (secondary death 01 02 <gen> owned by Player 10 (Light Blue)))[/B] 
Item - Remove (Item carried by (Triggering unit) of type Reanimation Device) 
Hero - Add ((Integer((Real((Number of units in [B]tempgroup[/B] x 10) experience to (Triggering unit), [B]Show[/B] level-up graphics 
Player - Add ((Integer((Real((Number of units in [B]tempgroup[/B] x 10) to (Owner of (Triggering unit)) Current gold 
Player - Add ((Integer((Real((Number of units in [B]tempgroup[/B] x 1) to (Owner of (Triggering unit)) Current lumber 
Unit Group - Pick every unit in [B]tempgroup[/B] and do (Actions) 
Loop - Actions
[I]set temppoint = (Random point in Civil creation 01 <gen>)[/I]
Unit - Create 1 Civilian (Male 2) for Player 10 (Light Blue) at [I]temppoint[/I] facing Default building facing degrees
custom script  call RemoveLocation(udg_temppoint) 
Unit - Set mana of (Triggering unit) to ((Percentage mana of (Triggering unit)) + 1.00)% 
Unit - Remove (Picked unit) from the game

>would +x mana rather than percent be easier?
-Yes.


EDIT: More information on memory leaks can be found here:
http://www.thehelper.net/forums/showthread.php?t=27219

 

[Epicurus]

Ok, thanks. Does this work for the +mana?

• Unit - Set mana of (Triggering unit) to ((Mana of (Triggering unit)) + 1.00)

 

[Exide]

No, that just increases the current mana of the unit (not the maximum mana).
You should create an ability based of an item ability that increases maximum mana of the unit by X (for example 10) - then give this to the Hero.
(I don't have WE with me atm, so I'm not sure what item ability you should use, or if there even is one - but I'm sure you'll find it if you search.)

 

[Epicurus]

Oh sorry, I wanted to increase current mana. I'm using it to replace most mana regen.

Don't you have to destroy the temp group too? I'm already reading.

 

[Renendaru]

Then that trigger works perfectly. Aside from leaks.

 

[Exide]

Oh sorry, I wanted to increase current mana. I'm using it to replace most mana regen.

Don't you have to destroy the temp group too? I'm already reading.

If you want to increase current mana (like drinking a mana potion) then your trigger will work fine.

Yes, of course, my bad.
Yes, you have to call DestroyGroup(udg_tempgroup)

 

[Epicurus]

Just wondering if this looks right. I added numbers to the temp locations and groups because I have multiple areas on the map where this happens and I don't know if it would cause problems to use 1 temp---- for everything.

• Save01
  • Events
    • Unit - A unit enters secondary death 01 02 <gen>
  • Conditions
    • ((Item carried by (Triggering unit) of type Reanimation Device) is owned) Equal to True
    • ((Triggering unit) is A Hero) Equal to True
    • ((Owner of (Triggering unit)) controller) Equal to User
  • Actions
    • Set Tempgroup_S01 = (Units in secondary death 01 02 <gen> owned by Player 10 (Light Blue))
    • Item - Remove (Item carried by (Triggering unit) of type Reanimation Device)
    • Hero - Add ((Integer((Real((Number of units in Tempgroup_S01))))) x 10) experience to (Triggering unit), Show level-up graphics
    • Player - Add ((Integer((Real((Number of units in Tempgroup_S01))))) x 10) to (Owner of (Triggering unit)) Current gold
    • Player - Add ((Integer((Real((Number of units in Tempgroup_S01))))) x 1) to (Owner of (Triggering unit)) Current lumber
    • Unit Group - Pick every unit in Tempgroup_S01 and do (Actions)
      • Loop - Actions
        • Set Temppoint_C01 = (Random point in Civil creation 01 <gen>)
        • Unit - Create 1 Civilian (Male 2) for Player 10 (Light Blue) at Temppoint_C01 facing Default building facing degrees
        • Unit - Set mana of (Triggering unit) to ((Mana of (Triggering unit)) + 1.00)
        • Unit - Remove (Picked unit) from the game
        • Custom script: call DestroyGroup (udg_Temppoint_C01)
    • Custom script: call DestroyGroup (udg_Tempgroup_S01)

 

[Genkora]

Unit - Set mana of (Triggering unit) to ((Mana of (Triggering unit)) + 1.00)

that won't give it 1% mana though, just 1 mana. It should be ((Mana of (Triggering unit)) + ((Mana of (Triggering unit) x .01)

that will give 1%

edit- sorry, I didn't realize you meant to change that at the time of my post